Arch Linux User Repository

@batot: PKGBUILD is broken !!

All files required to build the package have to be listed in the source[] array.

Then in prepare stage they are getting copied to ${srcdir} for build() to run.

You can't rely on ${srcdir}/.. pointing to the cloned dir with some extra files build needs.

makepkg can build outside of the current path (using $DSTDIR) with sources being downloaded outside of the clone dir (using $SRCDST).

https://wiki.archlinux.org/title/Makepkg#Package_output

Also, there's already the netatop-dkms package for the dkms infrastructure, so your dkms changes here are redundant.

btw. you don't have to list base-devel in the makedepends[] array - it's implied.

All you need to do to update this package was: http://0x0.st/8VVX.diff

• DKMS required
  
• propably working wiht LTS (still testing)
• running with flag "-K"

At this moment I have now 2 version.

3.2.2 on systemd - working 100% property

3.2.2 on DKMS - not working 70% done - bugs when DKMS trying compile files.

In the future i try fusion all version DKMS/LTS/systemd for only 1 version. Probably will be not easy but I try.

The package does not require DKMS to function.

Why is this package able to work without dkms?

Hi all. I was testing with Archlinux with kernel 5.15.84 and working property.

If I will be find time, I put file PKGBUILD to replace for MANJARO systems.

Have you updated your kernel without rebooting? I believe Manjaro (like Arch) will delete the /lib/modules/<old_kernel_version> when doing an upgrade, so you can't install kernel modules after you've updated it.

Errors out

:: Processing package changes...
(1/1) installing netatop                                                                                                                                                 [#########################################################################################################] 100%
depmod: ERROR: could not open directory /lib/modules/5.15.6-2-MANJARO: No such file or directory
depmod: FATAL: could not search modules: No such file or directory
modprobe: FATAL: Module netatop not found in directory /lib/modules/5.15.6-2-MANJARO
error: command failed to execute correctly

I have submitted a patch to upstream by building on eggz' work, and my own grep fu :)

This time, it is related to a change in the timespec struct in the kernel, and a move to proc_ops from filesystem_operations. See commits 22b17db4ea05561c7c8e4d770f10751e22e339f9 and d56c0d45f0e27f814e87a1676b6bdccccbc252e9 of the kernel repo.

Here's the patch:

diff -aur src.pristine/netatop-3.0/module/netatop.c src.new/netatop-3.0/module/netatop.c
--- src.pristine/netatop-3.0/module/netatop.c   2020-04-27 08:28:05.649361867 -0400
+++ src.new/netatop-3.0/module/netatop.c    2020-04-27 09:00:29.473109963 -0400
@@ -270,7 +270,12 @@

 static struct task_struct  *knetatop_task;

-static struct timespec boottime;
+
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 6, 0)
+               static struct timespec64    boottime;
+#else
+               static struct timespec  boottime;
+#endif

 /*
 ** function prototypes
@@ -346,14 +351,22 @@
         .owner          = THIS_MODULE,
 };

+#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 6, 0)
+static struct proc_ops netatop_proc_fops = {
+   .proc_open          = netatop_open,
+   .proc_read          = seq_read,
+   .proc_lseek         = seq_lseek,
+   .proc_release       = single_release,
+};
+#else
 static struct file_operations netatop_proc_fops = {
-   .open           = netatop_open,
-   .read           = seq_read,
-   .llseek         = seq_lseek,
-   .release    = single_release,
-   .owner          = THIS_MODULE,
+   .open           = netatop_open,
+   .read           = seq_read,
+   .llseek         = seq_lseek,
+   .proc_release   = single_release,
+   .owner                  = THIS_MODULE
 };
-
+#endif

 /*
 ** hook function to be called for every incoming local packet
@@ -1745,7 +1758,11 @@
        spin_lock_init(&shash[i].lock);
    }

-   getboottime(&boottime);
+   #if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 6, 0)
+       getboottime64(&boottime);
+   #else
+       getboottime(&boottime);
+   #endif

    /*
    ** register getsockopt for user space communication

FYI, eggz provided some amendments to prepare() in the comments for the netatop-dkms package that worked for me.