Package Details: neural-amp-modeler-lv2-git 0.1.3.r14.43fb036-1

Git Clone URL: https://aur.archlinux.org/neural-amp-modeler-lv2-git.git (read-only, click to copy)
Package Base: neural-amp-modeler-lv2-git
Description: Neural Amp Modeler (NAM) LV2 plugin (git version)
Upstream URL: https://github.com/mikeoliphant/neural-amp-modeler-lv2
Keywords: amp guitar lv2 plugin
Licenses: GPL3
Conflicts: neural-amp-modeler-lv2
Provides: neural-amp-modeler-lv2
Submitter: LekKit
Maintainer: LekKit (SpotlightKid)
Last Packager: SpotlightKid
Votes: 2
Popularity: 0.33
First Submitted: 2023-12-23 11:52 (UTC)
Last Updated: 2023-12-29 08:24 (UTC)

Latest Comments

SpotlightKid commented on 2023-12-29 08:30 (UTC)

I have updated the PKGBUILD. Unfortunately, the new version number returned by pkgver is considered lower than the previous one, which contained an underscore.

I removed the following architectures from arch: arm, arch6h, i386, ppc. I kept armv7h, since I think that is what the MOD platform runs on. I we get reports of the plugin successfully running on any of these platforms, we can add them back.

I also enabled parallel building with -j $(nproc --ignore=1).

SpotlightKid commented on 2023-12-29 08:19 (UTC)

From https://wiki.archlinux.org/title/PKGBUILD#makedepends:

The package base-devel is assumed to be already installed when building with makepkg. Dependencies of this package should not be included in makedepends array.

base-devel includes make and gcc as its dependencies:

https://archlinux.org/packages/core/any/base-devel/

To use the AUR, you always need to install base-devel, as per https://wiki.archlinux.org/title/Arch_User_Repository#Getting_started

LekKit commented on 2023-12-29 02:15 (UTC) (edited on 2023-12-29 02:16 (UTC) by LekKit)

Removed gcc and make from makedepends (they are in base-devel and always implicit make dependencies.

This didn't always work for me sadly when installing AUR packages on new systems - perhaps a bug in an AUR helper I'm using, so I'd prefer to explicitly include this makedepend (unless there is a better way around this?).

I've kept all the items in arch for now, though I honestly doubt the software will run on all these architectures (have you tested them all?).

ARM64 and RISC-V builds work just fine (albeit my test devices are slow, but for rendering a project with DI guitars worked perfectly well). No testing on 32-bit arches was done yet, remove if you wish - not that I like 32bits too much, just wanted portability on actual modern arches

@SpotlightKid, added you as a co-maintainer, completely agree with your other points

SpotlightKid commented on 2023-12-27 19:45 (UTC)

Hi, @LekKit, you beat me to the punch by just a few days in packaging neural-amp-modeler-lv2! :)

May I suggest a few improvements to the package:

https://cpaste.org/?cd9646394800f1b4#Bg7Ct2HXPs2DTTe2d1otZxTxvz3TuQhyPJggCS7UfnJC

  • Add depends=(gcc-libs glibc).
  • Removed gcc and make from makedepends (they are in base-devel and always implicit make dependencies.
  • Add git submodules to sources.
  • Change pkgver to get version from git describe.
  • Use out-of-tree build.
  • Install readme to docdir.
  • Use install instead of cp -r for installation (makes sure permissions are always correct).
  • Updated PKGBUILD syntax style to common practices in official repos.
  • I've kept all the items in arch for now, though I honestly doubt the software will run on all these architectures (have you tested them all?).

If you want, you can add me as a co-maintainer and I'll update the package.