Package Details: nitrokey-app 1.3-3

Git Clone URL: https://aur.archlinux.org/nitrokey-app.git (read-only)
Package Base: nitrokey-app
Description: Nitrokey management application
Upstream URL: https://www.nitrokey.com
Keywords: crypto smartcard
Licenses: GPL3
Submitter: cjsthompson
Maintainer: milouse
Last Packager: milouse
Votes: 14
Popularity: 0.881116
First Submitted: 2015-02-12 07:56
Last Updated: 2018-04-24 08:18

Latest Comments

Arvedui commented on 2018-04-24 16:06

Looks good to me too.

techge commented on 2018-04-24 09:22

Looks good to me!

milouse commented on 2018-04-24 08:20

Thank you very much Arvedui and techge for your help. Can you all confirm that it's ok now?

coderkun commented on 2018-04-23 21:08

Thanks for investigating, Arvedui. As workaround I built the package without chroot but would prefer to use a chroot properly, of course.

Arvedui commented on 2018-04-23 20:06

I believe I found the issue with building in a clean chroot.

The logpipe is deleted by an exit handler of makechrootpkg, which runs twice. First when the subshell that grep is running in terminates abnormal, because the grep fails and bash is setup to exit on any error. Second when the prepare function returns.

That the grep fails indicates that the entire for loop is obsolete, and indeed it builds without error (even in clean chroot) after removing the for loop in the prepare function.

techge commented on 2018-04-23 18:06

Thank you for fixing! I have tried the proposed change on #346. This indeed fix the icon problem. As far as I can see this will not fixed in 1.3 but in 1.4.

As next release will be in some month, you could add the following line in the meantime: 'sed -i '/qt5_add_resources/d' ./CMakeLists.txt' to the prepare() section (I did in line 29)?

milouse commented on 2018-04-23 08:32

The necessary files for qt-concurrent are in the qt5-base package, thus it's ok for that. I've added the qt5-svg dependency (I already have it as it's required by vlc, sorry to not have read seriously the release notes).

For the other problem (@coderkun I don't forget you, I promise), it'll take some times again, I'll to do my best to investigate them quickly.

techge commented on 2018-04-19 10:18

Could you please add qt5-svg as dependency? There was 'Qt Concurrent' added as well, but I have no idea what packages in Arch correspond to this one... (please see https://github.com/Nitrokey/nitrokey-app/releases/tag/v1.3)

Furthermore, it looks like we are affected of https://github.com/Nitrokey/nitrokey-app/pull/346 as well, aren't we? At least I get a bunch of warnings on terminal when starting nitrokey-app.

coderkun commented on 2018-04-17 11:27

@milouse, I use the Building in a Clean Chroot method and build the package with

$ makechrootpkg -c -r $CHROOT

milouse commented on 2018-04-17 11:03

coderkun: weird… there no such file in the source code. It may come from the way you made the clean chroot. Which tool do you use ?

All comments