Arch Linux User Repository

My last fix didn't work, but I tried to find another way to fix it and I think that I found how to do it, I still have to test this patch but it may work:

diff --git a/PKGBUILD b/PKGBUILD
index ef61f64..f917e4d 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -9,7 +9,9 @@ pkgdesc="A space-sim based on the classic Elite"
 arch=('x86_64')
 url="http://oolite.space/"
 license=('GPL2')
-depends=('espeak' 'gnustep-base' 'sdl_mixer' 'sdl_image' 'glu' 'nspr' 'openal')
+depends=('espeak' 'gnustep-base' 'sdl_mixer' 'sdl_image' 'glu' 'nspr' 'openal'
+         'libpng' 'gcc-libs' 'libglvnd' 'glibc' 'zlib' 'sdl12-compat' 'bash'
+         'libvorbis')
 makedepends=('gnustep-make' 'curl' 'zip' 'mesa' 'gcc-objc')
 source=("oolite" "https://github.com/OoliteProject/oolite/releases/download/$pkgver/oolite-source-$pkgver.tar.bz2")
 md5sums=('ade14e17fe9d52d16b35f2e97046362c'
@@ -22,6 +24,9 @@ prepare() {
   # http://aegidian.org/bb/viewtopic.php?f=9&t=20754
   rm deps/Linux-deps/include/png.h
   rm deps/Linux-deps/include/pngconf.h
+
+  # Workaround for -Werror=format-security default flag from GNUstep
+  sed -Ei 's|(include \$\(GNUSTEP_MAKEFILES\)/common\.make)|\1\nCCFLAGS += -Wno-error=format-security\nOPTFLAG += -Wno-error=format-security|' GNUmakefile
 }

 build() {

Edit: Yep, it worked :D I added some dependencies to the package because namcap was complaining that they were implicit instead of being explicit.

I had that same error with wyrmsun package some time ago, I think this should solve it (I've not tested it yet):

diff --git a/PKGBUILD b/PKGBUILD
index ef61f64..fa9cde6 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -25,6 +25,7 @@ prepare() {
 }

 build() {
+  CFLAGS+=' -Werror=format-security'
   cd "oolite-source-$pkgver"
   source /usr/share/GNUstep/Makefiles/GNUstep.sh
   make -f Makefile release

I'll update my archlinux first and then fix this package. I don't know why it builds here, but I haven't updated my system in a while and haven't tried to build in clean chroot.

I'm getting the same errors on standard Arch as @ipochto. No changes to my CFLAGS, but I am building in a clean chroot (using aurutils/devtools) and I am using distcc.

EDIT: Same issue if I disable distcc.

I don't see how this could work for anyone with -Werror=format-security set (which is set by default).

Same here https://github.com/archlinux/svntogit-packages/blob/packages/pacman/trunk/makepkg.conf

@SanskritFritz

Did you set any compiler flags in /etc/makepkg.conf ?

Nope, it's default. And it has -Werror=format-security inside:

CFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions \
        -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security \
        -fstack-clash-protection -fcf-protection"

Oh, wait a minute - I'm on Manjaro, maybe they added it.

@SanskritFritz I'm having the same problem here, but the solution of ipochto worked for me. @ipochto Thanks!!

Did you set any compiler flags in /etc/makepkg.conf ?

Hmm it compiles here just fine.

Hi there. Get this while compiling.

src/SDL/MyOpenGLView.m: In function ‘-[MyOpenGLView init]’:
src/SDL/MyOpenGLView.m:327:9: error: format not a string literal and no format arguments [-Werror=format-security]
  327 |         OOLog(@"display.initGL", @"Achieved color / depth buffer sizes (bits):");
      |         ^
 Compiling file src/Core/OOCocoa.m ...
cc1obj: some warnings being treated as errors
make[4]: *** [/usr/share/GNUstep/Makefiles/rules.make:521: obj.spk/oolite.obj/MyOpenGLView.m.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [/usr/share/GNUstep/Makefiles/Instance/objc.make:64: internal-objc_program-all_] Error 2
make[2]: *** [/usr/share/GNUstep/Makefiles/Master/rules.make:297: oolite.all.objc-program.variables] Error 2
make[1]: *** [/usr/share/GNUstep/Makefiles/Master/objc.make:36: internal-all] Error 2
make[1]: Leaving directory '/home/alyokhin/.cache/yay/oolite/src/oolite-source-1.90'
make: *** [Makefile:78: release] Error 2
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: oolite

fixed by added OBJCFLAGS="-fobjc-exceptions -Wno-format-security" -j$(nproc) at the end of

make -f Makefile release

in the PKGBUILD