Package Details: open-adventure 1.16-3

Git Clone URL: https://aur.archlinux.org/open-adventure.git (read-only, click to copy)
Package Base: open-adventure
Description: Port of the 'Colossal Cave Adventure' text-based adventure game
Upstream URL: http://www.catb.org/~esr/open-adventure/
Keywords: games
Licenses: BSD
Conflicts: advent
Submitter: duthils
Maintainer: duthils
Last Packager: duthils
Votes: 9
Popularity: 0.000388
First Submitted: 2017-07-30 22:12 (UTC)
Last Updated: 2024-11-25 04:24 (UTC)

Latest Comments

duthils commented on 2024-11-25 04:25 (UTC)

Suggestions added, thanks a lot :)

penguintamer commented on 2024-11-13 05:47 (UTC)

My MAKEFLAGS are set to parallel make by default, but one of the tests depends on a previous one. Anyone else with a similar setup will probably be confused by the error. Please update the make check line to force serial execution of the tests to prevent the error:

-  LC_ALL=C make -k check
+  LC_ALL=C make -k -j1 check

failed test:

cd tests; make --quiet
.....................................................................................F...........................
not ok - saveresume.4.chk: saveresume.4: Resume, then win\n  --- |\n  --- saveresume.4.chk  2023-04-15 10:44:20.000000000 -0800\n  +++ -    2024-11-12 20:52:12.633920458 -0800\n  @@ -9,20 +9,15 @@\n   \n   > resume\n   Can't open file y, try again.\n  +Can't open file saveresume_win.adv, try again.\n  +Can't open file blast, try again.\n   \n  -You're at sw end.\n  +File name: \n  +You're in front of building.\n   \n  -The grate is locked.\n  +> \n  +You scored 32 out of a possible 430, using 1 turn.\n   \n  -> blast\n  +You are obviously a rank amateur.  Better luck next time.\n   \n  -There is a loud explosion, and a twenty-foot hole appears in the far\n  -wall, burying the dwarves in the rubble.  You march through the hole\n  -and find yourself in the main office, where a cheering band of\n  -friendly elves carry the conquering adventurer off into the sunset.\n  -\n  -You scored 423 out of a possible 430, using 468 turns.\n  -\n  -Your score puts you in Master Adventurer Class A.\n  -\n  -To achieve the next higher rating, you need 4 more points.\n  +To achieve the next higher rating, you need 14 more points.\n  ...\n113 tests, 1 failures.
make[1]: *** [Makefile:34: check] Error 1
make: *** [Makefile:69: check] Error 2

Thanks!

penguintamer commented on 2024-11-13 05:43 (UTC) (edited on 2024-11-13 05:48 (UTC) by penguintamer)

While building in chroot, I found that libedit was not declared as a dependency:

Package libedit was not found in the pkg-config search path.
Perhaps you should add the directory containing `libedit.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libedit', required by 'virtual:world', not found
cc -std=c99 -D_DEFAULT_SOURCE -DVERSION=\"1.16\" -O2 -D_FORTIFY_SOURCE=2 -fstack-protector-all -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection         -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -ffile-prefix-map=/build/open-adventure/src=/usr/src/debug/open-adventure -flto=auto -g    -c score.c
main.c:15:10: fatal error: editline/readline.h: No such file or directory
   15 | #include <editline/readline.h>
      |          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Adding depends=('libedit') to PKGBUILD fixes this. Please update the AUR.

duthils commented on 2023-11-23 00:11 (UTC)

Thanks for the report, I could reproduce. I made the changes you suggested.

cyberpunkrocker commented on 2023-11-22 05:09 (UTC) (edited on 2023-11-22 05:11 (UTC) by cyberpunkrocker)

All the messages are now, of course, in Finnish: 

makepkg -fsc
==> Käännetään pakettia: open-adventure 1.16-1 (ke 22. marraskuuta 2023 07.00.51)
==> Tarkastetaan yleisriippuvuuksia...
==> Tarkastetaan käännönaikaisia riippuvuuksia...
==> Noudetaan lähdetiedostoja...
  -> Kohde open-adventure-1.16.tar.bz2 löytyi
==> Tarkastetaan paketin source tiedostojen virheettömyyttä ohjelmalla sha256sums...
    open-adventure-1.16.tar.bz2 ... Virheetön
==> Puretaan lähdetiedostoja...
  -> Puretaan open-adventure-1.16.tar.bz2 komennolla bsdtar
==> Aloitetaan osion build() käsittelemistä...
./make_dungeon.py
./make_dungeon.py
a2x --doctype manpage --format manpage advent.adoc
cc -std=c99 -D_DEFAULT_SOURCE -DVERSION=\"1.16\" -O2 -D_FORTIFY_SOURCE=2 -fstack-protector-all -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -g  -I/usr/include/editline   -c main.c
cc -std=c99 -D_DEFAULT_SOURCE -DVERSION=\"1.16\" -O2 -D_FORTIFY_SOURCE=2 -fstack-protector-all -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -g  -I/usr/include/editline   -c init.c
cc -std=c99 -D_DEFAULT_SOURCE -DVERSION=\"1.16\" -O2 -D_FORTIFY_SOURCE=2 -fstack-protector-all -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -g  -I/usr/include/editline   -c actions.c
cc -std=c99 -D_DEFAULT_SOURCE -DVERSION=\"1.16\" -O2 -D_FORTIFY_SOURCE=2 -fstack-protector-all -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -g  -I/usr/include/editline   -c score.c
cc -std=c99 -D_DEFAULT_SOURCE -DVERSION=\"1.16\" -O2 -D_FORTIFY_SOURCE=2 -fstack-protector-all -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -g  -I/usr/include/editline   -c misc.c
cc -std=c99 -D_DEFAULT_SOURCE -DVERSION=\"1.16\" -O2 -D_FORTIFY_SOURCE=2 -fstack-protector-all -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -g  -I/usr/include/editline   -c saveresume.c
cc -std=c99 -D_DEFAULT_SOURCE -DVERSION=\"1.16\" -O2 -D_FORTIFY_SOURCE=2 -fstack-protector-all -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -g   -c dungeon.c
cc -std=c99 -D_DEFAULT_SOURCE -DVERSION=\"1.16\" -O2 -D_FORTIFY_SOURCE=2 -fstack-protector-all -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -g   -o advent main.o init.o actions.o score.o misc.o saveresume.o dungeon.o -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -ledit 
==> Aloitetaan osion check() käsittelemistä...
cc -std=c99 -D_DEFAULT_SOURCE -DVERSION=\"1.16\" -O2 -D_FORTIFY_SOURCE=2 -fstack-protector-all -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -g  -I/usr/include/editline   -c cheat.c
cc -std=c99 -D_DEFAULT_SOURCE -DVERSION=\"1.16\" -O2 -D_FORTIFY_SOURCE=2 -fstack-protector-all -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -g   -o cheat cheat.o init.o actions.o score.o misc.o saveresume.o dungeon.o -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -ledit 
cd tests; make --quiet
.......................................................................................F.........................
not ok - saveresume.4.chk: saveresume.4: Resume, then win\n  --- |\n  --- saveresume.4.chk  2023-04-15 21:44:20.000000000 +0300\n  +++ -    2023-11-22 07:00:52.223051424 +0200\n  @@ -9,20 +9,15 @@\n   \n   > resume\n   Can't open file y, try again.\n  +Can't open file saveresume_win.adv, try again.\n  +Can't open file blast, try again.\n   \n  -You're at sw end.\n  +File name: \n  +You're in front of building.\n   \n  -The grate is locked.\n  +> \n  +You scored 32 out of a possible 430, using 1 turn.\n   \n  -> blast\n  +You are obviously a rank amateur.  Better luck next time.\n   \n  -There is a loud explosion, and a twenty-foot hole appears in the far\n  -wall, burying the dwarves in the rubble.  You march through the hole\n  -and find yourself in the main office, where a cheering band of\n  -friendly elves carry the conquering adventurer off into the sunset.\n  -\n  -You scored 423 out of a possible 430, using 468 turns.\n  -\n  -Your score puts you in Master Adventurer Class A.\n  -\n  -To achieve the next higher rating, you need 4 more points.\n  +To achieve the next higher rating, you need 14 more points.\n  ...\n113 tests, 1 failures.
make[1]: *** [Makefile:34: check] Error 1
make: *** [Makefile:69: check] Error 2
==> VIRHE: Virhe tapahtui funktiossa check().
    Peruutetaan...

duthils commented on 2023-11-22 04:29 (UTC)

Thanks for reporting, I can't reproduce with either fi_FI.UTF-8 or fr_FR.UTF-8:

LC_ALL=fi_FI.UTF-8 makepkg -f

Could you share the error you get when compiling, please?

cyberpunkrocker commented on 2023-11-21 18:03 (UTC)

Building open-adventure on my device is possible only if I prefix makepkg with

LC_ALL=C makepkg

The build tests fail if I use my default locale fi_FI.UTF8. I suppose the build would fail similar way with all non-english locales? Could you please modify the PKGBUILD so it temporarily resets the locale to C/english for the build time?

torpe23 commented on 2021-05-29 22:53 (UTC)

Thanks, appreciate it! Works like a charm now :)

duthils commented on 2021-05-26 01:18 (UTC)

Thank you for the report!

I fixed the URL and updated to 1.9.

torpe23 commented on 2021-05-23 16:10 (UTC)

The package won't build unfortunately.

curl: (22) The requested URL returned error: 503 ==> ERROR: Failure while downloading https://gitlab.com/esr/open-adventure/repository/archive.tar.bz2?ref=1.8

It seems like the tarball isn't where it used to be.

Any chance you can fix it? Thanks!