@mradermaxliol i pin it on a git tag now ...
(i start it as git, because it was not possible to use an tag because of ovemediaengine has not supported curren/newer versions of they dependencies)
Git Clone URL: | https://aur.archlinux.org/ovenmediaengine.git (read-only, click to copy) |
---|---|
Package Base: | ovenmediaengine |
Description: | Open-source streaming video service with sub-second latency |
Upstream URL: | https://ovenmediaengine.com |
Licenses: | GPL2 |
Submitter: | genofire |
Maintainer: | genofire |
Last Packager: | genofire |
Votes: | 1 |
Popularity: | 0.000347 |
First Submitted: | 2021-05-24 19:31 (UTC) |
Last Updated: | 2021-11-17 22:17 (UTC) |
@mradermaxliol i pin it on a git tag now ...
(i start it as git, because it was not possible to use an tag because of ovemediaengine has not supported curren/newer versions of they dependencies)
shouldn't this package have the -git suffix?
My patch from below is integrated into upstream now. We're all good on 4.4 now with no patch :)
I patched the 4.4 issue; add this patch with patch -p1 the.patch
. It's been sent upstream as a PR.
From ef806cfc0158eed2d7b56d53abf051cf0f242030 Mon Sep 17 00:00:00 2001
From: Jade <software@lfcode.ca>
Date: Fri, 25 Jun 2021 15:31:23 -0700
Subject: [PATCH] Stop setting the `display_aspect_ratio` on AVStreams
This was causing a compilation failure on ffmpeg 4.4 on Arch Linux.
This field was moved out of AVStream into a private structure in this commit:
http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=c1b916580ae92abca583d9afa2f9f64165292dd8
Based on the message there, it was not intended to be exposed to begin
with, so we can just stop setting it.
---
src/projects/modules/file/file_writer.cpp | 1 -
src/projects/modules/rtmp/rtmp_writer.cpp | 1 -
2 files changed, 2 deletions(-)
diff --git a/src/projects/modules/file/file_writer.cpp b/src/projects/modules/file/file_writer.cpp
index df6a7559..6d0b9764 100755
--- a/src/projects/modules/file/file_writer.cpp
+++ b/src/projects/modules/file/file_writer.cpp
@@ -210,7 +210,6 @@ bool FileWriter::AddTrack(cmn::MediaType media_type, int32_t track_id, std::shar
memcpy(codecpar->extradata, track_info->GetExtradata()->GetDataAs<uint8_t>(), codecpar->extradata_size);
}
- stream->display_aspect_ratio = AVRational{1, 1};
stream->time_base = AVRational{track_info->GetTimeBase().GetNum(), track_info->GetTimeBase().GetDen()};
_track_map[track_id] = stream->index;
diff --git a/src/projects/modules/rtmp/rtmp_writer.cpp b/src/projects/modules/rtmp/rtmp_writer.cpp
index 296ef524..ca4045e7 100755
--- a/src/projects/modules/rtmp/rtmp_writer.cpp
+++ b/src/projects/modules/rtmp/rtmp_writer.cpp
@@ -222,7 +222,6 @@ bool RtmpWriter::AddTrack(cmn::MediaType media_type, int32_t track_id, std::shar
logte("there is no avc configuration %d", track_info->GetExtradata()->GetLength());
}
- stream->display_aspect_ratio = AVRational{1, 1};
stream->time_base = AVRational{track_info->GetTimeBase().GetNum(), track_info->GetTimeBase().GetDen()};
_track_map[track_id] = stream->index;
--
2.32.0
You need to Downgrade for compiling to ffmpeg v4.3.
projects/modules/file/file_writer.cpp: In member function ‘bool FileWriter::AddTrack(cmn::MediaType, int32_t, std::shared_ptr<FileTrackInfo>)’:
projects/modules/file/file_writer.cpp:213:33: error: ‘AVStream’ {aka ‘struct AVStream’} has no member named ‘display_aspect_ratio’; did you mean ‘sample_aspect_ratio’?
213 | stream->display_aspect_ratio = AVRational{1, 1};
| ^~~~~~~~~~~~~~~~~~~~
| sample_aspect_ratio
compilation terminated due to -Wfatal-errors.
projects/modules/rtmp/rtmp_writer.cpp: In member function ‘bool RtmpWriter::AddTrack(cmn::MediaType, int32_t, std::shared_ptr<RtmpTrackInfo>)’:
projects/modules/rtmp/rtmp_writer.cpp:225:33: error: ‘AVStream’ {aka ‘struct AVStream’} has no member named ‘display_aspect_ratio’; did you mean ‘sample_aspect_ratio’?
225 | stream->display_aspect_ratio = AVRational{1, 1};
| ^~~~~~~~~~~~~~~~~~~~
| sample_aspect_ratio
Pinned Comments
jade1 commented on 2021-06-28 02:50 (UTC)
My patch from below is integrated into upstream now. We're all good on 4.4 now with no patch :)