Arch Linux User Repository

Hello, this package could do with the following changes:

1. Add conflicts and provides since this is a -git package
2. Add all depends() listed by namcap
3. Add imagemagick to makedepends() for simplified install step
4. Add missing submodules
5. Simplify the whole git submodule process. I see that you don't want to clone any submodule not required, which can be done by just: 1. configuring the submodules you want; 2. running git submodule update without the --init.
6. pcsx-redux now has an install function in the makefile, so thats what we use
7. Use SDPX compliant license()

Here is the link to the Github gist which contains the patch file.

If you do not want to manually go through this patch file, I do not mind being listed as co-maintainer myself. Thank you for your hardwork!

Any suggestions other than building in a container?

Build in a clean chroot with devtools See https://wiki.archlinux.org/title/DeveloperWiki:Building_in_a_clean_chroot extra-x86_64-build

Seems to use system fmt on my system, resulting in build failure:

/usr/include/fmt/base.h:2248:29: error: passing ‘const fmt::v11::formatter<PCSX::IEC60908b::MSF>’ as ‘this’ argument discards qualifiers [-fpermissive]
 2248 |     ctx.advance_to(cf.format(*static_cast<qualified_type*>(arg), ctx));

Any suggestions other than building in a container?

Very aggressive compilation settings. My session crashes.

@jpyper I went through my notes and figured out that it was the -fstack-protector-strong flag that broke compilation for luajit. Do you know of a good/easy way to negate just that flag but keep all the others? Note that some are set by makepkg.conf and some are set by the Makefile.

@algebro The "AARCH64" in the arch= line should be lowercase "aarch64". :-]

Again, thank you for your work.

Thanks for the testing and suggestions! I didn't notice the capstone warnings because I already had it installed.

I've added AARCH64 and capstone to the dependencies. For the buildflags, I had to add !buildflags because one of the default Arch buildflags causes an error when building/linking luajit--I'd tracked it down at one point in the past but I forget which one it was now. I'll try looking into it again--let me know if you're able to figure it out first and I'll add a patch.

@algebro Thank you for the fast fix. It now builds and runs on x86-64. I have a few things to point out though.

In PKGBUILD, please add "capstone" to the "depends" line. Without it, there's a bunch of spam saying capstone is missing when it compiles each file.

[edit] I see you have "git+https://github.com/capstone-engine/capstone.git" in the sources list, but it doesn't seem to be doing anything.

Also in PKGBUILD, please add 'aarch64' to the "arch" line. I just built this package on a Raspberry Pi 4B 8GB with no errors. Program runs as expected. Took a while to compile at 1500 MHz even with all 4 cores going at it.

I noticed that while compiling on both x86-64 and aarch64 that my settings for CFLAGS/CXXFLAGS are ignored. Maybe a little patch against the Makefile could change that. I don't know how that works.

Lastly, I think this is an upstream issue, but there are a ton of warning and note messages during compile. They are not breaking anything though.

Again, thank you.

@jpyper try again, the fix was merged upstream

Thanks for the report, this is actually an upstream bug. I'm planning to submit a PR to fix it soon.