Package Details: peertube-viewer-rs 1.8.5-3

Git Clone URL: https://aur.archlinux.org/peertube-viewer-rs.git (read-only, click to copy)
Package Base: peertube-viewer-rs
Description: Peertube command line viewer inspired by youtube-viewer
Upstream URL: https://peertube-viewer.com
Licenses: AGPL-3.0-or-later
Submitter: Sosthene
Maintainer: Sosthene
Last Packager: Sosthene
Votes: 5
Popularity: 0.000010
First Submitted: 2020-05-08 15:49 (UTC)
Last Updated: 2024-04-02 17:54 (UTC)

Latest Comments

Sosthene commented on 2024-04-02 17:56 (UTC)

I fixed the issues you mentioned. Thanks for reporting them.

I did not know where the bash completions stuff was documented. Please when you point out such issues add a link to the relevant documentation. It makes it easier to fix the issues without wasting time.

Regarding arm support: I only package for what I can test. This project is also not very active so I don't want to spend time setting up CI for cross compilation. Sorry.

You should be able to compile peertube-viewer-rs on a raspberry-pi without trouble. The dependency tree is not that deep, it should not take hours.

m040601 commented on 2024-04-02 17:09 (UTC)

Thanks for the work creating this tool and maintaining this PKGBUILD. Very usefull the precompiled "-bin"

arch=('x86_64')

Maybe in the future you could also build for Arm ? aarch64 and armv7h ? Would be very nice to use on the small raspberry pi's etc. If you use Gitlab and automations/CI to build, it is also free.

Thanks in advance.

Here are some errors and corrections that this PKGBUILD needs right now.

pacman -Ql peertube-viewer-rs-bin

peertube-viewer-rs-bin /etc/
peertube-viewer-rs-bin /etc/bash_completion.d/
peertube-viewer-rs-bin /etc/bash_completion.d/peertube-viewer-rs.bash
peertube-viewer-rs-bin /usr/
peertube-viewer-rs-bin /usr/bin/
peertube-viewer-rs-bin /usr/bin/peertube-viewer-rs
peertube-viewer-rs-bin /usr/share/
peertube-viewer-rs-bin /usr/share/licenses/
peertube-viewer-rs-bin /usr/share/licenses/peertube-viewer-rs-bin/
peertube-viewer-rs-bin /usr/share/licenses/peertube-viewer-rs-bin/LICENSE-MIT
peertube-viewer-rs-bin /usr/share/man/
peertube-viewer-rs-bin /usr/share/man/man1/
peertube-viewer-rs-bin /usr/share/man/man1/peertube-viewer-rs.1.gz

ls -l /etc/bash_completion.d/peertube-viewer-rs.bash

-rwxr-xr-x 1 root root 2767 Apr  2 17:40 /etc/bash_completion.d/peertube-viewer-rs.bash

from the PKGBUILD:

22     install -Dm755 completions/peertube-viewer-rs.bash $pkgdir/etc/bash_completion.d/peertube-viewer-rs.bash

This is wrong. Wrong place and wrong file permissions.

First, the right place.

You should not be installing the bash completion to /etc/bash_completion.d.

That is not following the Archlinux standards.

As a result of doing this, be default, the user will not have the bash completion automatically enabled. Unless of course he specifically sources that file from his bashrc just for this peerviewer case.

The correct way is to use "/usr/share/bash-completion/completions/"

So you would do something like this:

  install -Dm644 "xyz..." "${pkgdir}/usr/share/bash-completion/completions/peertube-viewer-rs"

As a result, and because of the Archlinux bash defaults, the user will automatically have completion for peertube enabled.

Second, the right permissions.

You are using 755 and making the file executable. This is wrong. The correct permissions for this kind of file is 644.