Package Details: perfect-dark-git r7154.479c0335f-1

Git Clone URL: https://aur.archlinux.org/perfect-dark-git.git (read-only, click to copy)
Package Base: perfect-dark-git
Description: PC port of Perfect Dark
Upstream URL: https://github.com/fgsfdsfgs/perfect_dark
Keywords: dark n64 perfect port
Licenses: MIT
Submitter: aquova
Maintainer: aquova
Last Packager: aquova
Votes: 2
Popularity: 0.001166
First Submitted: 2023-11-03 20:01 (UTC)
Last Updated: 2023-11-03 20:01 (UTC)

Latest Comments

ejona86 commented on 2024-02-25 19:28 (UTC)

Missing makedepends=('git' 'python').

aquova commented on 2024-01-16 01:25 (UTC)

This is an excellent point, and I'm curious for feedback on what would work best. I tried finding examples of other projects which require an external file like this to function, but didn't find much.

I think there are pros and cons to both approaches though. For what we have now, if a user doesn't know they need this file, the installation process will fail and they'll have to find the ROM and place it somewhere the PKGBUILD can see it, either alongside it, or for AUR helpers, in their cache. Right now it fails for checksum reasons as that's one of the first build steps, but it would be nice if there's some way to print out an actual explanation of what's happening.

I didn't realize this project supported a --basedir flag, and that might be the better option. It would get past the installation process at least. I do worry that a user would think the installation process was 100% complete, then be confused when it doesn't run, although if the upstream program gives a good error message, that might be fine. All things considered, I think this new suggested solution is better, but I wanted to open the floor for feedback before I implemented it.

ThatOneSeong commented on 2024-01-16 00:52 (UTC)

Hi! It's very nice to see this here, but I think asking to have the rom file at build time is a little redundant (and would mess with AUR helpers)? The build itself does not require any external ROM file, and the port can use a launch flag --basedir to read from any other directory.

Perhaps removing the rom file dependency, putting the binary in /usr/bin directly instead of the script in use now, and adding a desktop file with the aforementioned flag pointing to ~/.local/share/perfectdark would work better? Might want to add a post-install notification notifying the user what the rom path & name is expected.

If you need an icon for a desktop file, you can grab a clean image from 1964GEPD's source here