Package Details: pi-hole-server 4.3.2-6

Git Clone URL: https://aur.archlinux.org/pi-hole-server.git (read-only)
Package Base: pi-hole-server
Description: The Pi-hole is an advertising-aware DNS/Web server. Arch adaptation for lan wide DNS server.
Upstream URL: https://github.com/pi-hole/pi-hole
Keywords: ad block pi-hole
Licenses: EUPL-1.1
Conflicts: pi-hole-standalone
Submitter: max.bra
Maintainer: max.bra (graysky)
Last Packager: max.bra
Votes: 59
Popularity: 1.418140
First Submitted: 2016-01-13 12:50
Last Updated: 2019-10-05 17:59

Pinned Comments

max.bra commented on 2018-02-09 16:45

ArchLinux Pi-hole is not officially supported by Pi-hole project. In case of bugs and malfunctions please DO NOT file a report upstream. First of all check if the wiki (https://wiki.archlinux.org/index.php/Pi-hole) can help then ask here for assistance and tips. When it will be excluded that the problem does not depend on ArchLinux we will file a bug upstream.

Latest Comments

1 2 3 4 5 6 ... Next › Last »

graysky commented on 2019-09-25 20:46

I think the issue is that @max.bra has created the same name of the patches but has modified them since doing so. Therefore, if a user built an older version expecting the patch, the checksums would be different. One solution is to append a date to the patch itself in the source array as suggested below, another is to use use a tag in the github repo.

tag=v6.35
git tag $tag -m "$tag" && git push --tags

jshap commented on 2019-09-25 20:12

it's not a yay issue, it happens with just makepkg as well if you don't delete the packages first. it's just a normal issue with how makepkg chooses to download things based on if it thinks it's changed or not.

for a more esoteric use case, look at how firefox-nightly's pkgbuild works. for them the url does not change, and yet every day the tarball will. so in the source array they move the file to a different location based on $(date ...). obviously not asking you to do that, just saying that it is not completely unheard of to have to rename things which are downloaded.

but again, I'm not saying to attach the date, I'm saying just use the pkgrel.

tholinka commented on 2019-09-25 05:19

Deleting the patches (or just clean building) does fix the checksum issue.

However, an even better solution (imo), since you already have to update this package with the new checksums, is to just copy the patches into this package instead of having them source from github. This comes with the added benefit that it's easy to see a diff between the versions.

max.bra commented on 2019-09-24 19:58

and more:

[Aur: 1]  pi-hole-server-4.3.2-5

  1 pi-hole-server                   (Build Files Exist)
==> Packages to cleanBuild?
==> [N]one [A]ll [Ab]ort [I]nstalled [No]tInstalled or (1 2 3, 1-3, ^4)
==>

this appear a clear question to me. or not? it's just a matter of not pressing <enter> blindly...

max.bra commented on 2019-09-24 19:53

@all sorry but, i need to change the PKGBUILD because of yay build caching? am i understanding well? this is not normal and the use of an aur helper is not mandatory.

cat .config/yay/config.json 
{
"buildDir": "/tmp",
"editor": "",
    ...

jshap commented on 2019-09-24 19:02

the issue isn't that the checksums are wrong it's that arch-server-admin-4.3.2.patch and arch-server-core-4.3.2.patch change with each pkgrel bump but their url doesn't, so although the server is different than your downloaded version because they share the same name they don't get updated, and then fail the checks.

solutions would be to update https://github.com/max72bra/pi-hole-server-archlinux-customization/ to name the patches like arch-server-core-4.3.2-5.patch, or to update the PKGBUILD to download them and save them by pkgrel, so the sources would look like:

source=(...
        admin-$_wwwpkgver-$pkgrel.tar.gz::https://github.com/$_pkgname/$_wwwpkgname/archive/v$_wwwpkgver.tar.gz
        arch-server-core-$pkgver-$pkgrel.patch::"https://raw.githubusercontent.com/max72bra/pi-hole-server-archlinux-customization/master/arch-server-core-$pkgver.patch"
        arch-server-admin-$_wwwpkgver-$pkgrel.patch::"https://raw.githubusercontent.com/max72bra/pi-hole-server-archlinux-customization/master/arch-server-admin-$_wwwpkgver.patch"
        )

...

prepare() {
  cd "$srcdir"/"$_pkgname"-"$pkgver"
  patch -Np1 -i "$srcdir"/arch-server-core-$pkgver-$pkgrel.patch
  cd "$srcdir"/"$_wwwpkgname"-"$_wwwpkgver"
  patch -Np1 -i "$srcdir"/arch-server-admin-$_wwwpkgver-$pkgrel.patch
}

johnnybash commented on 2019-09-24 18:18

or just configure your AUR helper to either cleanbuild (as stated several times) or your build directory into a temp dir, yay e.g. supports both... -.-

oldrava commented on 2019-09-24 18:16

Current easy workaround(for yay) yay -G pi-hole-server , cd pi-hole-server , makepkg -g >> PKGBUILD , makepkg , sudo pacman -U pi-hole-server-4.3.2-5-any.pkg.tar.xz

pi-hole-server-4.3.2-5-any.pkg.tar.xz is current version change it accordingly to it version and file it created

oldrava commented on 2019-09-24 18:09

Dear max.bra

I appreciate your work but if I get ==> ERROR: One or more files did not pass the validity check! there is no use of your repo if I had to download and compile it myself, Kind regards

max.bra commented on 2019-09-24 15:31

Hi gecko, dns servers list and adblocks list are taken manually from upstream basic-install.sh. It happens that something can be lost especially for the informations extrapolated from basic-insall.sh precisely. In fact, the AUR community never fails to notice what others do. And this is very good.

Given that pi-hole on archlinux is not supported by the original developers and the use of AUR packages is at the user's own risk, the update details are all opensource. You can find all the installation files here in the git repository of this package (FTL details on the respective page) and the patch generator on the respective github repos (https://github.com/max72bra?tab=repositories).

Updating adblock list... done!! Thanks for reporting, as usual. ;-)