Arch Linux User Repository

As the previous comment stated, this package is not installing the binary.

Maybe it needs to be added back into package() like this:

  install -Dm755 "$srcdir/pistol-git/pistol" "$pkgdir/usr/bin/pistol"

I presume it is not intentional that since the last change on 2022-07-10 this package is not installing the pistol executable any more.

fixed

No longer builds. This one works for me:

# Maintainer: Bart De Roy <de dot roy dot bart at gmail dot com>
pkgname=pistol-git
pkgver=0.3.2.r7.g4b834a9
pkgrel=1
pkgdesc='General purpose file previewer'
arch=('x86_64')
_gourl="github.com/doronbehar/pistol"
url="https://$_gourl"
license=('MIT')
makedepends=('go' 'git' 'asciidoctor')
depends=('file')
optdepends=('ranger: file browser to preview files in' 'lf: file browser to preview files in')
source=("$pkgname::git+$url#branch=master")
sha256sums=('SKIP')

pkgver() {
  cd "$srcdir/$pkgname"
  # cuts off 'v' prefix and uses most recent
  # un-annotated tag reachable from the last commit
  git describe --long --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'
}

build() {
  cd "$srcdir/$pkgname"
  # -fix flag is a no-op when using modules
  GOPATH="$srcdir" go get -v "$_gourl/cmd/pistol"
  make
  asciidoctor -b manpage -d manpage README.adoc
}

package() {
  cd "$srcdir/$pkgname"
  make DESTDIR="$pkgdir" install
}

I installed it today with paru and the package installed fine.

see https://bbs.archlinux.org/viewtopic.php?id=246720

I'll take a look, it may take a while... go clean -modcache appears to be the way they clean read-only module directories. In build() it should probably also be env CGO_ENABLED=1 GO111MODULE=on GOPATH="$srcdir" go get -v "$_gourl/cmd/pistol".

Build fails due to the attempt to strip src/bin/pistol

...
strip: '/home/user/.cache/yay/pistol-git/src/bin/pistol': No such file
==> ERROR: A failure occurred in build().
    Aborting...

There seems to me a permission issue when trying to re-install the package.

❯ yay -S pistol-git
:: Checking for conflicts...
:: Checking for inner conflicts...
[Aur:1]  pistol-git-0.1.1.r2.gca4dcbb-1

  1 pistol-git                       (Installed) (Build Files Exist)
==> Packages to cleanBuild?
==> [N]one [A]ll [Ab]ort [I]nstalled [No]tInstalled or (1 2 3, 1-3, ^4)
==> A
:: Deleting (1/1): /home/user/.cache/yay/pistol-git
unlinkat /home/user/.cache/yay/pistol-git/src/pkg/mod/golang.org/x/sys@v0.0.0-20211124211545-fe61309f8881/.gitignore: permission denied
:: (0/1) Downloaded PKGBUILD: pistol-git
 -> error fetching pistol-git: fatal: destination path 'pistol-git' already exists and is not an empty directory. 
    context: exit status 128

the .gitinore file permissions is set to .r--r--r--

thanks for notifying me, I added your changes. I haven't tested it because I don't use pistol anymore (I want to avoid any "go" packages at the moment). Please let me know if something breaks.

please add the manpage compilation since it is now possible

i did it with these changes in PKGBUILD

makedepends=('go' 'git' 'asciidoctor')

build() {
  ...
  asciidoctor -b manpage -d manpage README.adoc
}
package() {
  install -Dm644 -t "$pkgdir/usr/share/licenses/$pkgname/" "$srcdir/$pkgname/LICENSE"
  install -Dm644 -t "$pkgdir/usr/share/man/man1" "$srcdir/$pkgname/pistol.1"
  install -Dm755 "$srcdir/bin/pistol" "$pkgdir/usr/bin/pistol"
}