Package Details: playonlinux5-git r2553.b523e3f9e-1

Git Clone URL: https://aur.archlinux.org/playonlinux5-git.git (read-only, click to copy)
Package Base: playonlinux5-git
Description: GUI for managing Windows programs under linux (development version based on Java)
Upstream URL: http://www.playonlinux.com/
Keywords: playonlinux playonlinux5 pol pol5 wine
Licenses: GPL
Submitter: captain
Maintainer: None
Last Packager: TheGoliath
Votes: 27
Popularity: 0.000000
First Submitted: 2015-11-13 11:07
Last Updated: 2020-05-16 12:57

Dependencies (7)

Required by (0)

Sources (3)

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 9 Next › Last »

ProfessorKaos64 commented on 2017-02-07 02:41

Are you talking about lib that gets dropped in /opt/playonlinux5? ./pkg/playonlinux5-git/opt/playonlinux5/lib gets set to 755 (per it being a directory). This is just part of the build process. Which lib/ dir do you mean?

ProfessorKaos64 commented on 2017-02-07 02:04

SolarAquarion. thanks, I'll take a look soon. Work has been hectic. Hoping to get to this tomorrow.

SolarAquarion commented on 2017-01-21 14:14

@professorKaos64 set lib/ to chmod 644 or it doesn't load slf4j and other needed api's

Det commented on 2017-01-19 15:10

That's my point..

Whatever your coding style is, please make it _consistent_.

ProfessorKaos64 commented on 2017-01-19 01:25

White space is preference of code style (same as I prefer a new line after and before brackets {}, I consider it readability than squished code. I will take a look and compact some. I will correct the comment as well so it is correct.

Det commented on 2017-01-17 15:24

The new lines and white space are still sort of out of control, otherwise no (functional) complaints.

Also, "Take the highest sorted version of either (head -1) so that versions above 8 will be selected" is not true or at least confusing. Head is the head (first alphanumerically). Tail is the last. The whole comment line is also weirdly separated from the previous one. "# Set environment" also shouldn't follow with a duplicate line "# Set JAVA_HOME [...]".

Det commented on 2017-01-16 16:46

archlinux-java *does* show it? "java-8-openjdk/jre" _is_ JRE. https://aur.archlinux.org/packages/jre/ is also JRE (uses /usr/lib/jvm/java-8-jre/ instead of /usr/lib/jvm/java-8-jdk/).

Oracle JDK 9 is https://aur.archlinux.org/packages/jdk-devel/. Seems to do fine, since there's still as of yet no OpenJDK alternative.

I guess you could do something like:

# Make sure we use JDK 8 or higher
if (( $(archlinux-java get | cut -d "-" -f2) < 8 )) || [[ ! -f /usr/bin/javac ]]; then
 # Prefer OpenJDK
 _openjdks=($(ls /usr/lib/jvm/java-{8,9}-openjdk/bin/javac 2>/dev/null | cut -d "/" -f-5))
 if [[ $_openjdks ]]; then
  # Pick first one available
  export JAVA_HOME=${_openjdks[0]}
 else
  # Fall back to other JDKs
  export JAVA_HOME=$(ls /usr/lib/jvm/java-{8,9}-*/bin/javac 2>/dev/null | cut -d "/" -f-5 | head -1)
 fi
fi

I'm not sure it works.

ProfessorKaos64 commented on 2017-01-16 16:41

Det, I have jre installed, can you note which package to install so archlinux-java shows it? I then can account for that. I am very appreciative for your help regardless. For JDK 9, I do not see that in the AUR, am I missing that? Or do you have a link to an install?

https://wiki.archlinux.org/index.php/java#List_compatible_Java_environments_installed

Det commented on 2017-01-16 16:37

I forgot about the PATH thing, but it's just that easy to convert it to JAVA_HOME. Also, it was too early in the morning for doing the [[ ! $openjdk ]] so good thing you caught it. :D

But again, even if you prefer OpenJDK when none is set, your current implementation doesn't work for JRE or JDK 9. Also, that if statement example, as mentioned, was of your previous version, which didn't do at all what you were talking about.

By the way, "..." or "pretty basic Bash" is not "passive aggressive". :D

ProfessorKaos64 commented on 2017-01-16 14:39

I'm quite aware how if statements work. 95% of my GitHub repos are bash shell. I am not fighting your syntax. if your environment is >=8, the statements do nothing and the build uses your default set.

> You could use my aforementioned 3 lines, and it would work in all cases.

Except when I have openjdk and oracle jdk both installed. PATH does *NOT* work. As much as you are telling me to change this and that, did you test the build with those 3 lines? I am not forcing users to the jdk AUR package if they have both installed (which I know you maintain). If they remove openjdk, it will select oracle jdk. Otherwise, anyone is free to set their default java env what they want. If they do so, that condition is harmless, and the build will use whatever default >=8 they have. Your code only takes the leading line ...

ls /usr/lib/jvm/java-{8,9}-*/bin/javac 2>/dev/null | cut -d "/" -f-5
/usr/lib/jvm/java-8-jdk
/usr/lib/jvm/java-8-openjdk

... which is jdk (due to alphabetization). This completely negates those who want to use openjdk. There isn't a 100% happy medium here, and i'm tiring of arguing it. openjdk is preferred, it's in the official repositories. That is my decision.

> [[ "${openjdk}" != "" ]] you can do [[ ! $openjdk ]] (

If you are going to lecture me about bash, that is not correct. [[ "${openjdk}" != "" ]] is NOT the same as [[ ! $openjdk ]]. The first is checking string contents, the second checks if the string is actually assigned. If you were to use ! $openjdk, the statement would fail, (which I tested it..). [[ $openjdk ]] is appropriate in the condition I have (which I did test for, before you ask). I don't even have to put that logic in there, it's there as a courtesy. I could have easily noted you must have jdk >= 8.

I will clean up the consistency of the var's, that is my fault. The passive aggressive "..." 's , "pretty basic [this]" and such, are not warranted. I know my way around bash, and yes, I make mistakes, which I appreciate corrections for, such as the consistent var syntax.