Arch Linux User Repository

@vvlad: 10x, fixed.

There's a small typo on line 4 of plymouth-zfs.install: It reads /etc/mkinitpcio.conf instead of /etc/mkinitcpio.conf (pc instead of cp).

Seems it's not up to date with latest zfs hook, and apparently may break newer plymouth versions. I guess it'd also break if plymouth isn't available. Did this below from original zfs hook, works fine.

~ ❯ diff /usr/lib/initcpio/hooks/zfs /usr/lib/initcpio/hooks/plymouth-zfs2
82,89c82,90
<         # Try the default loading mechanism
<         zfs load-key "${encryptionroot}" && break
< 
<         # Load failed, try a prompt if the failure was not a prompt
<         if [ -n "${prompt_override}" ]; then
<             echo "Unable to load key ${keylocation}; please type the passphrase"
<             echo "To retry the file, interrupt now or repeatedly input a wrong passphrase"
<             zfs load-key -L prompt "${encryptionroot}" && break
---
>         if command -v plymouth >/dev/null 2>&1 && plymouth --ping 2>/dev/null; then
>             # Use Plymouth for passphrase prompt
>             plymouth ask-for-password \
>                 --prompt="Password for ${dataset} dataset" \
>                 --command="zfs load-key ${encryptionroot}"
>         else
>             # Fallback: plain loop
>             echo "Enter passphrase for ${encryptionroot}:"
>             zfs load-key "${encryptionroot}" && break

sudo cp /usr/lib/initcpio/install/zfs /usr/lib/initcpio/install/plymouth-zfs2
sudo cp /usr/lib/initcpio/hooks/zfs /usr/lib/initcpio/hooks/plymouth-zfs2

Seconding @vvlad here, yes, there is absolutely no need to duplicate stuff that is already in the {sd-,}plymouth install hooks here in this one.

Since this hook depends on the plymouth hook being present, which already loads the correct label binary, I think label-* could be removed altogether from this one.

I'm not sure what the implications are, but it seems to boot fine on my machine with the hooks array below:

HOOKS=(base udev plymouth autodetect modconf block keyboard clevis encrypt resume plymouth-zfs filesystems)

Hey @raze_lighter777c,

with the newest version of plymouth-git, this hook fails to build a complete image with the following error in mkinitcpio.

==> ERROR: file not found: `/usr/lib/plymouth/label.so'

Plymouth-git seems to have introduced the label-freetype.so and label-pango.so files instead of the label.so file, which breaks compatibility to this mkinitcpio script. (see their install file here: https://aur.archlinux.org/packages/plymouth-git)

If this script here should support both plymouth and plymouth-git, it's probably more difficult to fix, as the non-git plymouth version still uses label.so.

@tessaracht @vvlad Hey sorry for the wait I was unavailable. Should be working now.

I definitely just got bit by that mount handler bug. @raze_lighter777c, any chance we could get that fix merged?

Hi, thanks for updating this.

There's an issue in the hook, however: it doesn't ignore filesystems with canmount=off.

The issue is in function zfs_mount_handler, starting line 83:

https://aur.archlinux.org/cgit/aur.git/tree/plymouth-zfs.initcpio.hook?h=plymouth-zfs&id=ef7d7220c8526891326363d3d85f4c8ce0d8c617#n83

I've made a fork of this inspired by the hooks from the base archzfs package, for comparison:

https://github.com/vladvasiliu/plymouth-zfs-mkinitcpio/blob/c046d670b85b4839025dea569d7af612bf841c03/plymouth-zfs/plymouth-zfs.hook#L99

Note to all lightdm users: Please disable lightdm.service and enable plymouth-lightdm.service.

This will fix booting and flickering issues.