Package Details: pms-git 0.42.r822.g000c5c0-1

Git Clone URL: https://aur.archlinux.org/pms-git.git (read-only)
Package Base: pms-git
Description: Practical Music Search is an interactive Vim-like console client for the Music Player Daemon.
Upstream URL: https://github.com/ambientsound/pms
Licenses: MIT
Submitter: stefanc_diff
Maintainer: stefanc_diff
Last Packager: stefanc_diff
Votes: 1
Popularity: 0.249659
First Submitted: 2019-06-10 17:16
Last Updated: 2019-06-10 17:16

Dependencies (3)

Required by (0)

Sources (2)

Latest Comments

cheezsteak commented on 2019-07-08 17:07

It's good that you're using a clean root to develop the package but the package should still be installable with vanilla makepkg.

I attempted my suggested changes using makechrootpkg and they failed so here are the updated versions that work in both the chroot and vanilla makepkg:

I don't know how you feel about the GOPATH patch but it's my opinion that PKGBUILD should make as few assumptions as possible about the users setup. Setting GOPATH avoids assuming that GOPATH is set or that ~/go exists. It also has the added effect of not modifying the users actual go environment if it exists. That's a pro in my option but that's probably subjective.

stefanc_diff commented on 2019-07-08 10:02

Thanks for the feedback cheezsteak ! Some context: - the way I build pkgs locally ( including pms-git ) is by using the systemd-nspawn chroot functionality provided by the arch devtools.

This means that pkgs always build in a clean(pristine) environment without any need to interfere/interact with your local workstation GOPATH or any other local pkg. PKGBUILD doesn't assume anything about your GOPATH, "$HOME/go" is the default GOPATH used by the go build tool-chain. pms-git builds fine in this way.

See the wiki for docs - https://wiki.archlinux.org/index.php/DeveloperWiki:Building_in_a_clean_chroot

cheezsteak commented on 2019-07-05 15:09

This package fails to build with makepkg. I noticed two errors. $BUILDDIR/${pkgname} evaluates to "pms-git/pms-git" which is wrong if you're building from inside pms-git. Please replace with just $BUILDDIR.

Also PKGBUILD assumes $HOME/go as $GOPATH instead of just using $GOPATH.

I can provide git patches for both if you need them.