@ItachiSan, btw, there's no need to patch to adjust the URLs anymore, that has been commited by upstream already:
https://github.com/popcorn-official/popcorn-desktop/issues/2196#issuecomment-858619315
And, the commit:
https://github.com/popcorn-official/popcorn-desktop/commit/43efd3883184496af57c2dc833e4e618bac90626
But, I believe top of master is way better, the last commit:
https://github.com/popcorn-official/popcorn-desktop/commit/022450e2f27f9ebebc81607d8cba86fcf98bb34b
So, perhaps you just sync with latest commit on master, and you don't need to patch anymore...
Pinned Comments
ItachiSan commented on 2018-07-24 21:01 (UTC) (edited on 2021-06-14 09:35 (UTC) by ItachiSan)
You are free to report issues regarding the packaging here! Please read all the info of this message as they include quite some information.
Be aware that sometimes the package will fail to build because of outdated upstream and updated dependency, which will require me some time to test and solve the problem.
I do also have life stuff, packaging is a free-time activity.
I believe I have an issue that is Arch-related and not upstream related
I too found out only recently this way to debug the app (as of: 2021-06-13), which helps immensely.
Whenever reporting here or on the Github issues, please provide the output of the command:
In case you are forwarding the log to a file, as the log entries will end in
stderr
, remember to redirectstderr
tostdout
Info regarding the package
The package uses the sources available at: https://github.com/popcorn-official/popcorn-desktop. I am aware of the different clones and branches; I do still believe that this code is acceptable (not affected itself from malware).
This package uses a custom NW.js build provided from the PopcornTime team; essentially, a custom compiled browser. While this won't affect you as it should be used only within the app, you are here informed that I have no power over this component.
The above point stands as the official NW.js Chromium source lacks multiple modern codecs, such as AC3 and HEVC (H.265).
Earlier this package used the official nw.js toolchain provided available at https://dl.nwjs.io/ and the prebuilt FFmpeg library with additional codecs available at https://github.com/iteufel/nwjs-ffmpeg-prebuilt/ . This was because the nw.js toolchain provided by the PopcornTime team can not be proven as non-malware easily. However, due to point 3, this approach was reverted. You are free to use an older PKGBUILD with the appropriate variable updates to re-enable this, however you will miss support for recent codecs.
In addition, the PKGBUILD won't point to the Git release reference but will also include important commits, for e.g. security reasons or providers changes.