Package Details: pycharm-professional 2020.3.3-1

Git Clone URL: https://aur.archlinux.org/pycharm-professional.git (read-only, click to copy)
Package Base: pycharm-professional
Description: Python IDE for Professional Developers. Professional Edition
Upstream URL: https://www.jetbrains.com/pycharm/
Keywords: development editor ide jetbrains python
Licenses: custom
Conflicts: pycharm, pycharm-community-edition
Provides: pycharm
Submitter: hippojazz
Maintainer: XavierCLL
Last Packager: XavierCLL
Votes: 238
Popularity: 2.74
First Submitted: 2013-09-25 03:56
Last Updated: 2021-01-28 02:44

Dependencies (29)

Required by (0)

Sources (4)

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 9 10 ... Next › Last »

donny commented on 2020-04-23 23:39

Telegram has similar story. Fonts removed from the package in 1.5.0-2, the update reverted in 1.5.0-3, introduced again with additional patch fixing the visual issues in 1.5.1-2.

But it's history. Today, Telegram Desktop does not include Open Sans fonts in the build (I mean the cmake build, not the arch package build), unless you reconfigure it to do so. Also afaik Telegram Desktop is Qt app, so it chooses some cute default font when the expected one isn't installed.

On the other side, what does JetBrains say on their websites:

"The most recent version of JetBrains Mono ships with your JetBrains IDE starting with v2019.3."

"JetBrains Mono - Default editor font in PyCharm Since 2020.1"

Telling me "you were using fonts in pycharm that wasn't installed on your system" after removing the default font from the package, the font that is said to be part of the official distribution, is big fail, I am sorry to say that.

Please, @XavierCLL, don't take me wrong, I do appreciate your work on the package, I'm glad you do this and I really like the incredible speed of the package upgrades, and I really don't want to be rude (but please don't compare your unpaid free time with my working hours). I just don't want my most important AUR package to be broken. I rely on this package a lot and you didn't even wrote any warning here in comments about such big change (the package has 19 optdeps, it's easy to overlook the new one), so when I started the app, and had to wait three seconds to render any dropdown menu etc., and then I saw the ugly java-default-monospace font in console (that really wasn't the one I choose in my DE as a default monospace font), I was a little frightened.

CaeZaR commented on 2020-04-23 17:14

@XavierCLL, thanks for your consistent work packaging up pycharm. It is appreciated.

Kharacternyk commented on 2020-04-23 17:09

@sanerb There is a precedent in the official repos: Telegram is shipped without DejaVu Sans built-in. The font is an optional dependency, just like here.

tocic commented on 2020-04-23 10:45

Also got broken fonts after the upgrade. Please fix it.

sanerb commented on 2020-04-23 09:41

@XavierCLL -

@donny is very much correct when he says "Please don't touch the official distribution if such change doesn't fix broken functionality in Arch Linux".

Making changes from upstream that are not simply to fix bugs is simply NOT the Arch Way. Note the very first one, "Simplicity":

"Arch Linux defines simplicity as without unnecessary additions or modifications. It ships software as released by the original developers (upstream) with minimal distribution-specific (downstream) changes: patches not accepted by upstream are avoided, and Arch's downstream patches consist almost entirely of backported bug fixes that are obsoleted by the project's next release."

If you believe that your modifications are superior to how JetBrains intended to distribute their product, you are welcome to suggest upstream to them. Users installing this package expect the package to operate as JetBrains distributes it. Alternatively, if you insist on packaging them for the AUR, they should be done so as a separate AUR package (e.g. "pycharm-professional-nofonts").

Please rectify this and remove your deletion of the JetBrains-bundled fonts in this package, otherwise further action may be taken by this package's users. I can confirm breakage as my system fonts are not even populated in the editor, and now none of my lines line up properly. Further, my custom guides are gone. In a language that is entirely whitespace-driven such a python, this is a big deal. With multiple users confirming breakage for them with your change, "works for me" is absolutely not a justified response. This is why you do not make unnecessary changes from upstream, even if you deem them "improvements".

Further, this modification in a packaging context of a proprietary-licensed product may or may not constitute breach of license. I'd recommend consulting with JetBrains on this. However, it's quite clear that your users disagree with your modifications.

XavierCLL commented on 2020-04-22 17:16

@donny that was because you were using fonts in pycharm that wasn't installed on your system, and use the system font is better, or otherwise if you or someone else can describe that pycharm is unstable with this change in more details, I'll reverse that change. I've tested and all works perfectly. ("and nobody will pay me for this" me neither)

donny commented on 2020-04-22 08:51

As for the latest change - "remove internal fonts, instead use system fonts". PyCharm on my machine become slow and some fonts are messed up. I needed to rebuild the package without removing the built-in fonts, then everything is ok again. Please don't touch the official distribution if such change doesn't fix broken functionality in Arch Linux. I am supposed to work now, but I must solve package issue instead, and nobody will pay me for this.

XavierCLL commented on 2020-04-21 20:59

Thanks @donny, fixed!

donny commented on 2020-04-21 17:52

There is also no need to use the -f parameter within the rm call. Please remove it together with the sudo.

While you are updating the PKGBUILD, please make sure to use quotation marks when using a variable in a string parameters. Missing that causes a package build to fail when the build path contains a space character.

Example:

bad: install -dm 755 $pkgdir/opt/$pkgname

good: install -dm 755 "$pkgdir/opt/$pkgname" (this variant is used in /usr/share/pacman/PKGBUILD.proto)

also good: install -dm 755 "$pkgdir"/opt/"$pkgname"

XavierCLL commented on 2020-04-21 17:38

Thank for the report @hottea, that was a silly mistake, fixed