Arch Linux User Repository

Hello, I have a proposal for this PKGBUILD. 1. Make the license SPDX compliant 2. Use the official method of using pyinstaller to create a binary 3. Remove the pyobd, pyobd.desktop, pyobd.png, and pyobd.install as they are no longer needed as there is a binary, the .desktop and .pngs will be generated 4. Build the actual binary 5. And, install everything properly

Here is the patch file for the whole git repo

diff --git a/PKGBUILD b/PKGBUILD
index 4a7aa65..d70595b 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,35 +1,46 @@
 # Maintainer: Presence <dan465 at mail dot com>

 pkgname=pyobd
-pkgver=1.16
+pkgver=1.17
 pkgrel=1
 pkgdesc="An OBD-II compliant car diagnostic tool"
-arch=('any')
+arch=('x86_64')
 url="https://github.com/barracuda-fsh/pyobd"
-license=('GPL')
-depends=('python-wxpython' 'python-pyserial' 'python-numpy' 'python-tornado' 'python-pint' 'hicolor-icon-theme')
-install=pyobd.install
-source=(https://github.com/barracuda-fsh/pyobd/archive/refs/tags/v${pkgver}.tar.gz
-        pyobd
-        pyobd.desktop
-        pyobd.png)
-sha256sums=('a10a09113dc20e28938f58a54337ae69577405a4e01795441eb1dc0b5f08cdef'
-            '78399115ad17dedfaf6d0391e8bc5cf11575b0dcab4beff8103bbabe094d998f'
-            'cc7c1e48b320fad408a49e876ceb841c19cbd921ebe58a25966eb224daef7e22'
-            '14d0d90dcda38c339dc8397f004923075f6d4fce37b7c8539021f4a77b3a86fd')
+license=('GPL-2.0-only')
+makedepends=('pyinstaller' 'pyside6-tools' 'icoutils' 
+   'python-wxpython' 'python-pyserial' 'python-numpy'
+   'python-tornado' 'python-pint' 'pyside6' 'icoutils'
+   'gendesk')
+depends=('glibc' 'hicolor-icon-theme' 'zlib')
+source=(https://github.com/barracuda-fsh/pyobd/archive/refs/tags/v${pkgver}.tar.gz)
+sha256sums=('0bd0dd2bdb9d64f6c097f372f946e14c6ccf3bf97cd40ef6cc7742d92bf75fd0')

-package() {
+build() {
     cd "$srcdir/${pkgname}-${pkgver}"
+    pyinstaller --onefile -w -i pyobd.ico --add-data "pyobd.ico:." pyobd.py
+    gendesk -f --pkgname=$pkgname \
+    --pkgdesc="$pkgdesc" \
+    --name=$pkgname \
+    --exec=$pkgname \
+    --icon=$pkgname \
+    --terminal=false \
+    --categories=Development,Utilities
+
+    mkdir -p "$srcdir/icons"
+    icotool -x pyobd.ico -o "$srcdir/icons"
+}

-    install -Dm644 "$srcdir/pyobd.desktop"  "$pkgdir/usr/share/applications/$pkgname.desktop"
-    install -Dm644 "$srcdir/pyobd.png"      "$pkgdir/usr/share/icons/hicolor/32x32/apps/$pkgname.png"
-    install -Dm644 "COPYING"                "$pkgdir/usr/share/licenses/$pkgname/COPYING"
-    install -Dm644 "pyobd.ico"              "$pkgdir/usr/lib/$pkgname/pyobd.ico"
-    install -Dm755 "$srcdir/pyobd"          "$pkgdir/usr/bin/pyobd"
+package() {
+    cd "$srcdir/${pkgname}-${pkgver}"

-    mkdir -p "$pkgdir/usr/lib/$pkgname/obd/protocols/"
-    install -m644 -t "$pkgdir/usr/lib/$pkgname/" *.py
-    install -m644 -t "$pkgdir/usr/lib/$pkgname/obd/" obd/*.py
-    install -m644 -t "$pkgdir/usr/lib/$pkgname/obd/protocols/" obd/protocols/*.py
+    install -Dm755 "dist/$pkgname" "$pkgdir/usr/bin/$pkgname"
+    install -Dm644 "$srcdir/${pkgname}-${pkgver}/$pkgname.desktop" "$pkgdir/usr/share/applications/$pkgname.desktop"
+    cd "$srcdir/icons"
+    export num=1
+    for size in {16,24,32,48,64,72,96,128,256};
+    do
+       install -Dm644 ${pkgname}_${num}_${size}x${size}x32.png "$pkgdir/usr/share/icons/hicolor/${size}x${size}/apps/$pkgname.png"
+       export num=$(($num+1))
+    done
 }

diff --git a/pyobd b/pyobd
deleted file mode 100644
index 58ac32e..0000000
--- a/pyobd
+++ /dev/null
@@ -1,4 +0,0 @@
-#!/bin/sh
-
-cd /usr/lib/pyobd
-python3 pyobd.py
diff --git a/pyobd.desktop b/pyobd.desktop
deleted file mode 100644
index 3d56943..0000000
--- a/pyobd.desktop
+++ /dev/null
@@ -1,11 +0,0 @@
-[Desktop Entry]
-Encoding=UTF-8
-Icon=pyobd
-Name=pyOBD
-GenericName=OBD2 Diagnostics
-Comment=Car On-Board 2 vehicle diagnostics (ELM-32x compatible interface)
-Exec=pyobd
-Terminal=false
-Type=Application
-Categories=Utility;
-StartupNotify=true
diff --git a/pyobd.install b/pyobd.install
deleted file mode 100644
index 5f3cb01..0000000
--- a/pyobd.install
+++ /dev/null
@@ -1,12 +0,0 @@
-post_install() {
-  gtk-update-icon-cache -q -t -f usr/share/icons/hicolor
-}
-
-post_upgrade() {
-  post_install
-}
-
-post_remove() {
-  post_install
-}
-
diff --git a/pyobd.png b/pyobd.png
deleted file mode 100644
index d1ecd6c..0000000
Binary files a/pyobd.png and /dev/null differ

Thanks! I've updated the check sum

@Presence repo now available https://github.com/barracuda-fsh/pyobd/releases/.

please update checksums

Subject: Re: Pyobd repo on Github Sent: August 18, 2023 3:23:33 PM GMT+03:00 From: Jure Poljsak pyobd.jp@gmail.com To: <my-email>

I had a personal crysis, I expected more stars from the project. I will put it back on... I still have a copy. I'm sorry for the whole thing, letting down a follower.

On Sat, Jul 15, 2023 at 8:33 AM wrote:

Hello. I followed your project, but suddenly its repository on github disappeared somewhere. Tell me what happened.

An alternative is to switch to an inbetween fork which still has the potential to survive: https://github.com/AshBT/pyobd

Even the author of the lost fork commited some patches there, so it might be the best point to go forward from.

I have send letter with that question to email, i've find using web archive.

Yes, build will also be very helpful.

I can send over a built pkg.tar.xz package that can be installed and contains the code, but I no longer have a copy of v1.14.tar.gz.

Have you contacted the developer to see why he removed his code from GitHub?

Is anybody have sources? Original repo close access. Who can give link to v1.14.tar.gz?

Thanks! I've updated this to use barracuda-fsh/pyobd. Let me know if you find any issues with it.