Arch Linux User Repository

Thanks @Xeonacid for help, I'm glad to add you as a co-maintainer.

@kistlin – Thanks for noticing, some unit tests indeed fail – it is a known problem. It has to be reported to the upstream developers (if they are still active).

For me several unit tests fail. No matter if I use the official PKGBUILD or the one from @Xeonacid.

FAILED tests/test_codecs_consistency.py::Asn1ToolsCodecsConsistencyTest::test_c_source - IndexError: string index out of range
FAILED tests/test_command_line.py::Asn1ToolsCommandLineTest::test_command_line_generate_c_source_oer - IndexError: string index out of range
FAILED tests/test_command_line.py::Asn1ToolsCommandLineTest::test_command_line_generate_c_source_uper - SystemExit: error: string index out of range
FAILED tests/test_command_line.py::Asn1ToolsCommandLineTest::test_command_line_generate_rust_source_uper - SystemExit: error: string index out of range
FAILED tests/test_compile.py::Asn1ToolsCompileTest::test_missing_parameterized_value - IndexError: string index out of range
FAILED tests/test_oer.py::Asn1ToolsOerTest::test_c_source - IndexError: string index out of range
FAILED tests/test_parse.py::Asn1ToolsParseTest::test_parse_parameterization - IndexError: string index out of range

The PKGBUILD should adhere to Python package guidelines and some other improvements: - Use tag instead of commit in source array - Checksum should not be skipped with new devtools - pkgver() is not needed - python-prompt_toolkit python-diskcache should be added to depends instead of makedepends - python-trio is unused for check - Install LICENSE and README, drop licenses depends - --compile-bytecode=2 is not needed

My adjusted PKGBUILD can be used as a reference.

I'd like to co-maintain the package if applicable.

Thanks @MarsSeed for useful remarks. Package should be in a much better shape now.

I think I've fixed all issues. Thanks a lot @dreieck and @weltio for letting me know. Sadly 7 unit tests are failing and this has to be fixed in the upstream repo. For now you have to use --nocheck.

I somehow forgot about this package, working on fix.

bitstruct is still a problem

python-bitstruct needs to be added as a dependency:

Traceback (most recent call last):
  File "/usr/bin/ardpscan", line 5, in <module>
    from aardwolf.examples.scanners.__main__ import main
  File "/usr/lib/python3.11/site-packages/aardwolf/examples/scanners/__main__.py", line 4, in <module>
    from aardwolf.commons.factory import RDPConnectionFactory
  File "/usr/lib/python3.11/site-packages/aardwolf/commons/factory.py", line 8, in <module>
    from aardwolf.connection import RDPConnection
  File "/usr/lib/python3.11/site-packages/aardwolf/connection.py", line 10, in <module>
    import asn1tools
  File "/usr/lib/python3.11/site-packages/asn1tools/__init__.py", line 18, in <module>
    from .compiler import compile_dict
  File "/usr/lib/python3.11/site-packages/asn1tools/compiler.py", line 10, in <module>
    from .codecs import compiler
  File "/usr/lib/python3.11/site-packages/asn1tools/codecs/compiler.py", line 6, in <module>
    import bitstruct
ModuleNotFoundError: No module named 'bitstruct'

Thanks for maintaining!

Applying the patch fails for me:

==> Starting prepare()...
/home/felics/.cache/yay/python-asn1tools/PKGBUILD: line 32: ../00-handle-odd-numbered-hex-strings.patch: No such file or directory
==> ERROR: A failure occurred in prepare().

Changing the patch line solves it:

patch -p1 -d asn1tools-$pkgver < "${srcdir}/00-handle-odd-numbered-hex-strings.patch"

I think you should switch to using python -m build and python -m installer instead of invoking setup.py directly:

/usr/lib/python3.11/site-packages/setuptools/_distutils/cmd.py:66: SetuptoolsDeprecationWarning: setup.py install is deprecated.
!!

        ********************************************************************************
        Please avoid running ``setup.py`` directly.
        Instead, use pypa/build, pypa/installer, pypa/build or
        other standards-based tools.

        See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for details.
        ********************************************************************************

!!

e.g. (just the idea, not tested with your package):

[...]
makedepends=(
  'python-build'
  'python-installer'
  'python-wheel'
  'python-setuptools'
  [...]
)
[...]
build() {
  [...]
  python -m build --wheel --no-isolation
  # maybe build documentation, ...
  [...]
}

package() {
  [...]
  python -m installer --destdir="$pkgdir" --compile-bytecode=2 dist/*.whl
  [...]
  # Maybe install documentation, license, ...
  [...]
}

Regards!