Package Details: python-fangfrisch 1.9.0-4

Git Clone URL: https://aur.archlinux.org/python-fangfrisch.git (read-only, click to copy)
Package Base: python-fangfrisch
Description: Freshclam like utility that allows downloading unofficial virus definition files
Upstream URL: https://rseichter.github.io/fangfrisch/
Licenses: GPL
Conflicts: clamav-unofficial-sigs
Provides: clamav-unofficial-sigs
Submitter: amish
Maintainer: amish (Morbius)
Last Packager: amish
Votes: 28
Popularity: 0.75
First Submitted: 2020-02-22 16:48 (UTC)
Last Updated: 2024-08-21 01:26 (UTC)

Latest Comments

1 2 3 4 5 6 .. 8 Next › Last »

Morbius commented on 2024-08-21 01:35 (UTC)

@amish: Yeah, that was a weird situation. Before unpacking the source tarball, the working directory should be empty, and only the Python interpreter itself should ever create "pycache" directories anywhere in the tree. Something strange happened there on your machine.

amish commented on 2024-08-21 01:28 (UTC)

@Morbius - it worked. But I dont see any pycache directory in ~/.cache and issue never occurred earlier. Thanks.

Morbius commented on 2024-08-20 11:21 (UTC) (edited on 2024-08-20 11:41 (UTC) by Morbius)

@amish: I just built the previous Git master 2b40fd2c7b02a4d3edf6ef9f2b5d402efdd24f4a and did not encounter any problems. I suspect that the pycache directory on your machine, which caused sed to fail, was the remnant of some previous run. In the check() function, sed runs before "python -m unittest ...", and only the latter step is expected to create any pycache directories. However, I have added a small change to increase robustness.

amish commented on 2024-08-20 01:43 (UTC) (edited on 2024-08-20 01:46 (UTC) by amish)

@Morbius When trying to rebuild the package it gives following error.

<snip>

adding 'fangfrisch-1.9.0.dist-info/top_level.txt'
adding 'fangfrisch-1.9.0.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
Successfully built fangfrisch-1.9.0-py3-none-any.whl
==> Starting check()...
sed: couldn't edit tests/__pycache__: not a regular file
==> ERROR: A failure occurred in check().
   Aborting...

Can you please check? Thank you.

Morbius commented on 2024-04-10 22:25 (UTC)

@samuel.jimenez Thanks, I am aware of this. It is also stated in the official Fangfrisch documentation. 😉

samuel.jimenez commented on 2024-04-10 17:07 (UTC) (edited on 2024-04-10 17:10 (UTC) by samuel.jimenez)

To integrate with journald, the following lines need to be added to fangfrisch.conf:

#log_level = DEBUG
log_method = syslog
log_target = /dev/log

To enable InterServer (which was added in the same release as Fangfrisch News):

[interserver]
enabled = yes

bsdice commented on 2024-03-13 13:25 (UTC)

I do read https://wiki.archlinux.org/title/Arch_Linux from time to time. To remind myself why Arch is so popular. ;-)

So may I suggest to just take the pragmatic approach and fix the package to just work with or without clamav installed. I think best way is to skip any chown in PKGBUILD and use the modern tmpfiles approach as suggested by Taijian, plus steal clamav.sysusers from clamav package, name it python-fangfrisch.sysusers and keep the content as per https://gitlab.archlinux.org/archlinux/packaging/packages/clamav/-/blob/main/clamav.sysusers?ref_type=heads:

u clamav 64 "Clam AntiVirus" -

Package tmpfiles file /usr/lib/tmpfiles.d/python-fangfrisch.conf should also contain:

d /var/lib/clamav 0755 clamav clamav

To set everything up bare-bones. Here is the documentation von tmpfiles: https://www.freedesktop.org/software/systemd/man/latest/tmpfiles.d.html

Taijian commented on 2024-03-12 23:58 (UTC)

@Morbius: The way I suggested is how packages in core and extra deal with these issues, I would therefore assume, that this is the "correct" way to do it.

My suggestion would help insofar, as the absence of the clamav user in the build chroot would no longer matter, but the file ownership would still be changed at boot/install time, via systemd.

Morbius commented on 2024-03-12 16:59 (UTC) (edited on 2024-03-12 17:03 (UTC) by Morbius)

Is there specific documentation available about what PKGBUILD is not supposed/permitted to do? I am new to the AUR packaging subject and don't recall having read about constraints of PKGBUILD yet. Edit: How would your suggestion help with the absence of the "clamav" user?

Taijian commented on 2024-03-12 16:32 (UTC)

@Morbius: Au contraire!

You should definitely adress this, because setting file ownership in the PKGBUILD is definitely not the right way of doing things. What this package should do is install a file to /usr/lib/tmpfiles.d/python-fangfrisch.conf with the content:

    z /etc/fangfrisch/fangfrisch-has-news.sh 750 root clamav

That would be the right way to go about this.