Arch Linux User Repository

@amish: According to my own build logs, all 82 tests pass (14 tests skipped, as expected). I will set up a fresh Arch machine and retry. In the meantime, what Python version is running on your machine?

@Morbius: Checks failing again with this release.

The system where I am building this DOES NOT have python-fangfrish installed.

So tests are failing as follows:

test_config (unittest.loader._FailedTest.test_config) ... ERROR
test_db (unittest.loader._FailedTest.test_db) ... ERROR
test_download (unittest.loader._FailedTest.test_download) ... ERROR
test_dump (unittest.loader._FailedTest.test_dump) ... ERROR
test_log (unittest.loader._FailedTest.test_log) ... ERROR
test_refresh (unittest.loader._FailedTest.test_refresh) ... ERROR
test_task (unittest.loader._FailedTest.test_task) ... ERROR
test_util (unittest.loader._FailedTest.test_util) ... ERROR

======================================================================
ERROR: test_config (unittest.loader._FailedTest.test_config)
----------------------------------------------------------------------
ImportError: Failed to import test module: test_config
Traceback (most recent call last):
  File "/usr/lib/python3.13/unittest/loader.py", line 396, in _find_test_path
    module = self._get_module_from_name(name)
  File "/usr/lib/python3.13/unittest/loader.py", line 339, in _get_module_from_name
    __import__(name)
    ~~~~~~~~~~^^^^^^
  File "/home/foo/AUR/python-fangfrisch/src/fangfrisch-1.9.1/tests/test_config.py", line 22, in <module>
    from fangfrisch.config import LOG_METHOD_CONSOLE
ModuleNotFoundError: No module named 'fangfrisch'

So on for other tests.

If I first install old version (1.9.0) of python-fangfrisch then tests succeed.

So something is wrong somewhere.

Please check.

@amish: Yeah, that was a weird situation. Before unpacking the source tarball, the working directory should be empty, and only the Python interpreter itself should ever create "pycache" directories anywhere in the tree. Something strange happened there on your machine.

@Morbius - it worked. But I dont see any pycache directory in ~/.cache and issue never occurred earlier. Thanks.

@amish: I just built the previous Git master 2b40fd2c7b02a4d3edf6ef9f2b5d402efdd24f4a and did not encounter any problems. I suspect that the pycache directory on your machine, which caused sed to fail, was the remnant of some previous run. In the check() function, sed runs before "python -m unittest ...", and only the latter step is expected to create any pycache directories. However, I have added a small change to increase robustness.

@Morbius When trying to rebuild the package it gives following error.

<snip>

adding 'fangfrisch-1.9.0.dist-info/top_level.txt'
adding 'fangfrisch-1.9.0.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
Successfully built fangfrisch-1.9.0-py3-none-any.whl
==> Starting check()...
sed: couldn't edit tests/__pycache__: not a regular file
==> ERROR: A failure occurred in check().
   Aborting...

Can you please check? Thank you.

@samuel.jimenez Thanks, I am aware of this. It is also stated in the official Fangfrisch documentation. 😉

To integrate with journald, the following lines need to be added to fangfrisch.conf:

#log_level = DEBUG
log_method = syslog
log_target = /dev/log

To enable InterServer (which was added in the same release as Fangfrisch News):

[interserver]
enabled = yes

I do read https://wiki.archlinux.org/title/Arch_Linux from time to time. To remind myself why Arch is so popular. ;-)

So may I suggest to just take the pragmatic approach and fix the package to just work with or without clamav installed. I think best way is to skip any chown in PKGBUILD and use the modern tmpfiles approach as suggested by Taijian, plus steal clamav.sysusers from clamav package, name it python-fangfrisch.sysusers and keep the content as per https://gitlab.archlinux.org/archlinux/packaging/packages/clamav/-/blob/main/clamav.sysusers?ref_type=heads:

u clamav 64 "Clam AntiVirus" -

Package tmpfiles file /usr/lib/tmpfiles.d/python-fangfrisch.conf should also contain:

d /var/lib/clamav 0755 clamav clamav

To set everything up bare-bones. Here is the documentation von tmpfiles: https://www.freedesktop.org/software/systemd/man/latest/tmpfiles.d.html

@Morbius: The way I suggested is how packages in core and extra deal with these issues, I would therefore assume, that this is the "correct" way to do it.

My suggestion would help insofar, as the absence of the clamav user in the build chroot would no longer matter, but the file ownership would still be changed at boot/install time, via systemd.