Package Details: python-readchar 3.0.4-1

Git Clone URL: https://aur.archlinux.org/python-readchar.git (read-only, click to copy)
Package Base: python-readchar
Description: Python library to read characters and key strokes
Upstream URL: https://github.com/magmax/python-readchar
Licenses: MIT
Submitter: marioom
Maintainer: marioom (kylelaker)
Last Packager: kylelaker
Votes: 3
Popularity: 0.39
First Submitted: 2020-10-27 20:47
Last Updated: 2021-03-17 02:59

Latest Comments

yochananmarqos commented on 2021-04-05 16:50

flake8 can safely be removed:

    # Flake8 only required for tests
    sed -i '/flake8/d' setup.py

marioom commented on 2021-03-02 19:56

Done! Let me know if there's anything else that can be improved.

kylelaker commented on 2021-03-02 18:07

@marioom: I'd be happy to! This is a dependency of python-inquirer which is a dependency of a package I hope to be uploading soon.

The prefix is documented at https://wiki.archlinux.org/index.php/Arch_package_guidelines#Package_sources. Basically, it makes sure that the tar.gz file gets saved locally with the package name. Without it, the tar file from GitHub is just the tag name which can cause issues in $srcdir if two packages have the same version and don't fix the naming.

marioom commented on 2021-03-02 12:24

@kylelaker ah sure, this library was basically abandoned not too long ago, so I had forgotten about it. Would you like to be added as a co-maintainer?

Also, what's the ${pkgname}-${pkgver}.tar.gz:: prefix? I had never heard about it before. I'll update the PKGBUILD with your suggestions soon.

kylelaker commented on 2021-02-28 21:33

Noticed a few things while trying to install this:

  • flake8 must be added to makedepends (it is in setup.py's setup_requires)
  • ${pkgname}-${pkgver}.tar.gz:: should be added before https:// in the tar download
  • Starting with v3.0.0 the tag names have a v prefix

See: https://gist.github.com/kylelaker/0b09add656216b3bccafae8d4f21b581

Edit: Due to a bug in the source package's setup.py, the tests get included in the package and placed in the root of site-packages, so I updated the gist above to patch that. It could also be done with an rm of the directory in package. See https://wiki.archlinux.org/index.php/Python_package_guidelines#Test_directory_in_site-package