Arch Linux User Repository

@A_Bart I decided to patch it to use normal libmodbus instead of the vendored version. The vendored version has a patch, but it's only enabled on the Windows builds. The version in the repos is slightly newer, please report any regressions here first.

As noted by @mattalxndr the compilation is broken.

I have made a ticket upstream explaining the problem and solution: https://sourceforge.net/p/qmodmaster/tickets/134/

In the meantime, could we have a patch in AUR?

Adding

extern void busMonitorRawRequestData(uint8_t msg, int msg_length); extern void busMonitorRawResponseData(uint8_t msg, int msg_length);

In 3rdparty/libmodbus/modbus.c fixes the problem.

I'm getting an error installing:

==> Starting build()...
Info: creating stash file /home/matt/.cache/yay/qmodmaster/src/qModMaster-code-0.5.2-3/.qmake.stash
/usr/bin/uic forms/mainwindow.ui -o ui_mainwindow.h
/usr/bin/uic forms/about.ui -o ui_about.h
/usr/bin/uic forms/settingsmodbusrtu.ui -o ui_settingsmodbusrtu.h
/usr/bin/uic forms/settingsmodbustcp.ui -o ui_settingsmodbustcp.h
/usr/bin/uic forms/settings.ui -o ui_settings.h
/usr/bin/uic forms/busmonitor.ui -o ui_busmonitor.h
/usr/bin/uic forms/tools.ui -o ui_tools.h
g++ -c -pipe -std=gnu++11 -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wp,-D_GLIBCXX_ASSERTIONS -flto=auto -flto -fno-fat-lto-objects -Wall -Wextra -D_REENTRANT -fPIC -D_TTY_POSIX_ -DQS_LOG_LINE_NUMBERS -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -I3rdparty/libmodbus -I3rdparty/QsLog -I/usr/include/qt -I/usr/include/qt/QtWidgets -I/usr/include/qt/QtGui -I/usr/include/qt/QtNetwork -I/usr/include/qt/QtCore -I. -I. -I/usr/lib/qt/mkspecs/linux-g++ -o main.o src/main.cpp
g++ -c -pipe -std=gnu++11 -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wp,-D_GLIBCXX_ASSERTIONS -flto=auto -flto -fno-fat-lto-objects -Wall -Wextra -D_REENTRANT -fPIC -D_TTY_POSIX_ -DQS_LOG_LINE_NUMBERS -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -I3rdparty/libmodbus -I3rdparty/QsLog -I/usr/include/qt -I/usr/include/qt/QtWidgets -I/usr/include/qt/QtGui -I/usr/include/qt/QtNetwork -I/usr/include/qt/QtCore -I. -I. -I/usr/lib/qt/mkspecs/linux-g++ -o mainwindow.o src/mainwindow.cpp
In file included from src/mainwindow.cpp:10:
src/mainwindow.h: In constructor ‘MainWindow::MainWindow(QWidget*, ModbusAdapter*, ModbusCommSettings*)’:
src/mainwindow.h:51:20: warning: ‘MainWindow::m_modbus’ will be initialized after [-Wreorder]
   51 |     ModbusAdapter *m_modbus;
      |                    ^~~~~~~~
src/mainwindow.h:44:25: warning:   ‘ModbusCommSettings* MainWindow::m_modbusCommSettings’ [-Wreorder]
   44 |     ModbusCommSettings *m_modbusCommSettings;
      |                         ^~~~~~~~~~~~~~~~~~~~
src/mainwindow.cpp:16:1: warning:   when initialized here [-Wreorder]
   16 | MainWindow::MainWindow(QWidget *parent, ModbusAdapter *adapter, ModbusCommSettings *settings) :
      | ^~~~~~~~~~
src/mainwindow.h:44:25: warning: ‘MainWindow::m_modbusCommSettings’ will be initialized after [-Wreorder]
   44 |     ModbusCommSettings *m_modbusCommSettings;
      |                         ^~~~~~~~~~~~~~~~~~~~
src/mainwindow.h:35:21: warning:   ‘Ui::MainWindow* MainWindow::ui’ [-Wreorder]
   35 |     Ui::MainWindow *ui;
      |                     ^~
src/mainwindow.cpp:16:1: warning:   when initialized here [-Wreorder]
   16 | MainWindow::MainWindow(QWidget *parent, ModbusAdapter *adapter, ModbusCommSettings *settings) :
      | ^~~~~~~~~~
gcc -c -pipe -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -flto=auto -flto -fno-fat-lto-objects -Wall -Wextra -D_REENTRANT -fPIC -D_TTY_POSIX_ -DQS_LOG_LINE_NUMBERS -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -I3rdparty/libmodbus -I3rdparty/QsLog -I/usr/include/qt -I/usr/include/qt/QtWidgets -I/usr/include/qt/QtGui -I/usr/include/qt/QtNetwork -I/usr/include/qt/QtCore -I. -I. -I/usr/lib/qt/mkspecs/linux-g++ -o modbus.o 3rdparty/libmodbus/modbus.c
3rdparty/libmodbus/modbus.c: In function ‘send_msg’:
3rdparty/libmodbus/modbus.c:180:5: error: implicit declaration of function ‘busMonitorRawRequestData’ [-Wimplicit-function-declaration]
  180 |     busMonitorRawRequestData(msg,msg_length);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~
3rdparty/libmodbus/modbus.c: In function ‘_modbus_receive_msg’:
3rdparty/libmodbus/modbus.c:475:5: error: implicit declaration of function ‘busMonitorRawResponseData’ [-Wimplicit-function-declaration]
  475 |     busMonitorRawResponseData(msg, msg_length);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~
3rdparty/libmodbus/modbus.c:439:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
  439 |                 if (length_to_read != 0) {
      |                    ^
3rdparty/libmodbus/modbus.c:443:13: note: here
  443 |             case _STEP_META:
      |             ^~~~
make: *** [Makefile:1079: modbus.o] Error 1
==> ERROR: A failure occurred in build().
    Aborting...