Arch Linux User Repository

Hello mathys-lopinto,

Thanks for the patch! I am still new to maintaining packages, so I was not aware of such a function. I was aware that upstream got updated. But since I was gone, I was not able to updated sooner (I also flagged the package with out of date).

Greetings.

Hello,

The maintainer has updated the package. I'm sharing the modifications I made locally to handle the latest release.

I've added the _release_version variable to correctly download the archive and navigate to the appropriate directory. This is necessary because the actual release version (v0.4.4-1) contains a hyphen, which is not permitted in the AUR pkgver field.

Below is the diff between our PKGBUILDs:

diff --git a/original-qobuz-player/PKGBUILD updated-qobuz-player/PKGBUILD
index cad1852..164baf0 100644
--- a/original-qobuz-player/PKGBUILD
+++ updated-qobuz-player/PKGBUILD
@@ -1,5 +1,5 @@
 pkgname=qobuz-player
-pkgver=0.4.3
+pkgver=0.4.4_1
 pkgrel=1
 pkgdesc="High resolution audio player backed by Qobuz"
 arch=('x86_64')
@@ -8,12 +8,13 @@ license=('GPL-3')
 conflicts=('qobuz-player-git')
 depends=(alsa-lib)
 makedepends=(cargo nodejs npm alsa-lib)
-source=("qobuz-player-${pkgver}.tar.gz::https://github.com/SofusA/qobuz-player/archive/refs/tags/v${pkgver}.tar.gz")
-sha256sums=('f97a59921c53da3bfea7d0b8d7be28dece6a003d10f4f7401a3a8fd054f1c0ed')
+_release_version="0.4.4-1"
+source=("qobuz-player-${pkgver}.tar.gz::https://github.com/SofusA/qobuz-player/archive/refs/tags/v${_release_version}.tar.gz")
+sha256sums=('d4df1db8dcca6454c3beb86c7cee9401f2c76cfe16044b2bef814c6880109532')
 options=('!lto')

 prepare() {
-    cd ${pkgname}-${pkgver}
+    cd ${pkgname}-${_release_version}
     export RUSTUP_TOOLCHAIN=stable
     cargo fetch --locked --target "$(rustc -vV | sed -n 's/host: //p')"
     cd qobuz-player-web
@@ -21,7 +22,7 @@ prepare() {
 }

 build() {
-    cd ${pkgname}-${pkgver}
+    cd ${pkgname}-${_release_version}
     export RUSTUP_TOOLCHAIN=stable
     export CARGO_TARGET_DIR=target
     #refuses to work with clang
@@ -36,6 +37,6 @@ build() {
 }

 package() {
-    cd ${pkgname}-${pkgver}
+    cd ${pkgname}-${_release_version}
     install -Dm0755 -t "$pkgdir/usr/bin/" "target/release/$pkgname"
 }

@yozi Thank you! Added it to the dependencies

The build() step failed for me (see error message below) when running in a clean chroot so I added "alsa-lib" as a makedepend and that let me build it successfully. It may need to be in the 'depend' array as well. I didn't test that.

Here's the error message I got:

   Compiling flume v0.11.1
   Compiling simd-adler32 v0.3.7
error: failed to run custom build command for `alsa-sys v0.3.1`

Caused by:
  process didn't exit successfully: `/build/qobuz-player/src/qobuz-player-0.4.2/target/release/build/alsa-sys-590b49275f448120/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-env-changed=ALSA_NO_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG
  cargo:rerun-if-env-changed=ALSA_STATIC
  cargo:rerun-if-env-changed=ALSA_DYNAMIC
  cargo:rerun-if-env-changed=PKG_CONFIG_ALL_STATIC
  cargo:rerun-if-env-changed=PKG_CONFIG_ALL_DYNAMIC
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR

  --- stderr

  thread 'main' panicked at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/alsa-sys-0.3.1/build.rs:13:18:

  pkg-config exited with status code 1
  > PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 pkg-config --libs --cflags alsa

  The system library `alsa` required by crate `alsa-sys` was not found.
  The file `alsa.pc` needs to be installed and the PKG_CONFIG_PATH environment variable must contain its parent directory.
  The PKG_CONFIG_PATH environment variable is not set.

  HINT: if you have installed the library, try setting PKG_CONFIG_PATH to the directory containing `alsa.pc`.

  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
==> ERROR: A failure occurred in build().
    Aborting...

Thank you for the update, much appreciated.

@moystard , Thank you! I personally don't use the web UI so did not really notice it. I added the fixes!

Hello,

Thank you for the package. I noticed that the CSS stylesheet is not built making the web player unusable. I suggest the following modifications to the PKGBUILD:

Add nodejs and npm in the build dependencies: -makedepends=(cargo) +makedepends=(cargo nodejs npm)

Build the stylesheet: + cd qobuz-player-web + npm install + npm run build

I tested locally and it works perfectly. I want to avoid having a duplicate package for qobuz-player, so it's best if those are merged in yours.

Thank you.