Package Details: qt5-styleplugins-git r36-1

Git Clone URL: https://aur.archlinux.org/qt5-styleplugins-git.git (read-only)
Package Base: qt5-styleplugins-git
Description: Additional style plugins for Qt5
Upstream URL: https://code.qt.io/cgit/qt/qtstyleplugins
Licenses: LGPL
Conflicts: qt5-styleplugins
Provides: qt5-styleplugins
Submitter: xduugu
Maintainer: nfnty
Last Packager: nfnty
Votes: 9
Popularity: 0.201219
First Submitted: 2016-06-25 09:41
Last Updated: 2017-07-17 14:26

Required by (4)

Sources (1)

Pinned Comments

nfnty commented on 2016-06-25 11:13

Issues and pull requests at https://github.com/nfnty/pkgbuilds

Latest Comments

« First ‹ Previous 1 2

xduugu commented on 2016-06-25 12:13

> `srcname` is used in all my packages, and IMO should be used in makepkg as well, but that is another issue.

But it still does not comply with the packaging standard. The reasons, why custom variables should be prefixed with an underscore, is to avoid collisions with makepkg's internal variables. Since they are not namespaced, it can has unforeseeable effects if makepkg uses an internal variable with the name srcname at some point.

> This is by far the most precise and KISS way of specifying git versions.

Actually not, because I cannot simply say if a git package is older or newer than another (stable) package. Also, versioned dependencies do not work, when the version is just the revision number. This package currently cannot satisfy a dependency

depends=('qt5-styleplugins>=5.0.0')

because it cannot provide

provides=("qt5-styleplugins=$pkgver").

nfnty commented on 2016-06-25 11:13

Issues and pull requests at https://github.com/nfnty/pkgbuilds

nfnty commented on 2016-06-25 10:29

@xduugu:

`srcname` is used in all my packages, and IMO should be used in makepkg as well, but that is another issue.

This is by far the most precise and KISS way of specifying git versions.

Having libx11 in dependencies is a form of documentation and a way of making sure it always is satisfied due to it being hard coded into the build scripts.

xduugu commented on 2016-06-25 10:15

Some more improvements:
- Please fix the package version. It should contain the latest tag name (see /usr/share/pacman/PKGBUILD-vcs.proto). My PKGBUILD already set the correct version, which is currently 5.0.0.r7.5f2549b:

pkgver() {
cd "$_pkgname"
printf "%s" "$(git describe --long | sed 's/^v//;s/\([^-]*-\)g/r\1/;s/-/./g')"
}


- Remove libx11 from dependencies. It's already required by gtk2. See namcap's output:

qt5-styleplugins-git W: Dependency libx11 included but already satisfied