Arch Linux User Repository

implemented the changes and added you as CoMaintainer

Ello, I did a small review since I am switching to this from bless (and I will very likely adopt this package when the licensing is solved):

• (!) Do not skip checksum for the package source
• Do not patch things downstream if it can be avoided, especially not in a way that breaks things, your desktop file patch fails desktop-file-validate because you made up a new field - I've sent a patch instead that achieves what you intended to do - https://github.com/solemnwarning/rehex/pull/286
• Use SPDX names for the license field
• Please add a package license, pkgctl license setup should do, see https://rfc.archlinux.page/0040-license-package-sources/
• The description should say macOS instead of Mac - https://github.com/solemnwarning/rehex/pull/285

Feel free to add me as a Co-Maintainer here and on rehex-git if you wish.

It's not neccessary to build botan2 from AUR, botan (version 3) from the repos is also supported since https://github.com/solemnwarning/rehex/commit/77fe9c22460caf350c9015e8e3292ff97e3493b0

Hi

Am seeing this in my build environment:

==> ERROR: Cannot find the git package needed to handle git sources.

Adding git to makedepends allows the build to proceed :)

Version 0.63.0 build fails with an src/buffer.hpp:101:30: error: ‘condition_variable’ in namespace ‘std’ does not name a type error due to missing #include <condition_variable> in "buffer.hpp".

Patch ("buffer.patch"):

diff -ura src/rehex-0.63.0/src/buffer.hpp fix/rehex-0.63.0/src/buffer.hpp
--- src/rehex-0.63.0/src/buffer.hpp 2025-07-25 20:16:42.382949980 +0000
+++ fix/rehex-0.63.0/src/buffer.hpp 2025-07-25 20:09:27.728013966 +0000
@@ -19,6 +19,7 @@
 #define REHEX_BUFFER_HPP

 #include <atomic>
+#include <condition_variable>
 #include <mutex>
 #include <string>
 #include <time.h>

PKGBUILD patch:

--- a/PKGBUILD  2025-07-25 21:01:14.520923151 +0000
+++ b/PKGBUILD  2025-07-25 21:02:22.644945368 +0000
@@ -11,12 +11,15 @@
 depends=('jansson' 'capstone' 'wxwidgets-gtk3' 'lua>=5.3' 'botan2')
 makedepends=('zip' 'perl-template-toolkit' 'busted')
 source=("$pkgname-$pkgver::git+https://github.com/solemnwarning/rehex.git#tag=$pkgver"
-        "rehex.patch")
+        "rehex.patch"
+        "buffer.patch")
 sha256sums=('SKIP'
-            '925aa979895253ba482780da91cb72fb11260dc44ce0a0f9650164f4831a5d83')
+            '925aa979895253ba482780da91cb72fb11260dc44ce0a0f9650164f4831a5d83'
+            'SKIP')

 build() {
   cd "$srcdir/$pkgname-$pkgver"
+  patch -p2 -i "$srcdir/buffer.patch"
   make prefix="/usr"
 }

The wxgtk3 package does not exist anymore, I replaced it locally with wxwidgets-gtk3, this seems to fix it.

version 0.61.0 depends on botan2, please add it to the dependencies. Thanks!

This package does not work since the latest wxwidgets changes: https://archlinux.org/news/wxwidgets-32-update-may-need-manual-intervention/

The following change fixes some issue (including the one by aquova), but I get some other issues still (see below)

diff --git a/PKGBUILD b/PKGBUILD
index 771cbb1..0ff90f5 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -8,7 +8,7 @@ pkgdesc="A cross-platform (Windows, Linux, Mac) hex editor for reverse engineeri
 arch=('x86_64')
 url="https://github.com/solemnwarning/rehex"
 license=('GPL2')
-depends=('jansson' 'capstone' 'wxgtk3' 'lua>=5.3')
+depends=('jansson' 'capstone' 'wxwidgets-gtk3' 'lua>=5.3')
 makedepends=('zip' 'perl-template-toolkit' 'busted')
 source=("$pkgname-$pkgver.tar.gz::$url/archive/refs/tags/$pkgver.tar.gz" "rehex.patch")
 sha256sums=('eabe0a4dc9341f9d0cdd6845248f818e8bc3a828476c8928fcf26828d9d67985'
@@ -17,9 +17,6 @@ sha256sums=('eabe0a4dc9341f9d0cdd6845248f818e8bc3a828476c8928fcf26828d9d67985'
 build() {
   cd "$srcdir/$pkgname-$pkgver"

-  # gtk3 patch
-  sed -i -e 's/wx-config/wx-config-gtk3/g' Makefile
-  
   make prefix="/usr"
 }

Issues:

wxLua/modules/wxbind/src/wxadv_bind.cpp: In function ‘int wxLua_wxDataViewTreeStoreNode_GetIcon(lua_State*)’:
wxLua/modules/wxbind/src/wxadv_bind.cpp:10292:58: error: taking address of rvalue [-fpermissive]
10292 |     const wxIcon* returns = (const wxIcon*)&self->GetIcon();
      |                                             ~~~~~~~~~~~~~^~
wxLua/modules/wxbind/src/wxadv_bind.cpp: In function ‘int wxLua_wxDataViewTreeStoreContainerNode_GetExpandedIcon(lua_State*)’:
wxLua/modules/wxbind/src/wxadv_bind.cpp:10527:66: error: taking address of rvalue [-fpermissive]
10527 |     const wxIcon* returns = (const wxIcon*)&self->GetExpandedIcon();
      |                                             ~~~~~~~~~~~~~~~~~~~~~^~
wxLua/modules/wxbind/src/wxadv_bind.cpp: In function ‘int wxLua_wxDataViewTreeStore_GetItemExpandedIcon(lua_State*)’:
wxLua/modules/wxbind/src/wxadv_bind.cpp:10872:70: error: taking address of rvalue [-fpermissive]
10872 |     const wxIcon* returns = (const wxIcon*)&self->GetItemExpandedIcon(*item);
      |                                             ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
wxLua/modules/wxbind/src/wxadv_bind.cpp: In function ‘int wxLua_wxDataViewTreeStore_GetItemIcon(lua_State*)’:
wxLua/modules/wxbind/src/wxadv_bind.cpp:10890:62: error: taking address of rvalue [-fpermissive]
10890 |     const wxIcon* returns = (const wxIcon*)&self->GetItemIcon(*item);
      |                                             ~~~~~~~~~~~~~~~~~^~~~~~~
wxLua/modules/wxbind/src/wxadv_bind.cpp: In function ‘int wxLua_wxDataViewIconText_GetIcon(lua_State*)’:
wxLua/modules/wxbind/src/wxadv_bind.cpp:16120:58: error: taking address of rvalue [-fpermissive]
16120 |     const wxIcon* returns = (const wxIcon*)&self->GetIcon();
      |                                             ~~~~~~~~~~~~~^~