Arch Linux User Repository

Hello,

Anyone have access to AUR, can anyone consider adding "-DRS_SETID=OFF" to pkgbuild for replay-sorcery.

https://aur.archlinux.org/packages/replay-sorcery/

There is a security bug related to setuid, and it should be disabled.

https://www.openwall.com/lists/oss-security/2021/02/10/1

https://bugzilla.suse.com/show_bug.cgi

-from: https://www.reddit.com/r/archlinux/comments/lgvtep/anyone_have_access_to_aur_consider_adding_drs/

@matanui159 The benefits is that the downloading is handled by makepkg and is cached, and won't have to be re-downloaded every single time wasting bandwidth, time and SSD cycles.

@katt would you be able to open a PR on the source repo? https://github.com/matanui159/ReplaySorcery

Also what are the benefits of handling submodules in this way? I would prefer if it used the exact version from the repo instead and it just overall seems more verbose.

Took the liberty of cleaning this PKGBUILD up.

• Fixed dependencies (failed to build otherwise)
• Fixed sources https://wiki.archlinux.org/index.php/VCS_package_guidelines#Git_submodules

diff --git a/PKGBUILD b/PKGBUILD
index 84ce555..0a8d6ba 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -3,26 +3,38 @@ pkgver=0.2.6
 pkgrel=1
 pkgdesc="An open-source, instant-replay screen recorder for Linux"
 arch=("i686" "x86_64")
-license=("GPL-3.0")
-makedepends=("cmake" "make" "git" "pkg-config" "nasm")
+license=("GPL3")
+depends=("gcc-libs" "libxext")
+makedepends=("cmake" "git" "nasm")
 url="https://github.com/matanui159/ReplaySorcery"
-source=("${pkgname}::git+${url}.git#tag=${pkgver}")
-sha256sums=("SKIP")
+source=("${pkgname}::git+${url}.git#tag=${pkgver}"
+        "git+https://github.com/libjpeg-turbo/libjpeg-turbo.git"
+        "git+https://github.com/ianlancetaylor/libbacktrace.git"
+        "git+https://code.videolan.org/videolan/x264.git"
+        "git+https://github.com/lieff/minimp4.git")
+sha256sums=('SKIP'
+            'SKIP'
+            'SKIP'
+            'SKIP'
+            'SKIP')

 prepare() {
-   mkdir -p "${pkgname}/build"
-   git -C "${pkgname}" submodule update --init --recursive --depth=1
+   cd ${pkgname}
+   git submodule init
+   git config submodule."dep/libjpeg-turbo".url ../libjpeg-turbo
+   git config submodule."dep/libbacktrace".url ../libbacktrace
+   git config submodule."dep/x264".url ../x264
+   git config submodule."dep/minimp4".url ../minimp4
+   git submodule update
 }

 build() {
-   cd "${pkgname}" || exit 1
-   cmake -B build \
+   cmake -B build -S "${pkgname}" \
       -DCMAKE_BUILD_TYPE=Release \
       -DCMAKE_INSTALL_PREFIX=/usr
-   make -C build
+   cmake --build build
 }

 package() {
-   cd "${pkgname}" || exit 1
-   make -C build DESTDIR=${pkgdir} install
+   DESTDIR="${pkgdir}" cmake --install build
 }