Package Details: roundcubemail-git 1.5rc.r105.g16c2a76fe-1

Git Clone URL: https://aur.archlinux.org/roundcubemail-git.git (read-only, click to copy)
Package Base: roundcubemail-git
Description: A PHP web-based mail client
Upstream URL: https://roundcube.net/
Licenses: GPL
Conflicts: roundcubemail
Provides: roundcubemail
Submitter: cgirard
Maintainer: cgirard
Last Packager: cgirard
Votes: 1
Popularity: 0.000112
First Submitted: 2018-11-05 14:32 (UTC)
Last Updated: 2021-08-31 15:07 (UTC)

Dependencies (11)

Required by (20)

Sources (2)

Pinned Comments

cgirard commented on 2021-07-12 14:14 (UTC)

Please note that with today change, for people pushing the built package to a (local) repo, it will probably not be automatically updated as 1.5rc.rx < 1.5.rc.rx.

Latest Comments

cgirard commented on 2021-08-31 15:08 (UTC)

@Rapti: this was taken from this [1], but looking at what is in the release archive, it seems indeed this is not needed.

[1] https://github.com/roundcube/roundcubemail/wiki/Build-from-source#6-remove-development-stuff-installer-and-git-files

Rapti commented on 2021-08-28 11:55 (UTC)

This package is not suitable as-is for first-time installs because the PKGBUILD removes the installer directory. Anyone planning to do a first-time setup should locate the line rm -rf tests/ public_html/ installer/ .tx* in the PKGBUILD and adjust it accordingly.

crt commented on 2021-08-14 00:32 (UTC)

@alerque, thanks! I started over with npm and the build succeeded this time. Cheers.

alerque commented on 2021-08-08 07:29 (UTC)

@crt I just checked this package by building it in a clean chroot with only the dependencies specified and it worked fine. I think you might be missing some of the dependencies, or perhaps have the packages but older versions of them from when they were broken at some point. Try rebuilding and installing the dependencies before trying this again.

Also you'll find relatively current builds in my user repository that can be installed with pacman directly with no building required. I do run this -git version in production so the builds I use at any given time are hosted there.

crt commented on 2021-08-08 00:04 (UTC)

Fails on package()

==> Starting package()...
npm ERR! semver.simplifyRange is not a function

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/me/.cache/yay/nodejs-less-plugin-clean-css/src/npm-cache/_logs/2021-08-08T00_02_15_742Z-debug.log
==> ERROR: A failure occurred in package().
    Aborting...
error: target not found: nodejs-less-plugin-clean-css
error: target not found: nodejs-csso
error: target not found: nodejs-csso-cli

cgirard commented on 2021-07-12 14:14 (UTC)

Please note that with today change, for people pushing the built package to a (local) repo, it will probably not be automatically updated as 1.5rc.rx < 1.5.rc.rx.

alerque commented on 2021-07-10 07:43 (UTC)

Hey @cgirard can you please fix the versioning on this package? It is going to break for anybody that is using it after the final version comes out, and the closer we get to that release cycle the more people are going to use it. There is now an RC release upstream.

If it makes any difference I'm now wearing a TU hat, so when I say this is wrong maybe that carries a little more weight.

For convenience I've updated my patch to catch the case of RCs too so you can apply this easily using git am < patch

From 020ea787ae5318c185680a8add84f19d02c33544 Mon Sep 17 00:00:00 2001
From: Caleb Maclennan <caleb@alerque.com>
Date: Tue, 1 Jun 2021 22:10:25 +0300
Subject: [PATCH] Fix versioning so releases will be newer than betas/rcs

Signed-off-by: Caleb Maclennan <caleb@alerque.com>
---
 .SRCINFO | 3 +--
 PKGBUILD | 5 +++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/.SRCINFO b/.SRCINFO
index e535845..189d32a 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -1,6 +1,6 @@
 pkgbase = roundcubemail-git
    pkgdesc = A PHP web-based mail client
-   pkgver = 1.4.rc2.r702.ga0fbcf381
+   pkgver = 1.5rc.r12.gd0eb1ee
    pkgrel = 1
    url = https://roundcube.net/
    arch = any
@@ -26,4 +26,3 @@ pkgbase = roundcubemail-git
    sha256sums = c90981405527ebaf153a407af6b8178b41d078bd4472d63b837b3b4cd5ae36b0

 pkgname = roundcubemail-git
-
diff --git a/PKGBUILD b/PKGBUILD
index 086ce5b..32bd3bd 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -2,7 +2,7 @@
 # Contributor: Sergej Pupykin <pupykin.s+arch@gmail.com>

 pkgname=roundcubemail-git
-pkgver=1.4.rc2.r702.ga0fbcf381
+pkgver=1.5rc.r12.gd0eb1ee
 pkgrel=1
 pkgdesc="A PHP web-based mail client"
 arch=('any')
@@ -21,7 +21,8 @@ sha256sums=('SKIP'

 pkgver() {
   cd "roundcubemail"
-  git describe --long | sed 's/\([^-]*-g\)/r\1/;s/-/./g'
+  git describe --long --tags --abbrev=7 HEAD |
+    sed 's/-\(beta\|rc\)/\1/g;s/\([^-]*-g\)/r\1/;s/-/./g'
 }

 prepare() {
-- 
2.32.0

alerque commented on 2021-05-19 13:52 (UTC) (edited on 2021-05-19 13:56 (UTC) by alerque)

@cgirard That is because you are assuming they will tag with X.Y.0. If they tag with 1.5 instead of 1.5.0 then you'll see vercmp won't register the right direction. This is documented in the wiki and vercmp man pages, the correct way to do it is with no segment separator before suffixes like "pre", "beta", etc. Otherwise they will not be considered as adding meaning to the previous segments but as segments of their own --- which will often sort them incorrectly.

cgirard commented on 2021-05-19 13:06 (UTC)

Hi,

I am not sure what you mean:

# vercmp 1.5.0 1.5.beta.r86.gbf2c4f32e-1
1

alerque commented on 2021-05-19 11:59 (UTC) (edited on 2021-06-01 19:11 (UTC) by alerque)

The pkgver() function is broken because it's allowing beta version tags upstream that are not a valid format for PKGBUILD files that will end up being newer than the final release tags. It can be fixed like this (apply with git am < file.patch):

From 16aeb5032a5430795601d561f3d1f719dc0e02df Mon Sep 17 00:00:00 2001
From: Caleb Maclennan <caleb@alerque.com>
Date: Tue, 1 Jun 2021 22:10:25 +0300
Subject: [PATCH] Fix versioning so releases will be newer than betas

Signed-off-by: Caleb Maclennan <caleb@alerque.com>
---
 .SRCINFO | 3 +--
 PKGBUILD | 5 +++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/.SRCINFO b/.SRCINFO
index e535845..85b6cde 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -1,6 +1,6 @@
 pkgbase = roundcubemail-git
    pkgdesc = A PHP web-based mail client
-   pkgver = 1.4.rc2.r702.ga0fbcf381
+   pkgver = 1.5beta.r100.ge62c0a8
    pkgrel = 1
    url = https://roundcube.net/
    arch = any
@@ -26,4 +26,3 @@ pkgbase = roundcubemail-git
    sha256sums = c90981405527ebaf153a407af6b8178b41d078bd4472d63b837b3b4cd5ae36b0

 pkgname = roundcubemail-git
-
diff --git a/PKGBUILD b/PKGBUILD
index 086ce5b..5891672 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -2,7 +2,7 @@
 # Contributor: Sergej Pupykin <pupykin.s+arch@gmail.com>

 pkgname=roundcubemail-git
-pkgver=1.4.rc2.r702.ga0fbcf381
+pkgver=1.5beta.r100.ge62c0a8
 pkgrel=1
 pkgdesc="A PHP web-based mail client"
 arch=('any')
@@ -21,7 +21,8 @@ sha256sums=('SKIP'

 pkgver() {
   cd "roundcubemail"
-  git describe --long | sed 's/\([^-]*-g\)/r\1/;s/-/./g'
+  git describe --long --tags --abbrev=7 HEAD |
+    sed 's/-beta/beta/g;s/\([^-]*-g\)/r\1/;s/-/./g'
 }

 prepare() {
-- 
2.31.1

cgirard commented on 2021-05-15 16:22 (UTC)

Adopted and corrected nodejs-clean-css

cgirard commented on 2021-05-15 16:14 (UTC)

Understood. I was using packages built a long time ago of those nodejs modules (as they have not been updated, it did not triggered a rebuild). On those version, no root module was included.

I have corrected nodejs-less PKGBUILD which should correct for that package anyway. If you still see issues with nodejs-clean-css or nodejs-less-plugin-clean-css, please comment on those packages as the owner has no way to learn about it else.

corecode commented on 2021-05-15 15:59 (UTC)

the problem isn't in roundcubemail-git, it's in nodejs-clean-css and nodejs-less (latest from AUR) containing conflicting files in /usr/lib/node_modules/root:

10:56:30 ernest:~/.cache/yay/nodejs-less master 
% pacman -Qlp nodejs-less-4.1.1-1-any.pkg.tar.xz|grep /usr/lib/node_modules/root|wc -l
64

I'm guessing it is some obscure build issue with those two packages (npm?) which makes the install dir include files it shouldn't contain.

cgirard commented on 2021-05-15 15:23 (UTC)

@corecode: I don't understant what you are talking about:

$ pacman -Qlp nodejs-clean-css-4.2.1-1-any.pkg.tar.zst | grep /usr/lib/node_modules/root
$ pacman -Qlp nodejs-less-4.1.1-1-any.pkg.tar.zst | grep /usr/lib/node_modules/root
$ pacman -Qlp nodejs-less-plugin-clean-css-1.5.1-1-any.pkg.tar.zst | grep /usr/lib/node_modules/root
$

I am rebuilding each day roundcubemail-git on a clean chroot without any problem (repo available here: https://arch-repos.valinor.fr/cgirard if you need it).

corecode commented on 2021-05-14 14:15 (UTC)

nodejs-less-plugin-clean-css requires both nodejs-less and nodejs-clean-css, both of which install conflicting files in /usr/lib/node_modules/root. This conflict breaks build of roundcubemail-git.

cgirard commented on 2021-05-05 12:26 (UTC) (edited on 2021-05-05 12:34 (UTC) by cgirard)

What do you mean by

Additionally the current build depends on a duplicate package with a bad name that installs conflicting files with another package (nodejs-clean-css vs. nodejs-less-plugin-clean-css). Those have two different upstreams with unrelated versions.

Did you notice anything specific on upcoming 1.5 release? I have everything building and working fine with latest HEAD and do not see any notable change in instructions that I did not already applied.

alerque commented on 2021-05-03 09:13 (UTC)

There are quite a few build chain changes in the upcoming 1.5 release. Additionally the current build depends on a duplicate package with a bad name that installs conflicting files with another package (nodejs-clean-css vs. nodejs-less-plugin-clean-css). Could this be updated to build cleanly for the current dependencies?

kang commented on 2021-03-14 22:54 (UTC)

atm nodejs-clean-css conflicts with nodejs-less