Arch Linux User Repository

@codyps You can do what the valgrind maintainer did [1], add !strip to options and add

if check_option 'debug' n; then
  find "${pkgdir}/usr/bin" -type f -executable -exec strip $STRIP_BINARIES {} + || :
fi

to package()

1: https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/valgrind

@codyps: librrpreload.so must not be stripped, or you get incorrect backtraces while replaying. If there's a way to only avoid stripping librrpreload.so, that would work.

Hi @daurnimator, thanks for pointing that out. I've dropped that dependency in rev 4.

rr should no longer need the python2 dependency (via python2-pexpect). It's the only thing left on my system keeping python2 installed.

Hi @Amanieu: while that could certainly be added to the PKGBUILD, it isn't entirely clear to me that this is the right thing to do: generally, one would modify the options=() via makepkg.conf to adjust behavior on one's own system.

Is there some reason librrprepload.so should be treated specially?

Can you add options=(!strip) so that we can get proper backtraces from librrpreload.so?

Getting:

.cache/yay/rr/src/rr-5.2.0/src/kernel_abi.cc:54:17: error: static assertion failed: type ::ucontext_t not correctly defined
   static_assert(Verifier<arch_, system_type_, rr_type_>::same_size,            \
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/pmatos/.cache/yay/rr/src/rr-5.2.0/src/kernel_abi.h:1813:3: note: in expansion of macro ‘RR_VERIFY_TYPE_ARCH’
   RR_VERIFY_TYPE_ARCH(SupportedArch::x86_64, ::ucontext_t, ucontext_t);
   ^~~~~~~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/rr.dir/build.make:413: CMakeFiles/rr.dir/src/kernel_abi.cc.o] Error 1

during build with gcc8

Missing dependency lib32-gcc-libs

for the cross-compile-toolchain

Here's a patch that fixes a bunch of build/install issues with the pkgbuild:

(right now it fails to build, and then fails to install on current archlinux. please apply this fix)

From 498b62863b068be5bf8b647e53b6ffe23a4ab92c Mon Sep 17 00:00:00 2001
From: Cody Schafer <dev@codyps.com>
Date: Tue, 6 Nov 2018 14:12:46 -0500
Subject: [PATCH] fix build

 - add patch for ucontext build failure from upstream
 - define CXX standard 14
 - set libdir as `lib` to avoid use of `lib64`
---
 .SRCINFO |  7 ++++---
 PKGBUILD | 20 ++++++++++++++++----
 2 files changed, 20 insertions(+), 7 deletions(-)

diff --git a/.SRCINFO b/.SRCINFO
index 63c7f2a..b137073 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -1,9 +1,7 @@
-# Generated by mksrcinfo v8
-# Mon May 28 00:53:20 UTC 2018
 pkgbase = rr
    pkgdesc = Record and Replay framework: lightweight recording and deterministic debugging
    pkgver = 5.2.0
-   pkgrel = 1
+   pkgrel = 2
    url = http://rr-project.org/
    arch = i686
    arch = x86_64
@@ -11,11 +9,14 @@ pkgbase = rr
    makedepends = git
    makedepends = cmake
    makedepends = gdb
+   makedepends = gcc-multilib
    depends = python2-pexpect
    depends = gdb
    depends = capnproto
    source = https://github.com/mozilla/rr/archive/5.2.0.tar.gz
+   source = https://github.com/mozilla/rr/commit/53c5bd72bae089616a3ca626b8af240481d70e6f.patch
    sha1sums = 55040be15a87dd93012d7cdbeb8a3fc428ea4b6b
+   sha1sums = 9fcafcc3f4474b4352402b39002869a51e77f6df

 pkgname = rr

diff --git a/PKGBUILD b/PKGBUILD
index e32fa8f..43ed499 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -3,7 +3,7 @@

 pkgname=rr
 pkgver=5.2.0
-pkgrel=1
+pkgrel=2
 pkgdesc='Record and Replay framework: lightweight recording and deterministic debugging'
 arch=(i686 x86_64)
 url='http://rr-project.org/'
@@ -11,17 +11,29 @@ license=('custom')
 depends=('python2-pexpect' 'gdb' 'capnproto')
 makedepends=('git' 'cmake' 'gdb')
 [ "$CARCH" = 'x86_64' ] && makedepends+=('gcc-multilib')
-source=(https://github.com/mozilla/${pkgname}/archive/${pkgver}.tar.gz)
-sha1sums=('55040be15a87dd93012d7cdbeb8a3fc428ea4b6b')
+source=(
+   https://github.com/mozilla/${pkgname}/archive/${pkgver}.tar.gz
+   https://github.com/mozilla/rr/commit/53c5bd72bae089616a3ca626b8af240481d70e6f.patch
+)
+sha1sums=('55040be15a87dd93012d7cdbeb8a3fc428ea4b6b'
+          '9fcafcc3f4474b4352402b39002869a51e77f6df')

 prepare() {
    cd $pkgname-$pkgver
    mkdir -p build
+   patch -Np1 -i "$srcdir/53c5bd72bae089616a3ca626b8af240481d70e6f.patch"
 }

 build() {
    cd $pkgname-$pkgver/build
-   cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX:PATH=/usr -DBUILD_TESTS=OFF -DWILL_RUN_TESTS=OFF ..
+   cmake \
+       -DCMAKE_BUILD_TYPE=RelWithDepInfo \
+       -DCMAKE_INSTALL_PREFIX:PATH=/usr \
+       -DBUILD_TESTS=OFF \
+       -DWILL_RUN_TESTS=OFF \
+       -DCMAKE_INSTALL_LIBDIR=lib \
+       -DCMAKE_CXX_STANDARD=14 \
+       ..

    make
 }
-- 
2.19.1