Package Details: rssguard 3.5.5-1

Git Clone URL: https://aur.archlinux.org/rssguard.git (read-only)
Package Base: rssguard
Description: A simple (yet powerful) Qt5 feed reader.
Upstream URL: https://github.com/martinrotter/rssguard/
Licenses: GPL3
Submitter: speps
Maintainer: WorMzy
Last Packager: WorMzy
Votes: 29
Popularity: 0.822683
First Submitted: 2014-04-14 19:05
Last Updated: 2017-11-21 19:16

Dependencies (4)

Required by (0)

Sources (1)

Latest Comments

skunkos commented on 2017-10-25 04:42

Makes sense. :)

WorMzy commented on 2017-10-24 22:46

Oops, I meant to remove the optdepend. Thanks for pointing that out.

My reasoning for adding it as a hard dependency is that it's a compile-time option that defaults to true if it's detected. People who build in clean chroots, or people who use makepkg on a system with webengine not present would not get the added functionality if they installed webengine after the fact, which makes the optdepend misleading imo. Makepkg users would need to recompile, clean chroot users would need to edit the PKGBUILD as I have.

skunkos commented on 2017-10-24 11:04

WorMzy: Just noting, why do you add qt5-webengine as hard dependency, if you have already that package as optional dependency?

skunkos commented on 2017-10-16 08:50

Also, localization binary files are now compiled directly into executable file as Qt resource. There is a problem that on some platforms, binary localization files are generated by qmake too late and they are not included in compilation, so you see errors like this - https://travis-ci.org/martinrotter/rssguard/jobs/287540984#L624

To fix that, it is good to run qmake step twice (first generates localizations too late and does not include them in make step, second run fixes make files) like this - https://github.com/martinrotter/rssguard/blob/master/resources/scripts/.travis-install-linux.sh#L8

skunkos commented on 2017-10-16 08:46

Theoretically INSTALL_ROOT should be honored, but not sure how the final paths would end up. The "install" section in rssguard.pro installs all files into $PREFIX/usr/bin.... $PREFIX/usr/share/.....

INSTALL_ROOT variable is still honored and prepended to these paths by make ($INSTALL_ROOT/$PREFIX/usr/share/.....), the thing is that from 3.5.1 default value of $PREFIX is tweaked a bit by rssguard.pro you might try out:

1. Keeping your current PKGBUILD and it should probably work, because I see that you override PREFIX variable. In this case final paths during make install are "$INSTALL_ROOT/$PREFIX/..." --> "$pkgdir/usr/...".
2. You can abandon INSTALL_ROOT and leave it empty and set PREFIX directly to "$pkgdir/usr/.." in that case the substitution in make install would be "$INSTALL_ROOT/$PREFIX/..." --> "$pkgdir/usr/...".

So in the end, the finally substituted paths will be the same, but in case 1, you use two variables, in case 2 you use 1 variable. Your choice.

WorMzy commented on 2017-10-16 08:35

Thanks for the heads up, sorry about missing your qmake comment back in January (!!), I'll clean that up when I next update the PKGBUILD.

PREFIX will really need $pkgdir in it? Or will INSTALL_ROOT still be honored in package()?

skunkos commented on 2017-10-16 04:38

Starting from 3.5.1, your "make" part of PKGBUILD won't probably work. Use this code snippet instead:

qmake ../rssguard.pro -r CONFIG+=release PREFIX=$pkgdir/usr LRELEASE_EXECUTABLE=lrelease-qt5

make

skunkos commented on 2017-01-31 13:18

Note that compilation line with qmake can be simplified a bit.

See this: https://build.opensuse.org/package/view_file/home:skunkos:rssguard/rssguard-git/PKGBUILD?expand=1

WorMzy commented on 2017-01-31 12:57

Great, I've adopted the package and pushed 3.3.7. :)

skunkos commented on 2017-01-31 05:12

Unowned. :) I don't have time to maintain version on AUR, I care about proper GitHub releases. :)

All comments