Package Details: samrewritten-git 1.4.1.r0.g4953d56-1

Git Clone URL: https://aur.archlinux.org/samrewritten-git.git (read-only, click to copy)
Package Base: samrewritten-git
Description: Unlock achievements and stats on Steam, and more!
Upstream URL: https://github.com/PaulCombal/SamRewritten
Keywords: achievement manager rewritten sam steam
Licenses: GPL-3.0-only
Conflicts: samrewritten
Provides: samrewritten
Submitter: None
Maintainer: JudgeManganese (nomis6432, yhu420)
Last Packager: yhu420
Votes: 31
Popularity: 0.30
First Submitted: 2019-10-21 00:40 (UTC)
Last Updated: 2026-06-05 15:20 (UTC)

Dependencies (6)

Required by (0)

Sources (1)

Latest Comments

1 2 3 4 Next › Last »

yhu420 commented on 2026-06-05 15:21 (UTC)

Right, I've reverted it. Thanks for the info

IThundxr commented on 2026-06-05 01:59 (UTC) (edited on 2026-06-05 01:59 (UTC) by IThundxr)

The latest change that adds a dependency on rust 1.95 or newer breaks builds on systems that use rustup due to rustup providing rust but having a different versioning system.

-> pacman -Qi rustup
| Name            : rustup
| Version         : 1.29.0-2
| Description     : The Rust toolchain installer
| ...
| Provides        : rust  cargo  rust-nightly  cargo-nightly  rustfmt  rust-src
|                   lib32-rust-libs  rust-musl  rust-wasm  rust-analyzer
| ...

-> cargo --version
| cargo 1.95.0 (f2d3ce0bd 2026-03-21)

-> rustup --version
| rustup 1.29.0 (2026-03-23)
| info: This is the version for the rustup toolchain manager, not the rustc compiler.
| info: the currently active `rustc` version is `rustc 1.95.0 (59807616e 2026-04-14)`

yhu420 commented on 2026-06-04 22:02 (UTC)

Yes, it should never happen in practice anyway, if the user wants to disable the translations, he/she can and I will not stop him/her. The app will still compile and run with the english language as default. If you think implementing the change is more in line with some guideline let me know. Feel free to join the maintainers if you're interested too

C0rn3j commented on 2026-06-03 23:06 (UTC)

Oh, I didn't know that about globs, thanks for the explanation.

Though, wouldn't you want the build to fail if there are no translation files for some reason, since the expected state is having them?

Otherwise you're just having that part silently fail without knowing about it.

yhu420 commented on 2026-06-03 21:57 (UTC)

you're right. regarding the loop the guard is not guaranteed true. In bash with nullglob off (the default, and makepkg doesn't enable it), a glob that matches nothing is left literal. So if locale//LC_MESSAGES/samrewritten.mo matches no files, the loop still runs once with $mo set to that literal unexpanded string. [ -e "$mo" ] is then false, so continue skips it. Without the guard, install would try to install a file literally named locale//... and fail the build.

C0rn3j commented on 2026-06-03 19:57 (UTC)

gettext is both in base and base-devel, there's no need to depend on it explicitly.

There's three maintainers but none of them are in the PKGBUILD header.

I don't get the point of this check, [ -e "$mo" ], isn't that already guaranteed to be true since $mo comes from a loop?

C0rn3j commented on 2026-01-15 11:13 (UTC)

You can now simply use cargo fetch --locked --target host-tuple in prepare()

C0rn3j commented on 2025-08-11 17:20 (UTC)

You should not be version bumping -git packages if you have no other changes - https://wiki.archlinux.org/title/Arch_User_Repository#Flagging_packages_out-of-date

https://aur.archlinux.org/cgit/aur.git/commit/?h=samrewritten-git&id=b206e1e7ac772e059cd8978b770e28e4cbc7e211

hashworks commented on 2025-08-03 11:57 (UTC)

Please add git as a makedep, otherwise this won't build in a chroot.

JudgeManganese commented on 2025-07-05 20:06 (UTC)

Apologies. I've updated it to the new upstream provided PKGBUILD.

With the new repo, the version has reset, so you'll likely need a clean install to get it installed. This will also have the side effect of not automatically installing the new version for folks who upgrade.

The new version should work with non-snap installs now as described on its wiki.