Package Details: seahub 11.0.8-1

Git Clone URL: https://aur.archlinux.org/seahub.git (read-only, click to copy)
Package Base: seahub
Description: The web frontend for seafile server
Upstream URL: https://github.com/haiwen/seahub
Licenses: Apache
Submitter: eolianoe
Maintainer: Joffrey
Last Packager: Joffrey
Votes: 7
Popularity: 0.000000
First Submitted: 2017-07-03 09:48 (UTC)
Last Updated: 2024-04-20 09:42 (UTC)

Pinned Comments

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 9 10 .. 12 Next › Last »

kuzalj commented on 2020-06-11 09:48 (UTC)

Not sure what I am doing wrong, but after running pacman and getting some python updates, I am getting an error on 7.1.4

TypeError at /
from_db_value() takes 4 positional arguments but 5 were given


Request Method: GET
Request URL:    https://x.com/
Django Version: 1.11.25
Exception Type: TypeError
Exception Value:    
from_db_value() takes 4 positional arguments but 5 were given
Exception Location: /srv/seafile/x.com/seafile-server/seahub/thirdpart/django/db/models/sql/compiler.py in apply_converters, line 832
Python Executable:  /usr/bin/python3
Python Version: 3.8.3
Python Path:    
['/usr/bin',
 '/srv/seafile/x.com/seafile-server/seafile/lib/python3.6/site-packages',
 '/srv/seafile/x.com/seafile-server/seafile/lib64/python3.6/site-packages',
 '/srv/seafile/x.com/seafile-server/seahub',
 '/srv/seafile/x.com/seafile-server/seahub/thirdpart',
 '/srv/seafile/x.com/seafile-server',
 '/usr/lib/python38.zip',
 '/usr/lib/python3.8',
 '/usr/lib/python3.8/lib-dynload',
 '/usr/lib/python3.8/site-packages',
 '/srv/seafile/x.com/seafile-server/seahub/seahub/api2/endpoints/../../../../../conf',
 '/srv/seafile/x.com/seafile-server/seahub/seahub/api2/endpoints/../../../../../conf']

yuyichao commented on 2020-03-29 12:35 (UTC)

Yes, either of the change should be enough to fix the issue.

Joffrey commented on 2020-03-29 10:55 (UTC)

@yuyichao, I have make a test and I think this patch is enough :

- <form action="{% url view_name token %}?p={{ path }}" method="post" id="share-passwd-form">
+ <form action="{% url view_name token %}?p=/{{ path }}" method="post" id="share-passwd-form">

Thanks for debugging.

yuyichao commented on 2020-03-29 01:41 (UTC)

Glad it works.

DanSman commented on 2020-03-29 01:11 (UTC)

..., you got the white space correct right?

Nah, you were right. That was wrong.

yuyichao commented on 2020-03-29 00:54 (UTC) (edited on 2020-03-29 00:54 (UTC) by yuyichao)

Oh, that repo.py. I thought you are talking about some code you use... Whatever....

Just to state the obvious (if you are a python users), if you applied the patch manually, you got the white space correct right?

The way I found the error last time was to just put something like a raise ValueError() in seahub/thirdpart/django/views/defaults.py at the beginning of server_error. That either cause the server to quite or otherwise cause a full backtrace to be printed. The message from there should tell you what kind of error you got. I don't really see how the new code, with the only addition beting basically a comparison to empty string, should cause and error in this case....

DanSman commented on 2020-03-29 00:29 (UTC)

Line 19/20
https://github.com/archlinuxcn/repo/blob/3844a0e73eff940e25e5d138f4d379d43ffbdb0a/archlinuxcn/seahub/fix_shared_link.patch
or
https://github.com/haiwen/seahub/issues/4440

Yeah, I don't know why the problem exists, I tested it before the update, after the update and after the patch. It only works with your patch.

yuyichao commented on 2020-03-29 00:21 (UTC)

What's repo.py?

Also see my comment in seafile-server about 7.1.3 though you should't have that problem if you've only upgraded seahub. (OTOH, I'm not sure if a version mismatch between seafile-server and seahub is well supported even though I've probably done it at 6.x time for minor/patch versions....)

DanSman commented on 2020-03-29 00:16 (UTC) (edited on 2020-03-29 00:17 (UTC) by DanSman)

Hey yuyichao

Thanks for the patch.

I have updated it manually, as I installed it, as I have described a few posts below. Well, I am on 7.1.3 and only changed the file share_access_validation.html with your patch. repo.py did not work and ends in Internal Server Error. Without repo it works.
Thanks

yuyichao commented on 2020-03-28 19:20 (UTC)

@DanSman https://github.com/haiwen/seahub/pull/4442

See also https://github.com/archlinuxcn/repo/blob/3844a0e73eff940e25e5d138f4d379d43ffbdb0a/archlinuxcn/seahub/PKGBUILD for the updated 7.1.3 PKGBUILD including the patch.