Package Details: sipvicious 0.2.8-2

Git Clone URL: https://aur.archlinux.org/sipvicious.git (read-only)
Package Base: sipvicious
Description: Tools for auditing SIP devices
Upstream URL: http://blog.sipvicious.org
Licenses: GPLv2
Conflicts: sipvicious-svn
Submitter: xdevla
Maintainer: xdevla
Last Packager: xdevla
Votes: 9
Popularity: 0.040155
First Submitted: 2011-04-01 08:40
Last Updated: 2017-12-04 10:03

Latest Comments

GI_Jack commented on 2017-12-04 17:12

Oh boy, looking at this PKGBUILD, there are a few things wrong:

  1. Tab indents, just no. please use 2 spaces for a step, 1 for half step.
  2. build() You are wrong on two accounts. Python does in fact compile to bytecode, and if there is no compilation, you can skip build() entirely
  3. Manpages are provided upstream, but not packaged correctly, so man cannot use them.
  4. using sha1sums=. SHA1 and MD5 are depreciated, and should be avoided, pls use sha256sums= or better in the future. sha256sums= has the added benefit of neatly fitting in the 80 character margins as well.
  5. .install file used per function global variables with the same name, and exactly same _pkgprogs=() array. Also used a hard to read bashism, when a simpler solution was at hand. In addition to tab stepping, you put do on the line after instead of a much easier to read ;do

I fixed all of these for you, pastes:

PKGBUILD: https://pastebin.com/K95F9x8r

.install: https://pastebin.com/1uK1qgN8

GI_Jack commented on 2017-12-03 18:24

Source is now on github

https://github.com/EnableSecurity/sipvicious/releases/tag/v0.2.8

Anonymous comment on 2013-01-22 22:45

You could of adopted and updated sipvicious-svn, instead of blatantly
ripping it without giving any credit.

By the way you need to fix sipvicious.install as pptable.py and svhelper.py
are now in the lib directory, they probably get referenced from elsewhere so
renaming them is a bad idea.. also regen.py, svfphelper.py and svlearnfp.py
no longer exist.