Thank you very much for your input @InfernoZeus. I'm new to AUR submissions, so thank you for pointing me in the right direction. I've updated the package to reflect the changes you suggested
Search Criteria
Package Details: spotify-adkiller 10-1
Package Actions
| Package Base: | spotify-adkiller |
|---|---|
| Description: | Your Party with Spotify - but without ads! |
| Upstream URL: | https://github.com/SecUpwN/Spotify-AdKiller |
| Category: | multimedia |
| Licenses: | |
| Submitter: | timidger |
| Maintainer: | timidger |
| Last Packager: | timidger |
| Votes: | 9 |
| First Submitted: | 2015-02-25 03:00 |
| Last Updated: | 2015-04-27 22:32 |
Latest Comments
Comment by timidger
Comment by InfernoZeus
This package doesn't follow Arch packaging standards at all. Here are some suggested fixes:
1) Remove empty variables such as "optdepends=()".
2) prepare() shouldn't affect the users filesystem. Remove "mkdir -p $HOME/bin".
3) Remove the git clone and replace the source=(..) with the git repository. See here for more info: https://wiki.archlinux.org/index.php/VCS_package_guidelines#VCS_sources
3) package() should create the package, not install the files directly to the users filesystem. Remove
install -Dm755 "$srcdir"/"$pkgname"/spotify-adkiller.sh $HOME/bin/spotify-adkiller.sh
and replace it with
install -Dm755 "$srcdir"/"$pkgname"/spotify-adkiller.sh "$pkgdir"/usr/bin/spotify-adkiller.sh
4) Copy the desktop file as suggested in Spotify-AdKiller's readme:
install -Dm644 "$srcdir"/"$pkgname"/"Spotify (AdKiller).desktop" "$pkgdir"/usr/share/applications/"Spotify (AdKiller).desktop"
Comment by timidger
Sorry about that, I'm a git. Fixed it by skipping the MD5sum.
Comment by fertorresf
It still shows a "Validating source files with md5sums ... master.tar.gz ... FAILED"
Comment by timidger
There we go, should be fixed now. Ironically, it changed because upstream they merged my changes that added this repo to their README
Comment by mareex
checksum fails