Package Details: spotify-adkiller 10-1

Package Base: spotify-adkiller
Description: Your Party with Spotify - but without ads!
Upstream URL: https://github.com/SecUpwN/Spotify-AdKiller
Category: multimedia
Licenses: GPL3
Submitter: timidger
Maintainer: timidger
Last Packager: timidger
Votes: 9
First Submitted: 2015-02-25 03:00
Last Updated: 2015-04-27 22:32

Dependencies (3)

Required by (0)

Sources

Latest Comments

Comment by timidger

2015-04-27 22:33

Thank you very much for your input @InfernoZeus. I'm new to AUR submissions, so thank you for pointing me in the right direction. I've updated the package to reflect the changes you suggested

Comment by InfernoZeus

2015-04-09 20:48

This package doesn't follow Arch packaging standards at all. Here are some suggested fixes:
1) Remove empty variables such as "optdepends=()".
2) prepare() shouldn't affect the users filesystem. Remove "mkdir -p $HOME/bin".
3) Remove the git clone and replace the source=(..) with the git repository. See here for more info: https://wiki.archlinux.org/index.php/VCS_package_guidelines#VCS_sources
3) package() should create the package, not install the files directly to the users filesystem. Remove
install -Dm755 "$srcdir"/"$pkgname"/spotify-adkiller.sh $HOME/bin/spotify-adkiller.sh
and replace it with
install -Dm755 "$srcdir"/"$pkgname"/spotify-adkiller.sh "$pkgdir"/usr/bin/spotify-adkiller.sh
4) Copy the desktop file as suggested in Spotify-AdKiller's readme:
install -Dm644 "$srcdir"/"$pkgname"/"Spotify (AdKiller).desktop" "$pkgdir"/usr/share/applications/"Spotify (AdKiller).desktop"

Comment by timidger

2015-03-29 18:34

Sorry about that, I'm a git. Fixed it by skipping the MD5sum.

Comment by fertorresf

2015-03-11 19:46

It still shows a "Validating source files with md5sums ... master.tar.gz ... FAILED"

Comment by timidger

2015-03-01 04:41

There we go, should be fixed now. Ironically, it changed because upstream they merged my changes that added this repo to their README

Comment by mareex

2015-02-27 18:48

checksum fails