Package Details: sslyze 0.14.0-1

Git Clone URL: https://aur.archlinux.org/sslyze.git (read-only)
Package Base: sslyze
Description: Fast and full-featured SSL scanner.
Upstream URL: https://github.com/nabla-c0d3/sslyze
Licenses: GPL2
Submitter: fxbru
Maintainer: goll (Bevan)
Last Packager: goll
Votes: 19
Popularity: 0.525010
First Submitted: 2012-11-09 17:23
Last Updated: 2016-09-04 17:55

Latest Comments

goll commented on 2016-03-09 13:14

@sja1440: That's strange, here is how the permissions should look like:

$ namei -om /opt/sslyze/sslyze_cli.py
f: /opt/sslyze/sslyze_cli.py
drwxr-xr-x root root /
drwxr-xr-x root root opt
drwxr-xr-x root root sslyze
-rwxr-xr-x root root sslyze_cli.py

Everybody has read and execute permissions by default. How did you install the package? You should use an AUR helper (https://wiki.archlinux.org/index.php/AUR_helpers).

sja1440 commented on 2016-03-09 12:39

After installation of sslyze 0.13.4-1 I had issues with the permissions of the installed files under /opt. Only root had read or execute access.

I had to fix these manually, in order to run sslze.

Many thanks

fabianz commented on 2016-03-05 19:23

@goll: As you elaborate, this package is using pip to install nassl, therefore it is actually packaging binaries compiled by upstream. See nassl repository, especially the bin directory.

Symlinking /opt/sslyze/sslyze_cli.py to /usr/bin/sslyze works fine for me (see sslyze-git PKGBUILD), apparently no need to package in standard paths here. The advantage clearly is getting rid of an unneeded indirection.

goll commented on 2016-03-05 18:38

@fabianz: The launcher is still here because pip installs nassl under ./lib and I think it's best it stays in a non-standard path such as /opt. I don't see what advantage would be gained by using a symlink.

The last version that had upstream binaries was 0.12.
The package is using upstream release tarballs.

fabianz commented on 2016-03-05 18:24

The indirect launcher is not needed anymore, as https://github.com/nabla-c0d3/sslyze/pull/65 was merged upstream.
Also, I want to humbly ask you to consider modifying this PKGBUILD for a full source build (using upstream release tarballs or git tag checkouts) instead of repackaging upstream binaries (working build code is in sslyze-git package). Otherwise, I want to suggest that this package should be renamed to sslyze-bin, and a proper sslyze package be created.

goll commented on 2016-03-04 06:59

@hardfalcon: Arch doesn't use sh by default, it's a symlink to bash:

$ ls -l /usr/bin/sh
lrwxrwxrwx 1 root root 4 Nov 23 21:20 /usr/bin/sh -> bash

hardfalcon commented on 2016-03-04 04:43

Would it be possible to replace #!/usr/bin/bash with #!/bin/sh in the PKGBUILD? The indirect launcher script doesn't use anything that a standard POSIX shell doesn't provide, so bash shouldn't be required.

Bevan commented on 2015-11-13 23:05

@luckdragon: Yeah, dissing peoples work that was made available for free and without any warranty surely is the right way to go…
Seriously, nobody wasted two hours of your life but yourself. Nobody forced you to use this PKGBUILD. If you decide to use it do it at your own risk and don't blame people who made it available initially.

That being said: The issue you reported was valid and the PKGBUILD was changed accordingly. Thanks.

luckdragon commented on 2015-11-03 19:38

The person who wrote this original package wasted 2 hours of my life that I will never get back now, thanks to a python script I was writing to call sslyze that would not work when adding the --xml option with a relative path. What was the bug? Is the problem with my script? With sslyze? A bug in the python programming language? Nope, none of those.

Yes, lets change directories in a shell script silently without warning. That sounds like a brilliant. fucking. idea.

Dear maintainer, please update the PKGBUILD to this, so that future people don't have my problem:

pkgname='sslyze'
pkgver=0.12
pkgrel=2
pkgdesc="Fast and full-featured SSL scanner."
arch=('i686' 'x86_64')
url=('https://github.com/nabla-c0d3/sslyze')
license=('GPL2')
depends=('python2')
source_i686=("https://github.com/nabla-c0d3/sslyze/releases/download/release-${pkgver}/${pkgname}-${pkgver/./_}-linux32.zip")
source_x86_64=("https://github.com/nabla-c0d3/sslyze/releases/download/release-${pkgver}/${pkgname}-${pkgver/./_}-linux64.zip")
sha1sums_i686=('1bb34e313a93c57264171446e0bd6c89cf8828c9')
sha1sums_x86_64=('a8f3f7b7b728281611793c380055c027318c4a47')

prepare() {
find $srcdir/$pkgname/ -type d -exec chmod 755 {} +
}

package() {
# Install files in /opt
mkdir -p "$pkgdir/opt/sslyze"
cp -a $srcdir/${pkgname}/. $pkgdir/opt/sslyze
find $pkgdir/opt/sslyze -type f -name '*.py' -print0 | xargs -0 sed -i 's/python/python2/'

# Create an indirect launcher in /usr/bin
mkdir -p "$pkgdir/usr/bin"

cat << EOF > "$pkgdir/usr/bin/sslyze"
#!/usr/bin/bash
python2 /opt/sslyze/sslyze.py \$@
EOF

chmod 755 "$pkgdir/usr/bin/sslyze"
}

Bevan commented on 2015-08-09 18:52

I disown this package so that goll can take it back. So if you are not goll: Please do not take this package. Thanks :)

All comments