Package Details: st-distrotube-git 0.8.2-1

Git Clone URL: https://aur.archlinux.org/st-distrotube-git.git (read-only, click to copy)
Package Base: st-distrotube-git
Description: A heavily-patched and customized build of st (the Suckless simple terminal) from DistroTube.
Upstream URL: https://gitlab.com/dwt1/st-distrotube.git
Licenses: MIT
Conflicts: st
Provides: st
Submitter: dwt1
Maintainer: dwt1
Last Packager: dwt1
Votes: 2
Popularity: 0.24
First Submitted: 2020-03-20 20:57
Last Updated: 2020-05-04 21:27

Required by (7)

Sources (1)

Latest Comments

Kr1ss commented on 2020-03-20 19:02

Hey dt, congratz to your first AUR package ! Few things though...

  • since you're pulling from the upstream GitLab trunk (rather than using a specific version), the $pkgname should have a VCS suffix (eg st-distrotube-git)

  • for the same reason (this being a VCS package), you need a pkgver() function

  • make is a member of the base-devel group, hence it's not supposed to be included in the makedepends array

  • git should be included in makedepends b/c you use it to retrieve the sources

  • no reason to mkdir -p $pkgname in the build function; the folder is created anyways during makepkg extracting the sources

  • all instances of ... || return 1 can be removed since makepkg always exits with an error code if any command fails, anyways

Also, not sure why you'd cp all the source files into the package ?

Anyways, keep on and enjoy learning ! Cheers !