Package Details: st 0.8.2-7

Git Clone URL: https://aur.archlinux.org/st.git (read-only)
Package Base: st
Description: A simple virtual terminal emulator for X.
Upstream URL: https://st.suckless.org
Licenses: MIT
Submitter: Foxboron
Maintainer: jose1711 (waschtl)
Last Packager: waschtl
Votes: 45
Popularity: 1.662753
First Submitted: 2017-11-20 15:32
Last Updated: 2019-10-16 12:13

Dependencies (3)

Required by (4)

Sources (1)

Latest Comments

1 2 Next › Last »

milouse commented on 2019-10-16 13:29

Thanks @waschtl for your clear explanations! I must admit I don't read the doc since a long time, shame on me.

waschtl commented on 2019-10-16 12:28

@milouse, thank you for your suggestions. I had completely missed the fact that the URLs were not using HTTPS.

I incorporated several of your changes, but not all of them. I don't want to seem like I'm ignoring your suggestions, though, so I would like to explain my decisions:

  • Using variables in the source array is preferred over static definitions according to man pkgbuild. See "OPTIONS AND DIRECTIVES"->source.
  • Using $srcdir is not necessary because all PKGBUILD functions are executed within that directory. See man pkgbuild->"PACKAGING FUNCTIONS"->srcdir.
  • I have a personal preference not to use cd in favor of --directory options to make and co. Therefore, I have removed what cd statements were still around.

milouse commented on 2019-10-16 09:19

Hi,

I would like to suggest the following changes:

  • Use https URL to download st
  • Remove unnecessary variable resolution
  • Fix sed line to remove terminfo files (no more @ prefix in the current release).
diff --git a/PKGBUILD b/PKGBUILD
index 8a0056e..31c5ac1 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -12,11 +12,14 @@ license=('MIT')
 depends=(libxft)
 makedepends=(libxext ncurses)
 url="http://st.suckless.org"
-source=(http://dl.suckless.org/st/$pkgname-$pkgver.tar.gz)
+source=(https://dl.suckless.org/st/st-$pkgver.tar.gz)
 sha256sums=('aeb74e10aa11ed364e1bcc635a81a523119093e63befd2f231f8b0705b15bf35')

 prepare() {
-  sed '/@tic/d' -i $pkgname-$pkgver/Makefile
+  cd $srcdir/$pkgname-$pkgver
+  # skip terminfo which conflicts with ncurses
+  sed '/tic /d' -i Makefile
+  sed -i '/@echo .* terminfo/d' Makefile

   # This package provides a mechanism to provide a custom config.h. Multiple
   # configuration states are determined by the presence of two files in
@@ -39,7 +42,7 @@ prepare() {
   abort=
   if [ -e "$BUILDDIR/config.h" ]
   then
-    cp "$BUILDDIR/config.h" "$pkgname-$pkgver"
+    cp "$BUILDDIR/config.h" "$srcdir/$pkgname-$pkgver"
   elif [ ! -e "$BUILDDIR/config.def.h" ]
   then
     abort=1
@@ -49,7 +52,7 @@ prepare() {
     msg+='values. Then restart the build process.'
     error "$msg"
   fi
-  cp "$pkgname-$pkgver/config.def.h" "$BUILDDIR"
+  cp config.def.h "$BUILDDIR"
   test -z "$abort"
 }

waschtl commented on 2019-10-16 08:19

@simona: The purpose of this is to alert the user to the unusual situation that configuration happens at build time. Build is successful on the second run, thereby giving you the chance to look at the configuration file if you want to.

I will change "Then rerun makepkg." to "Then restart the build process." to account for builds by AUR helpers.

simona commented on 2019-10-16 07:39

==> ERRORE: This package can be configured in config.h. Copy provided config.def.h to config.h and modify to change configuration. Leave config.def.h as it is to use default values. Then rerun makepkg. ==> ERRORE: Si è verificato un errore in prepare().

waschtl commented on 2019-10-15 22:09

Thanks @famar for the pointer. I have replaced it with $BUILDDIR, which is not mentioned in that document, but seems appropriate.

famar commented on 2019-10-15 21:20

Hi, according to PKGBUILD manual, the use of the packaging variable startdir "is deprecated and strongly discouraged".

Can you please update?

waschtl commented on 2019-09-18 12:32

The line

# remove to avoid conflict with ncurses
rm "${pkgdir}/usr/share/terminfo/s/st" "${pkgdir}/usr/share/terminfo/s/st-256color"

doesn't quite do the trick. The two files

st-meta
st-meta-256color

still get installed. And they do not play well with the terminfo files from ncurses. It would be safer to disable terminfo generation in prepare() as follows (taken from st-git):

sed '/@tic/d' -i Makefile

jose1711 commented on 2019-04-08 20:41

adopted and finally updated

OliK commented on 2019-03-08 17:11

Mon, 4 Mar 2019, I wrote an email to Foxboron (foxboron@archlinux.org) asking if he still maintain this AUR package. But I don't get an answer.