Arch Linux User Repository

Hello, since packages are now compressed with zstandard by default, can you please add that pattern to .gitignore:

diff --git a/.gitignore b/.gitignore
index 2d32340..2d7d03c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,4 +1,5 @@
 /*.pkg.tar.xz
+/*.pkg.tar.zst
 /config.def.h
 /config.h
 /pkg/

Thank you.

Please consider using the patch(1) options -d and -p instead of --directory and --strip, so that GNU patch is not required.

https://wiki.archlinux.org/title/Arch_package_guidelines#Package_etiquette:

Do not use makepkg subroutines (e.g. error, msg, msg2, plain, warning) as they might change at any time. To print data, use printf or echo.

This package is needlessly using warning.

Please add the aarch64 architecture. It builds quite nicely. Thank you for your support.

My patch(1) does not support long options. Please change patch --directory="$_sourcedir" --strip=0 < terminfo.patch to the portable patch -d "$_sourcedir" -p 0 < terminfo.patch.

Are README.terminfo.rst and terminfo.patch still needed with 0.8.4? README.terminfo.rst sais " As of st-0.8.2 they have errors in them. This has been fixed and will roll out in the next release, though."

Can you change the installopts to be '-m 0644 -D -t' so that install implementations aside from coreutils work, because those shortopt equivalents to the long options currently used are more widely supported, whereas the long options are pretty much only supported by GNU coreutils.

Attempting to add the font2 patch creates error: "error: ‘frccap’ undeclared". Some reddit threads suggest this has been a problem for over 9 months now. The following relevant patches from the official st repos will fix this:

2019-03-03 10:29 simplify (greedy) font caching allocating a bit Hiltjo Posthuma 1 +2 -7 https://git.suckless.org/st/commit/ed68fe7dce2b21b4e0e595b99d47790e76812cb7.html

2019-02-28 01:56 fix use after free in font caching algorithm magras 1 +9 -6 https://git.suckless.org/st/commit/a8cb8e94547d7e31441d2444e8a196415e3e4c1f.html

AUR helpers are not supported. Please contact pikaur author to get help with it. st works like any other aur package: after having cloned it, you can makepkg it and you'll find the sources in the src folder.

First time , for me, after install i cant find sources, is that normal? using pikaur i cant find build folder.

Ooups, I suppose I messed with something :)

It looks like you have your own config.h. The error message is pointing at line 180 in that file.

If you didn't intend to compile with customizations, just remove your config.h, and the defaults from config.def.h will be used. If you did intend to compile with customizations, you probably need to adjust your config.h.

Hi, It doesn't compile on my system:

$ LC_MESSAGES=en_US.UTF-8 makepkg -si
==> Making package: st 0.8.2-10 (lun. 11 nov. 2019 10:16:42 CET)

[snip]

==> Starting build()...

[snip]

st build options:
CFLAGS  = -I/usr/include/X11  -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include  -DVERSION="0.8.2" -D_XOPEN_SOURCE=600 -D_FORTIFY_SOURCE=2 -march=x86-64 -mtune=generic -O2 -pipe -fno-plt
LDFLAGS = -L/usr/lib/X11 -lm -lrt -lX11 -lutil -lXft  -lfontconfig -lfreetype   -lfreetype  -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now
CC      = c99
c99 -I/usr/include/X11  `pkg-config --cflags fontconfig`  `pkg-config --cflags freetype2` -DVERSION=\"0.8.2\" -D_XOPEN_SOURCE=600 -D_FORTIFY_SOURCE=2 -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -c st.c
lkc99 -I/usr/include/X11  `pkg-config --cflags fontconfig`  `pkg-config --cflags freetype2` -DVERSION=\"0.8.2\" -D_XOPEN_SOURCE=600 -D_FORTIFY_SOURCE=2 -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -c x.c
In file included from x.c:61:
config.h:180:42: error: ‘iso14755’ undeclared here (not in a function)
  180 |  { TERMMOD,              XK_I,           iso14755,       {.i =  0} },
      |                                          ^~~~~~~~
make: *** [Makefile:22: x.o] Error 1
make: Leaving directory '/home/jean/abs/st/src/st-0.8.2'
==> ERROR: A failure occurred in build().
    Aborting...
$

Hi @milouse,

my conversation so far with Thomas Dickey from ncurses (https://lists.gnu.org/archive/html/bug-ncurses/2019-10/msg00070.html) has revealed something that I didn't previously realize:

• The terminfo entries from upstream st have two bad tmux extensions in them. While they don't cause any obvious errors while I'm using them, that may not be the case in general. I don't think that they should be distributed.
• He regularly releases an updated terminfo database between ncurses versions that is intended to be included in distribution packages. ArchLinux is not doing this.
• He believes his current st terminfo entry to be correct. I have not verified this yet.
• There is a clear argument for distributing all terminfo entries with ncurses: When you ssh into a machine, that machine must know your terminal emulator. Most terminal emulators don't get installed on most machines (especially servers).

I have analyzed various terminfo entries for st from several ncurses versions, as well as from upstream st. I now understand what's wrong with the entries provided with st and am working on understanding his modifications to it.

My plan is as follows:

1. Clear up any questions I have about the current st terminfo file provided by ncurses.
2. Test entries that should be good.
3. File a bug report and patch with st to fix the problems with their terminfo entry.
4. File a bug report with the ArchLinux ncurses package hoping to move them to use officially released and updated terminfo databases between ncurses versions.

Thanks for your encouragement.

Hi @waschtl,

I just read with attention your README about the terminfo problem. I'm aware of it since a long time, but must admit I never take time to do anything forward. Thus I'm very insteresting to follow up your discussion with either ncurse team or Archlinux team. How do you think to proceed? A quick check in the archlinux bug tracker show me no bug related to that. I wonder if a quick fix won't be to ask there to remove st information from the archlinux ncurse package. As st is NOT provided in any official repository, I think it's not a big problem to remove responsibility of that.

Thank you for your involvment!

Yes :-) Thanks.

No problem. I think I will remove the error message. It's counterintuitive.

I did not know about BlackArch. Thanks for the pointer.

1. yes, sorry. blackarch repos.

@simona, two questions:

1. Where is yay finding the package paraxor-st? I can't find it in the AUR.

   yay -Si paraxor-st

2. Does installing st work if you try again?

   The error message you are reporting is there so that you know that st can only be configured before compilation. If yay caches the package directory, a second attempt should no longer show the error.

Yes. yay was installing paraxor-st. another pkg. But installing true st it give me:

patching file Makefile ==> ERRORE: This package can be configured in config.h. Copy config.def.h just placed into the package directory to config.h and modify it to change the configuration. Or just leave it alone to use default values. Then restart the build process. ==> ERRORE: Si è verificato un errore in prepare(). L'operazione sta per essere interrotta...

@simona, you should be fine as it is. I may have expressed myself poorly. I meant to say that the package does not put any files in /usr/share/terminfo.

Are you getting an error message?

@waschtl can I change where to install? I use yay.

Hi simona, greetings to Italy.

If I understand you correctly, you are telling me that the following two files in this package conflict with ncurses:

• /usr/share/terminfo/s/st
• /usr/share/terminfo/s/st-256color

I couldn't figure out what you meant by "paraxor-st" though.

And I completely agree. ncurses is making it difficult for me to package st well. Precisely for that reason, I did not install those files to the locations you mentioned. Instead they are being installed to

• /usr/share/st/terminfo/s/st
• /usr/share/st/terminfo/s/st-256color

Notice the extra st after /usr/share.

paraxor-st: /usr/share/terminfo/s/st è già presente nel filesystem (appartiene a ncurses) paraxor-st: /usr/share/terminfo/s/st-256color è già presente nel filesystem (appartiene a ncurses)

Thanks @waschtl for your clear explanations! I must admit I don't read the doc since a long time, shame on me.

@milouse, thank you for your suggestions. I had completely missed the fact that the URLs were not using HTTPS.

I incorporated several of your changes, but not all of them. I don't want to seem like I'm ignoring your suggestions, though, so I would like to explain my decisions:

• Using variables in the source array is preferred over static definitions according to man pkgbuild. See "OPTIONS AND DIRECTIVES"->source.
• Using $srcdir is not necessary because all PKGBUILD functions are executed within that directory. See man pkgbuild->"PACKAGING FUNCTIONS"->srcdir.
• I have a personal preference not to use cd in favor of --directory options to make and co. Therefore, I have removed what cd statements were still around.

Hi,

I would like to suggest the following changes:

• Use https URL to download st
• Remove unnecessary variable resolution
• Fix sed line to remove terminfo files (no more @ prefix in the current release).

diff --git a/PKGBUILD b/PKGBUILD
index 8a0056e..31c5ac1 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -12,11 +12,14 @@ license=('MIT')
 depends=(libxft)
 makedepends=(libxext ncurses)
 url="http://st.suckless.org"
-source=(http://dl.suckless.org/st/$pkgname-$pkgver.tar.gz)
+source=(https://dl.suckless.org/st/st-$pkgver.tar.gz)
 sha256sums=('aeb74e10aa11ed364e1bcc635a81a523119093e63befd2f231f8b0705b15bf35')

 prepare() {
-  sed '/@tic/d' -i $pkgname-$pkgver/Makefile
+  cd $srcdir/$pkgname-$pkgver
+  # skip terminfo which conflicts with ncurses
+  sed '/tic /d' -i Makefile
+  sed -i '/@echo .* terminfo/d' Makefile

   # This package provides a mechanism to provide a custom config.h. Multiple
   # configuration states are determined by the presence of two files in
@@ -39,7 +42,7 @@ prepare() {
   abort=
   if [ -e "$BUILDDIR/config.h" ]
   then
-    cp "$BUILDDIR/config.h" "$pkgname-$pkgver"
+    cp "$BUILDDIR/config.h" "$srcdir/$pkgname-$pkgver"
   elif [ ! -e "$BUILDDIR/config.def.h" ]
   then
     abort=1
@@ -49,7 +52,7 @@ prepare() {
     msg+='values. Then restart the build process.'
     error "$msg"
   fi
-  cp "$pkgname-$pkgver/config.def.h" "$BUILDDIR"
+  cp config.def.h "$BUILDDIR"
   test -z "$abort"
 }

@simona: The purpose of this is to alert the user to the unusual situation that configuration happens at build time. Build is successful on the second run, thereby giving you the chance to look at the configuration file if you want to.

I will change "Then rerun makepkg." to "Then restart the build process." to account for builds by AUR helpers.

==> ERRORE: This package can be configured in config.h. Copy provided config.def.h to config.h and modify to change configuration. Leave config.def.h as it is to use default values. Then rerun makepkg. ==> ERRORE: Si è verificato un errore in prepare().

Thanks @famar for the pointer. I have replaced it with $BUILDDIR, which is not mentioned in that document, but seems appropriate.

Hi, according to PKGBUILD manual, the use of the packaging variable startdir "is deprecated and strongly discouraged".

Can you please update?

The line

# remove to avoid conflict with ncurses
rm "${pkgdir}/usr/share/terminfo/s/st" "${pkgdir}/usr/share/terminfo/s/st-256color"

doesn't quite do the trick. The two files

st-meta
st-meta-256color

still get installed. And they do not play well with the terminfo files from ncurses. It would be safer to disable terminfo generation in prepare() as follows (taken from st-git):

sed '/@tic/d' -i Makefile

adopted and finally updated

Mon, 4 Mar 2019, I wrote an email to Foxboron (foxboron@archlinux.org) asking if he still maintain this AUR package. But I don't get an answer.

@bobsaintcool no, since it's part of base-devel group.

Hi @Foxboron, I believe pkgconf should be added to makedepends isn't it?

st needs a way to install terminfo, the ones that come with ncurses(for 0.7 maybe) have problems with current version.

https://github.com/tmux/tmux/issues/1264#issuecomment-367385211.

For now I have ~/.terminfo/ with correct terminfo for st. Hope this resolves.

This is only ment as a template. Modify the PKGBUILD.

the config.h file is useless if it is gonna be checksumed afterward