Package Details: starruler2-git r27.ba99a9a-1

Git Clone URL: https://aur.archlinux.org/starruler2-git.git (read-only)
Package Base: starruler2-git
Description: 4X Space Strategy game Star Ruler 2's open source distribution.
Upstream URL: http://starruler2.com/
Licenses: MIT
Provides: starruler2
Submitter: ysblokje
Maintainer: ysblokje
Last Packager: ysblokje
Votes: 7
Popularity: 0.632569
First Submitted: 2018-07-24 09:24
Last Updated: 2018-08-24 20:24

Latest Comments

ysblokje commented on 2018-08-24 20:12

@TrialnError thanks for the suggestions! Incorporating them right now.

TrialnError commented on 2018-08-24 19:47

Some comments on the PKGBUILD.

The .desktop file should be added to the source line (like it is done with patch files and else). It would also error out earlier if, for whatever reason, the file is missing. And modifications could be detected. Additionally it makes the deprecated use of $startdir obsolete as the .desktop file will be available from $srcdir.

The empty prepare function could be removed, or the conversion of the icon file should be placed there.

Empty variables should also be removed (conflicts, optdepends).

If cp is used, it should look like $ cp -dpr --no-preserve=ownership.

And finally. Only the commit hash used as a pkgver is suboptimal. Especially if one is using a local repository. Should more like the fourth example from the VCS Guidelines: printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"

ysblokje commented on 2018-08-23 09:21

sorry for the late replies, I just got back from my vacation. @phw, I should. @Eremiel the game needs to be started from it's basefolder otherwise it won't work. A symlink won´t work so an additional script must be written. It's one of the reasons I wrote the .desktop file.

Eremiell commented on 2018-08-08 06:44

Could you please add symlink to /usr/bin? Right now I have to start it using full path. Thanks!

phw commented on 2018-08-07 16:06

Please add git to makedepends, it is required to fetch the sources.

kleintux commented on 2018-07-26 05:41

Works perfect. Thanks.