Arch Linux User Repository

@knotsies: You got it :) Just pushed 1.0.2-4

FYI in general: I know there is a tfenv 2.x, but that is not a stable release yet. I will not update this package with a non-stable release.

Hello! Thanks for adding this package to the AUR!

tfenv appears to use unzip when installing a new version:

/usr/local/lib/tfenv/libexec/tfenv-install: line 177: unzip: command not found
tfenv: tfenv-install: [ERROR] Tarball unzip failed

Can unzip be added as a dependency of this package?

Sorry it took so long. Applied the suggestion by WhiteAnthrax. @WhiteAnthrax if you are interested I would like to make you a co-maintainer. You seem to be more active than me :)

Oh.. sorry % diff -u PKGBUILD.orig PKGBUILD

--- PKGBUILD.orig   2019-09-02 14:42:42.000000000 +0900
+++ PKGBUILD    2019-09-02 15:46:12.305817135 +0900
@@ -2,7 +2,7 @@
 # Maintainer: Hendrik "T4cC0re" Meyer <aur@t4cc0.re>
 pkgname=tfenv
 pkgver=1.0.1
-pkgrel=2
+pkgrel=3
 epoch=
 pkgdesc="Terraform version manager inspired by rbenv"
 arch=("x86_64")
@@ -20,14 +20,16 @@
 package() {
    cd "${srcdir}/${pkgname}-${pkgver}"
    mkdir -p "${pkgdir}/usr/local/bin"
-   mkdir -p "${pkgdir}/usr/local/libexec"
+   mkdir -p "${pkgdir}/usr/local/lib/tfenv/libexec"
    echo $srcdir
    ls -lah
+  sed -i 's:TFENV_ROOT="$(cd "$(dirname "$(readlink_f "${0}")")/.." \&\& pwd)":TFENV_ROOT="$(cd "$(dirname "$(readlink_f "${0}")")/../lib/tfenv" \&\& pwd)":' bin/tfenv
    install -m755 "bin/${pkgname}" "${pkgdir}/usr/local/bin/${pkgname}"
    install -m755 "bin/terraform" "${pkgdir}/usr/local/bin/terraform"
-   for i in `ls ${srcdir}/${pkgname}/libexec/`; do
-       install -m755 "${srcdir}/${pkgname}/libexec/$i" "${pkgdir}/usr/local/libexec/$i"
+   for i in `ls ${srcdir}/${pkgname}-${pkgver}/libexec/`; do
+       install -m755 "${srcdir}/${pkgname}-${pkgver}/libexec/$i" "${pkgdir}/usr/local/lib/tfenv/libexec/$i"
    done
    chmod +x ${pkgdir}/usr/local/bin/${pkgname}
+  install -m644 "${srcdir}/${pkgname}-${pkgver}/CHANGELOG.md" "${pkgdir}/usr/local/lib/tfenv/"
 }
 sha512sums=(9ec96f67f6c25d0bb93fa880da6e1fdd74d6a5f930b29c45779a878ddc547eb10d2e6bacbbd64ac9a2a11b90b022fff87cd861a20eb3a412e39812e26c92741f)

We should remove the ${srcdir}/${pkgname}/ from the for-loop?

    for i in `ls ${srcdir}/${pkgname}/libexec/`; do
        install -m755 "${srcdir}/${pkgname}/libexec/$i" "${pkgdir}/usr/local/libexec/$i"
    done

Also, it seems very likely that 1.0.1 broke the installation via tfenv as now it expects to find CHANGELOG.md but this PKGBUILD does not copy/install that file.

https://github.com/tfutils/tfenv/pull/113

There is also issue about where to install CHANGELOG.md because /usr/local/ (which I think the upstream expects it to be at) might not be a good idea.

Solution could be we install the whole repository and symlink tfenv/bin/* to /usr/local/bin/` but I am not sure if that is a good practice for AUR.

@WhiteAnthrax applied your suggestion

--- /tmp/tfenv/PKGBUILD 2019-08-09 08:14:48.000000000 +0900
+++ tfenv/PKGBUILD  2019-08-21 13:40:19.873113328 +0900
@@ -18,7 +18,7 @@
 validpgpkeys=()

 package() {
-   cd "${srcdir}/${pkgname}"
+   cd "${srcdir}/${pkgname}-${pkgver}"
    mkdir -p "${pkgdir}/usr/local/bin"
    mkdir -p "${pkgdir}/usr/local/libexec"
    echo $srcdir

I just adopted the package and applied the suggested fixes :)

Hi zephrax, based on comments by hsa and nesth, I've created a patch as an attempt to improve this package. Would you be interested in merging this? https://github.com/shihanng/tfenv/commit/154fc37a92aeed75e21167b3159b3d3d590704e6

Upstream URL and sources have changed:

- https://github.com/Zordrak/tfenv
- git@github.com:Zordrak/tfenv.git