Arch Linux User Repository

@pswiatki I agree and I do the same thing.

@trimclain I imagine, keeping multiple variants would only make sense if one wanted to compare performance. But that reason also makes little sense, as it should be pretty obvious newer extensions (e.g. AVX2) would perform better than older ones (e.g. SSEx). Right? In my case, I just check the best extension the CPU in my computer supports and fetch the appropriate thorium version compiled with support for that extension.

@Rezn1r Sounds good! As for the conflicts, what's your opinion? I think it might be more convenient to add the symlink and keep the conflicts (from my patch). Don't really see a reason for allowing multiple Thorium installs.

@triclain thanks for the patch ill add those later, as for the conflicts i do not know why its there. It was already there when i adopted this aur

Also with conflicts, I’m curious what the intended goal is here. Is it meant to allow the AVX2 package to be installed alongside the AVX and SSE3/4 variants, or is it supposed to replace thorium-browser entirely? If the intention is to replace it, it might make sense to symlink thorium-browser to thorium-browser-avx2 during installation. Otherwise, I’d probably just remove conflicts entirely.

Hi, thanks for maintaining this package.

I made a small patch that
- fixes provides to match the name of the binary being installed
- fixes conflicts to match the names of other thorium browser AUR packages
- removes unnecessary rpm-tools and cpio makedepends in favor of bsdtar -xf

It built successfully for me locally, so I’m posting it here in case you want to include it.

diff --git a/PKGBUILD b/PKGBUILD
index c8e2ba2..c72284e 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -15,10 +15,8 @@ depends=(
   'mesa' 'nspr' 'nss' 'pango'
 )

-makedepends=('rpm-tools' 'cpio')
-
-provides=('thorium-browser')
-conflicts=('thorium-browser')
+provides=('thorium-browser-avx2')
+conflicts=('thorium-browser-bin' 'thorium-browser-avx-bin')

 source=("https://github.com/Alex313031/thorium/releases/download/M${pkgver}/thorium-browser_${pkgver}_AVX2.rpm")
 noextract=("thorium-browser_${pkgver}_AVX2.rpm")
@@ -28,7 +26,7 @@ sha256sums=('53943adc878f2244fe85c7e7096a53d5e82359fa4196a78702a12d101278237b')
 package() {
   cd "$srcdir"

-  rpm2cpio "thorium-browser_${pkgver}_AVX2.rpm" | cpio -idmv
+  bsdtar -xf "thorium-browser_${pkgver}_AVX2.rpm"

   # Move binaries to /opt
   install -d "$pkgdir/opt/thorium-browser-avx2"
@@ -56,4 +54,4 @@ package() {
     install -Dm644 "opt/chromium.org/thorium/product_logo_${size}.png" \
       "$pkgdir/usr/share/icons/hicolor/${size}x${size}/apps/thorium-browser-avx2.png"
   done
-}
\ No newline at end of file
+}

@Rezn1r: Confirmed. Works as expected. Thank you so much!

@pswiatki @rjjacky see latest commit if it fixes it ca069e7

OK, double checked: /usr/share/applications/thorium-browser-avx2.desktop has no %U (as would be expected), but ~/Desktop/thorium-browser-avx2.desktop and ~/.local/share/applications/thorium-browser-avx2.desktop do contain %U. Looks like someone / something added those later. Also, the last one is not an exact copy, as its content is greatly reduced (lacking GenericName and all its translations, for example). Don't know how it gets reduced in this manner, but surely something does it. By the way: I couldn't get thorium to open links properly when this .desktop file was not present in ~/.local/share/applications/

@rjjacky Yes, I understand this fully. But my impression is (have to double check) that %U is already included in the original package, no? I definitely did not add it myself and it appears in my thorium-browser-avx2.desktop file.

EDIT: very strange. I just inspected the package and its PKGBUILD. Double checked what sed produced in this part:

# Desktop entry
  install -Dm644 usr/share/applications/thorium-browser.desktop \
    "$pkgdir/usr/share/applications/thorium-browser-avx2.desktop"

  sed -i \
    -e 's|Exec=.*|Exec=/usr/bin/thorium-browser-avx2|' \
    -e 's|Icon=.*|Icon=thorium-browser-avx2|' \
    -e 's|Name=.*|Name=Thorium Browser AVX2|' \
    "$pkgdir/usr/share/applications/thorium-browser-avx2.desktop"

%U gets skipped. The fix seems trivial. It puzzles me how it happened I actually have %U in my system (really don't recall adding it manually).