Package Details: tls-client-git 1.15.1.r2.gb790a31-1

Git Clone URL: https://aur.archlinux.org/tls-client-git.git (read-only, click to copy)
Package Base: tls-client-git
Description: net/http.Client-like HTTP client with selectable TLS fingerprints
Upstream URL: https://github.com/bogdanfinn/tls-client
Licenses: BSD-4-clause
Conflicts: lib-tls-client, tls-client
Provides: lib-tls-client, tls-client
Submitter: dreieck
Maintainer: aminvakil
Last Packager: aminvakil
Votes: 0
Popularity: 0.000000
First Submitted: 2023-02-19 20:53 (UTC)
Last Updated: 2026-07-07 15:30 (UTC)

Dependencies (3)

Required by (1)

Sources (2)

Pinned Comments

aminvakil commented on 2026-06-10 14:37 (UTC)

This repository is maintained at https://github.com/aminvakil/aur.

In case anyone had any suggestions about anything, feel free to raise a PR there.

Latest Comments

aminvakil commented on 2026-07-07 15:17 (UTC)

@gesh Thank you for your review.

  • I agree pkgname is not good as well, but this is not a go library, it provides a C shared library, so go-tls-client is not a good package name, I do not know what else to name it, maybe lib-tls-client-git would be better?

  • I agree with you on provides / conflicts and I'll change that.

  • Correct again about versioning, I'll change that.

  • The go mod edit is necessary to instruct package to use local checked out source instead of using github.com.

  • About install sections, I do not see any value in dropping them, it does not make any difference, I like to be explicit and keep them.

gesh commented on 2026-07-06 21:11 (UTC)

Oh, and given you're not renaming the files you're passing to install, you can drop them off the final component in the destination. Flipping the directionality of the symlink enables you to do that for the .so as well`.

gesh commented on 2026-07-06 20:57 (UTC) (edited on 2026-07-06 20:57 (UTC) by gesh)

Nice work on the rewrite!

Some remarks:

  • Not sure you can control this, but the pkgname is so generic as to be obscure. Guess that's up to upstream, though. Isn't this package a library, though? That would imply the standard recommendation is to name it go-tls-client.
  • Took me several reads to figure out that the reason you're provides=ing lib-tls-client and the sonames is because you merged the package with lib-tls-client-git. Unclear where you picked up libtls-client.so from, though? In any case, given that the only reverse dependency here is python-tls-client-git, I believe you can get away with just provides=(tls-client lib-tls-client) -- if I'm not mistaken, that should make pacman view this package as an upgrade to lib-tls-client-git. I would document this in the PKGBUILD, though. Also, given you also maintain python-tls-client-git, I'd update it to require tls-client instead.
  • https://wiki.archlinux.org/title/VCS_package_guidelines recommends using pkgver=UPSTREAM_VER.rREVISION, so that users can more easily report to upstream what version their build is based on. The original pkgver() was better in this regard, though there was no need to add the date. However, your fix does make the improvement of adding a .r prefix. A common convention is to also use .g to prefix the commit hash part.
  • I'm not used to seeeeing the go mod edit -replace, but I trust it's necessary?

Other than that, everything else looks great!

aminvakil commented on 2026-06-10 14:37 (UTC)

This repository is maintained at https://github.com/aminvakil/aur.

In case anyone had any suggestions about anything, feel free to raise a PR there.

dreieck commented on 2024-05-27 22:16 (UTC)

Not using it, orphaning.