Package Details: tmsu 0.7.0-1

Git Clone URL: https://aur.archlinux.org/tmsu.git (read-only)
Package Base: tmsu
Description: A tool for tagging your files and accessing them through a virtual filesystem.
Upstream URL: http://tmsu.org/
Licenses: GPL3
Provides: tmsu
Submitter: tmladek
Maintainer: MarcinWieczorek
Last Packager: MarcinWieczorek
Votes: 13
Popularity: 0.082249
First Submitted: 2015-08-29 19:21
Last Updated: 2017-11-29 10:22

Required by (0)

Sources (1)

Latest Comments

martyg commented on 2017-12-05 15:09

FYI, noticed these warnings at the end of building in a clean chroot.

Checking PKGBUILD Checking tmsu-0.7.0-1-x86_64.pkg.tar.xz tmsu E: Dependency bash detected and not included (programs ['sh', 'bash'] needed in scripts ['usr/bin/tmsu-fs-mv', 'usr/bin/tmsu-fs-merge', 'usr/bin/mount.tmsu', 'usr/bin/tmsu-fs-rm']) tmsu W: Dependency included and not needed ('go') tmsu W: Dependency included and not needed ('fuse') tmsu W: Dependency included and not needed ('sqlite')

flarkis commented on 2017-07-09 20:57

Modifying the PATH variable is not the correct solution here. The issue is a poorly written Makefile. Neither of the tests have dependencies on the final compiled output, so running with jobs > 1 causes the tests to run in parallel with the compilation.

Additionally tests shouldn't be in the build command in the first place. That's what check is for. The user should have the option to skip failing tests if the outputs are generated properly.

So with all that being said I think the correct solution is to modify the PKGBUILD like

```
28c28,33
< make
---
> make dist
> }
>
> check() {
> cd "$srcdir/TMSU-$pkgver"
> make test
```

peperunas commented on 2017-06-15 08:55

Yep. CheezenOne is right. Just run make with the modified PATH env variable. Can the maintainer edit the PKGBUILD please?

CheezenOne commented on 2017-05-03 16:02

I could get the PKGBUILG compile the package after changing the make command to:
```
cd "$srcdir/TMSU-$pkgver"
PATH="$PATH:$(pwd)/bin" make -j1
```

My build was failing because the path to the `tmsu` executable was not known when the tests were executed.

oniony commented on 2017-03-29 22:55

Well, to investigate this further I just:

1. Uninstalled TMSU
2. Downloaded the PKGBUILD from here
3. Commented out the Go dependency from the PKGBUILD (as I have a version installed outside of Pacman)
4. Ran `makepkg` on the PKGBUILD.

This worked fine: the tests all ran successfully. I then ran `sudo pacman -U tmsu-0.6.1-1-i686.pkg.tar.gz` and installed it without any problem.

So I don't think there is, after all, any problem with either the PKGBUILD or the TMSU binary.

My earlier fears about the `run` script are unfounded: the build directory is not affected (it still builds to `bin` beneath the directory `makepkg` creates, so the relative path to the just-built TMSU is good).

So not sure why this is not working for some people.

oniony commented on 2017-03-29 13:03

@vok5, sure, I could look to introduce a `BUILD_DIR` variable. I would need to think about how the `run` script will be able to pick this up, especially as it's possible to run this script directly (without `make`).

vok5 commented on 2017-03-29 12:22

@oniony, thank you for having a look. I believe the `run` script shouldn't assume the build directory to be `bin`. It would fix the issue with this package and also make tmsu's tests more robusts. Perhaps, using an environment variable like BUILD_DIR, which could be overwritten would be a solution.

As for the PKGBUILD file, the build directory is changed by `makepkg` (https://wiki.archlinux.org/index.php/Creating_packages#build.28.29). Then, right before executing `make`, `cd "$srcdir/TMSU-$pkgver"` is executed to get inside the build directory of this package.

MarcinWieczorek commented on 2017-03-28 22:52

I'm not having any trouble building the package with current PKGBUILD. If you could please provide more logs that would be great. Somebody also try to add "${pkgdir}/usr/bin/" to PATH in order to conduct tests and try if it changes anything.

oniony commented on 2017-03-24 20:07

I've reviewed the code. The path is set in the `tests/run` script, which should mean the built version should take precedence over any pre-existing version you happen to have installed.

However the `run` script does assume a build directory of `bin`, so if the Arch package is building it elsewhere that could explain how it's not being picked up (and any pre-existing installation is used in its stead).

I've had a look at the PKGBUILD file but I cannot see anywhere the build directory is overriden, however.

MarcinWieczorek commented on 2017-03-24 11:21

Thank you for reaching out. That's nice to be visited by the upstream :p
I don't have a possibility of taking care of this, but I should have push access if you manage to fix this issue.

Marcin Wieczorek

oniony commented on 2017-03-24 11:16

TMSU author here. I'll take a look this evening. You might be right: it could be using the binary on the path rather than the one just built, which would not be ideal :)

terlar commented on 2017-03-24 09:08

This package builds fine for me, BUT only if I have tmsu command installed already. So it seems those tests require the tmsu binary to be available.

peperunas commented on 2017-03-23 13:29

The package does not build correctly. Having problems @ make: *** [Makefile:47: integration-test] Error 28

vok5 commented on 2017-03-19 17:44

This package also doesn't build for me. However, it builds fine (using v0.6.1) if I follow the instruction here: https://github.com/oniony/TMSU/blob/master/COMPILING.md. There is something wrong with this package...

MarcinWieczorek commented on 2017-02-02 15:32

Could you please check if this is PKGBUILD's fault? If it fails by executing `make` then we have to contact upstream. It builds fine for me tho.

ochi commented on 2017-02-02 13:39

Same problem as cryzed, doesn't build. Although sometimes it's error 113, sometimes 114, sometimes 120...

cryzed commented on 2017-01-27 22:43

Is anyone else getting the following error during the "PACKAGING DISTRIBUTABLE"-step?:

./files/files_for_escaped_query [PASS]
make: *** [Makefile:47: integration-test] Error 113
==> ERROR: A failure occurred in build().
Aborting...
:: failed to build tmsu package(s)

It seems like one of the integration-tests is failing? I am running a fully updated Arch Linux system.

MarcinWieczorek commented on 2017-01-24 16:09

There.
I didn't bump pkgrel.

TrialnError commented on 2017-01-23 23:33

Could you please adjust the download source and give the downloaded package an unique name? This will help people which use SRCDEST
This can be achived by adding ${pkgname}-${pkgver}.tar.gz:: in front of the download url.

Thanks in advance

MarcinWieczorek commented on 2016-08-02 15:30

What is 'testmain'?
Please attach information about the system and the build log.

hepha commented on 2016-08-02 14:26

hello
build error how can fix?
thanks
# testmain
/usr/bin/ld: $WORK/libgo-sqlite3.a451404230(sqlite3-binding.o): undefined reference to symbol 'pthread_mutexattr_settype@@GLIBC_2.2.5'
/usr/lib/libpthread.so.0: error adding symbols: DSO missing from command line

MarcinWieczorek commented on 2016-07-12 22:10

Integration tests run just fine and I didn't have tmsu installed at all.
A script running test exports PATH with a binary with just compiled tmsu.
`export PATH=$(dirname $_)/../bin:$PATH`

Please attach full log.
Sorry for late response.

minus commented on 2016-07-06 17:35

The integration tests fail with `tmsu: command not found` when tmsu was not previously installed, probably meaning that it runs the tests with the already installed version instead of the newly compiled one.

oniony commented on 2016-04-24 21:23

@BrianAllred, It's my bad. I run 'make compile && sudo make install' during development and forgot to run the full build before pushing.

I reverted that problematic commit yesterday though, so the tip of `master` should build fine. Indeed, the CI suggests it is: https://drone.io/github.com/oniony/TMSU/latest

Cheers,
Paul

BrianAllred commented on 2016-04-24 21:18

The integration tests are failing for me when building.

evilgnome commented on 2016-02-09 18:37

Solved my problem!

I had an old package installed: go-sqlite3.
I uninstalled it.

Tadaa!

evilgnome commented on 2016-02-08 14:53

Yes, the error reported here on October 26.

tmladek commented on 2016-02-08 09:38

I know it won't help much, but yes, the package works for *me*, otherwise I would never submit it.

https://ptpb.pw/Y6a3

What "same error", the one about go-sqlite3?

evilgnome commented on 2016-02-05 19:57

Wait, does this actually work for someone? I still get the same error as I reported in October.

eigengrau commented on 2016-01-31 10:27

BTW it occurred to me that exporting GOPATH as /tmp might be a security risk, since this could allow other users to inject code into the build by placing go code there before makepkg runs «go get». Maybe it would be better to export GOPATH=$(mktemp -d) to ensure it’s a directory other users cannot write to.

eigengrau commented on 2016-01-31 10:22

I’ve had the build fail on me because some of the integration/unit tests would fail. This seems to arise if you have the previous version of tmsu installed on your system, which is then used by the test suite for some reason instead of the newly built binary (but only when the test suite is run via makepkg; when it’s run in a normal environment it’ll use the build-tree’s binary).

sachkris commented on 2016-01-27 11:46

v0.6 is released. Please update the package.

evilgnome commented on 2015-10-26 20:24

This has been broken for some time, failing with:

==> Starting build()...
Now getting go-sqlite3...
package github.com/mattn/go-sqlite3: directory "/usr/lib/go/src/github.com/mattn/go-sqlite3" is not using a known version control system

tmladek commented on 2015-09-25 05:50

Whoops, thanks.

atweiden commented on 2015-09-25 05:17

fixed PKGBUILD: http://ix.io/l08

deimos commented on 2015-09-25 04:43

error: failed to commit transaction (conflicting files)
tmsu: /usr/sbin exists in filesystem
Errors occurred, no packages were upgraded.

tmladek commented on 2015-09-24 19:23

There.

encbladexp commented on 2015-09-04 06:00

I think it would be better to build tmsu from source instead of using precompiled binaries.