Arch Linux User Repository

Hi,

Thanks for submitting this PKGBUILD to the AUR. However, it has some issues and could benefit from some improvements:

• Since it pulls a prebuilt binary, it should be togo-bin instead of togo.

• There are some typos in the pkgdesc: beautifull/beautiful | termianl-based/terminal-based | zero dependencies/zero dependency

• There's no point renaming the upstream tarball in the source array here. The original name isn't conflicting already. However the name you use for the renaming might be if other architectures are ever distributed via this PKGBUILD.

• There's little to no reason to skip the checksum (sha256sums) here.

• No need to cd "$srcdir" in the package function. Functions are already executed from "$srcdir"

• Custom variables should be prefixed with a _ (underscore), e.g. _BINARY

• The whole if [ -f [...] ] dance to verify if the binary and files (README / LICENSE) are indeed present in the upstream tarball is kinda unconventional and should not be necessary. Ideally, the list of distributed files should be coherent across releases. If it's not the case, this should be discussed with upstream. In any case, since togo is licensed under MIT, the license file should always be shipped to users.

You can refer to:

• https://wiki.archlinux.org/title/AUR_submission_guidelines
• https://wiki.archlinux.org/title/PKGBUILD
• https://wiki.archlinux.org/title/Arch_package_guidelines

I hope that helps :)