Package Details: tuxedo-keyboard 2.0.4-1

Git Clone URL: https://aur.archlinux.org/tuxedo-keyboard.git (read-only, click to copy)
Package Base: tuxedo-keyboard
Description: Keyboard Backlight Driver from TUXEDO Computers
Upstream URL: https://github.com/tuxedocomputers/tuxedo-keyboard
Keywords: TUXEDO tuxedo-keyboard
Licenses: GPL
Conflicts: tuxedo-keyboard-dkms, tuxedo-wmi, tuxedo-wmi-dkms
Replaces: tuxedo-keyboard-dkms, tuxedo-wmi, tuxedo-wmi-dkms
Submitter: StevenSeifried
Maintainer: StevenSeifried
Last Packager: StevenSeifried
Votes: 5
Popularity: 0.43
First Submitted: 2019-11-08 20:37
Last Updated: 2020-05-26 15:52

Latest Comments

StevenSeifried commented on 2020-01-07 19:09

@huyizheng,

thanks for your comment & adjustments. I have now adopted them.

For the bug in the dkms.conf: Please create an issue at Github

huyizheng commented on 2020-01-07 15:29

There's a bug in this package.

Its dkms.conf file has this line:

MAKE[0]="make -C . KERNELDIR=/lib/modules/${kernelver}/build"

Which means that during dkms install process, the target kernel is send to make command by variable KERNELDIR.

However, in its Makefile, there's this line:

KDIR := /lib/modules/$(shell uname -r)/build

And the rest of makefile uses this KDIR variable to build kernel modules. Which means that it'll always build against current running kernel, rather than the target kernel. So the dkms install will always fails when upgrading kernel.

To fix this bug, simple delete the line KDIR := ... in Makefile, and replace all KDIR with KERNELDIR in the rest of `Makefile.

I created a modified PKGBUILD here: https://fars.ee/IZ1V , it fixes the bug, and I also do some other modifications:

  1. make and gcc belongs to base-devel group, so they don't need to be written into makedepends.

  2. git should be makedepends, since it's just used to fetch source.

  3. ***-headers should only be optdepends, see virtualbox-host-dkms nvidia-dkms in official repo for example.

  4. pacman had its dkms hook which can handle dkms package itself, so the .install file is not needed.

  5. Users may want to change /etc/modprobe.d/tuxedo_keyboard.conf to change color or effect of their keyboard, so it's better to backup this file before install/upgrade this package.

StevenSeifried commented on 2019-12-01 12:19

@huyizheng and @sftbgit: I have updated the PKGBUILD file

sftbgit commented on 2019-12-01 12:10

@huyizheng Maybe you're right, but linux-headers is still needed!

huyizheng commented on 2019-11-23 10:58

Since this is a dkms package, linux-header should not be makedepends.