Arch Linux User Repository

@greyltc, @HurricanePootis

I just uploaded an uefitool-ng with the version A72 that is based on the new_engine branch from upstream.

Maybe we should rename this package to uefitool-legacy and let a package named uefitool use the modern code base (Axx releases). The 0.28.0 code this builds from is almost 5 years old and there's been numerous A series releases since then.

Do we have any reason to believe that the non-A code branch that this package is based on is anything but abandoned?

@HurricanePootis for alphas, please use uefitool-git or create some uefitool-alpha or whatever.

diff --git a/PKGBUILD b/PKGBUILD
index 17f9d07..7797e3c 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -4,37 +4,33 @@
 pkgname=uefitool
 _pkgname=UEFITool
 _tools=(UEFIPatch UEFIReplace)
-pkgver=0.28.0
-pkgrel=2
-epoch=1
+pkgver=A72
+pkgrel=1
+epoch=2
 pkgdesc='UEFI firmware image viewer and editor and utilities'
 arch=('armv7h' 'aarch64' 'i686' 'x86_64')
 url='https://github.com/LongSoft/UEFITool'
-license=('BSD')
-depends=('qt5-base')
-makedepends=('zip')
-provides=(uefipatch)
-conflicts=("${pkgname}-git" uefipatch)
-replaces=(uefipatch)
+license=('BSD-2-Clause')
+depends=('qt6-base' 'hicolor-icon-theme' 'glibc' 'gcc-libs')
+makedepends=('cmake' 'ninja' 'vulkan-headers')
 source=("${_pkgname}-${pkgver}.tar.gz::${url}/archive/${pkgver}.tar.gz")
-sha256sums=('453cc817e17cf9aa5c5306df1994828c4f6cf9180e67bede2bbaca1135b43d3c')
+sha256sums=('3cace3f617c0023ffed4b95009752a50c55fe22cbba62d760b85f800ce74697f')

 build() {
-  cd "${_pkgname}-${pkgver}"
+  cd "$srcdir"
+  cmake -B build -S "${_pkgname}-${pkgver}" \
+  -GNinja \
+  -DCMAKE_BUILD_TYPE=None \
+  -DCMAKE_INSTALL_PREFIX=/usr \
+  -DCMAKE_C_FLAGS="$CFLAGS -DNDBEUG" \
+  -DCMAKE_CXX_FLAGS="$CXXFLAGS -DNDEBUG"
+
+  cmake --build build

-  ./unixbuild.sh
 }

 package() {
-  cd "${_pkgname}-${pkgver}"
-
-  local _tool="UEFITool"
-  install -Dm755 "${_tool}" "${pkgdir}/usr/bin/${_tool,,}"
-
-  for _tool in "${_tools[@]}"; do
-    install -Dm755 "${_tool}/${_tool}" "${pkgdir}/usr/bin/${_tool,,}"
-  done
-
-  install -Dm644 UEFIPatch/patches{,-misc}.txt -t "${pkgdir}/usr/share/${pkgname}"
-  install -Dm644 LICENSE.md -t "${pkgdir}/usr/share/licenses/${pkgname}"
+  cd "$srcdir"
+  DESTDIR="$pkgdir" cmake --install build
+  install -Dm644 "$srcdir/${_pkgname}-${pkgver}/LICENSE.md" "$pkgdir/usr/share/licenses/$pkgname/LICENSE"
 }

1. Go to version A72 with a bumped epoch
2. Set license() to be SPDX compliant
3. Proper depends(): qt6-base, hicolor-icon-theme, glibc, gcc-libs
4. Propper makedepends(): cmake, ninja, vulkan-headers
5. Remove any conflicts(), replaces(), or provides(). First off, there should be no provides or conflicts for the "base" package of uefitool, that's a job for any -bin or -git packages. Secondly, no need for replace() anymore
6. Use cmake to build and to install

even if nothing has change for the Image editing engine (0.28.0) some new fixes have appeared in the meantime.

can you update this pkg or do you prefer to let it on the 0.28.0 Version?

the A?? 'releases' are alphas, with certain functionality disabled. you should really keep this package on the 0.28.0 version

Hello,

You should set the epoch value because pacman considers that A59 is a lower version number than 0.27.0:

vercmp "A59" "0.27.0"               
-1

For more information about epoch: https://wiki.archlinux.org/title/PKGBUILD#epoch