Arch Linux User Repository

Fetching the signing key:

gpg --keyserver keyserver.ubuntu.com --recv-keys 927D02FA733C3D902D21CAC02D649F2B7B4C8179

Seems to work fine. I followed the original code; no idea if there's any particular reason for them to use the full path.

I'll shorten it when the next version is released so as to not push unnecessary rebuilds on users. AFAIU, those preferring a different pager would be better served by setting it through their environment anyway.

Does /usr/bin/less need to be invoked with the full path or could you just use "less" and get it from PATH?

I'll patch it, but this should probably be reported to the author: adrianm@gnu.org

The current version of units_cur fails for me, with this error:

Error connecting to currency server:
404 Client Error: Not Found for url: https://services.packetizer.com/spotprices?f=json.

This patch fixes the urls in units_cur:

diff --git a/PKGBUILD b/PKGBUILD
index edea5e4..c376b42 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -22,13 +22,20 @@ validpgpkeys=(
   '927D02FA733C3D902D21CAC02D649F2B7B4C8179' # Adrian Mariano <avm4@cornell.edu>
 )
 source=(https://ftp.gnu.org/gnu/units/$pkgname-$pkgver.tar.gz{,.sig}
+        'fix-units_cur.patch'
         'units_currency.timer'
         'units_currency.service')
 sha256sums=('36edf43ac00b4d6304baea91387e65ab05118bf65c921f73d3b08828e5a6ec0b'
             'SKIP'
+            'a3b868ce3823bb05519b5d63a0cbe2566d269c66949b6c3708bd8c40065bd38c'
             'c1cb48a6157c850a0b7ecbf4387b82820d6e42f4a2c7ff0eb9de293bad6b128f'
             '52e8cd68110e797e3ee3737f06200505225039b18f3f9b87ae38b6c539c9ccb2')

+prepare() {
+  cd "$pkgname-$pkgver"
+  patch -p1 -i "${srcdir}"/fix-units_cur.patch
+}
+
 build() {
   cd "$pkgname-$pkgver"

diff --git a/fix-units_cur.patch b/fix-units_cur.patch
new file mode 100644
index 0000000..35db083
--- /dev/null
+++ b/fix-units_cur.patch
@@ -0,0 +1,14 @@
+diff -ura units-2.25.orig/units_cur units-2.25.new/units_cur
+--- units-2.25.orig/units_cur  2025-12-23 21:47:44.000000000 -0600
++++ units-2.25.new/units_cur   2026-01-23 07:46:01.834817307 -0600
+@@ -556,8 +556,8 @@
+ # Get precious metals data and bitcoin
+ #
+ 
+-metals = getjson('https://services.packetizer.com/spotprices',{'f':'json'})
+-bitcoin = getjson('https://services.packetizer.com/btc',{'f':'json'})
++metals = getjson('https://services.packetizer.com/spotprices/',{'f':'json'})
++bitcoin = getjson('https://services.packetizer.com/btc/',{'f':'json'})
+ 
+ metallist = ['']*len(validmetals)
+ for metal, price in metals.items():

People asking for signature verification on AUR are pretty much just cargo culting and/or box checking. If the maintainer verifies the signature, the sha256sums in the PKGBUILD are good enough for users.

Confirmed; with your patch, makepkg -i works in one step with no compilation issues. Thank you!

Re: configure in prepare(): Understood. My Bash is quite poor, so I didn't understand how readily its behavior could be modified by setting variables before running it.

Thanks for the report, it is unfortunate that I tested it just a few minutes ago, but on a week-old VM snapshot with gcc14.

I believe simply settings CFLAGS before running configure should suffice, could you please check if it works for you also?

diff --git a/PKGBUILD b/PKGBUILD
index f166455..bc3695a 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -29,7 +29,10 @@ sha256sums=('1e502c4edfacf20b29284716c72e5ddb51a495a2365d7b03e7960494c4a0c902'

 build() {
   cd "$pkgname-$pkgver"
-  ./configure --prefix=/usr --datadir=/usr/share --sharedstatedir=/var/lib
+
+  # gcc15 compatibility fix
+  CFLAGS="$CFLAGS -std=gnu17" \
+    ./configure --prefix=/usr --datadir=/usr/share --sharedstatedir=/var/lib

   # /usr/bin/pager seems to be a Debian-ism; it is not provided by any of the
   # packages shipped with Arch Linux. Replace it with less, which, according to

As for prepare(), ./configure is usually called from build() in most official packages I've seen.

Hey, good afternoon.

I'm getting compilation issues when attempting to build this package after the GCC update to version 15. In this update, GCC updated the default language version for C compilation from -std=gnu17 to -std=gnu23, which is yielding compilation errors during the call to make. (makepkg output log: https://pastebin.com/WFfJcZ4k)

The good news is that adding -std=gnu17 to CFLAGS in the generated Makefile resolved the issues and allowed the package to build and install correctly. I tried to do this by editing the configure script (which generates the Makefile) but quickly got bogged down and couldn't figure out what to edit in order to add the flag, so I decided to simply try to edit the Makefile directly as a hack-around.

However, actually editing the Makefile was difficult, since it gets generated during the call to build(), and any changes to it will get overwritten if the Makefile itself is what's edited. Instead, I had to edit the PKGBUILD to move the Makefile-generation steps into a prepare() function. This allowed me to makepkg --nobuild, edit the generated Makefile, and then makepkg -i --noextract.

Regardless of what needs to happen to add -std=gnu17 on a more permanent basis, would you be open to modifying the PKGBUILD to break out a separate prepare() function, as per the patch below? This seems to be more in line with the guidance from Creating packages.

diff --git a/PKGBUILD b/PKGBUILD
index 0de1410..f166455 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -27,7 +27,7 @@ sha256sums=('1e502c4edfacf20b29284716c72e5ddb51a495a2365d7b03e7960494c4a0c902'
             'c1cb48a6157c850a0b7ecbf4387b82820d6e42f4a2c7ff0eb9de293bad6b128f'
             '52e8cd68110e797e3ee3737f06200505225039b18f3f9b87ae38b6c539c9ccb2')

-prepare() {
+build() {
   cd "$pkgname-$pkgver"
   ./configure --prefix=/usr --datadir=/usr/share --sharedstatedir=/var/lib

@@ -36,10 +36,7 @@ prepare() {
   # pkgstats, is shipped on 100% of Arch systems, and will make the 'help'
   # function work correctly on systems with an empty $PAGER env var.
   sed -i 's|DEFAULTPAGER "/usr/bin/pager"|DEFAULTPAGER "/usr/bin/less"|' units.c
-}

-build() {
-  cd "$pkgname-$pkgver"
   make
 }

@cbb, point taken, but I'm going to come under fire either way, because for every person with GPG problems caused by local broken state or misconfiguration, there will always be someone else asking why GPG isn't being used when the upstream source is signed.

(If not for your comment, I would have ignored it as complaints made in a demanding tone by someone with zero contributions to the AUR usually go straight into /dev/null).

Anyway, the key is valid, there is no need to update it. I just tested it on a fresh/empty VM, it builds fine.

@Mackin_cheese Because you haven't contributed yet.

I'd suggest just removing validpgpkeys from the PKGBUILD entirely, since it's pure security theater in AUR packages and only serves to break things in ways that aren't always obvious to the maintainer.