Arch Linux User Repository

I don't want to be that guy, but:

• If the package builds using makepkg -s, I don't care if your AUR helper doesn't work, it's a problem with your AUR helper and needs to be fixed there. Here's the build log for the latest version: https://gist.github.com/Edu4rdSHL/929a7eba81165da5166c4d0974d0e96f
• I can't reproduce the current electron issue with v30, and seems that only a few users are having the issue. So I don't see any reason to downgrade the electron version for everyone. Plus, Athonathonathon put a workaround for it, which seems to be related to the current Chrome breakage on Wayland setups.

The Wayland issue has been fixed from 1.5.1-2 onwards.

Everything you need to run Vesktop will be in the app.asar file. If you don't trust me, or the arch packaging guidelines for electron apps, just try it yourself. Delete everything aside from the app.asar file, run it with electron, and check that you will have the locales for other languages. I just did and I have everything from danish and swedish to spanish and english, as well as every other feature working as expected.

I just checked the app.asar contents and I saw this https://paste.rs/lKcGF, didn't see the locales and the other info there.

@Edu4rdSHL It's not copying the binary with the embedded electron anymore, but it's still copying a bunch of other unneeded files. The only file in /usr/lib/vesktop should be app.asar, everything else is not needed because they are already in the app.asar file itself. The "Total installed size" of the package should be around the size of app.asar.

When you say it wouldn't build on users that don't have any electron in their system, what exactly was happening? electron was in depends already, was it not being installed as a dependency of this package? Because I just tried installing this package with the PKGBUILD from commit cbeccae40c3c6674e852715e17fa038a5ad23920 in a system without electron installed, and it worked just fine.

@picokan, is -12 okay?

Total Download Size:     27.00 MiB
Total Installed Size:    92.88 MiB
Net Upgrade Size:      -169.11 MiB

@picokan, the way the package was before makes it to not build on a clean chroot environment or on users who doesn't have any electron on their system.

@EinfxchFinn, fixed.

Yes, afaik you only need to copy the app.asar if you are using the system electron.

Yeah, can you leave it as it was please? I'm running vesktop as it was before you started changing the PKGBUILD, and I have everything working: locales, vc, etc. Every single feature works as intended with no breakages.

All of those files are embedded into the app.asar file, which are being duplicated when installed this way. When I run pacman -U on your package, the installation size goes from 25.82MB to 261.99MB.

You can still leave it with supporting only the latest electron, but please at least change it back to use the system electron. If needed, re-add me as a co-maintainer and I'll keep taking care of those aspects.

Since 1.5.0-10, when Electron was removed from the dependencies, Vesktop now throws "/usr/bin/vesktop: line 11: exec: electron: not found" and won't start anymore, because the startup script still uses the system electron to start Vesktop.

Well, after checking, if we do not copy the whole thing to /usr/lib we don't get:

• locales
• some required libraries that are built-in
• some soname libraries
• more

The list of files generated actually are https://paste.rs/2uml1.txt

The right thing here is to just let it build as it's actually, remove electron from the dependencies and that's it. Even if we do something like discord_arch_electron, we need to add a fixed electron version for the package. Dropping the electron dependency for now.