Arch Linux User Repository

I should have clarified prior comments. Both VFSTool and LightFixes are built and maintained by me. I take care of my own software. Modding-OpenMW and the MOMW tools pack have nothing on earth to do with me and if anyone wishes to maintain MOMW-adjacent tooling in the AUR, they're more than welcome to do so, but I'd like to continue maintaining my own software.

Hey folks, a couple months ago I did a massive rework of vfstool_lib's internals and replaced all of the C-based dependencies I could with pure Rust ones. The LZ4 link error should now be permanently resolved and some significant performance improvements to be found.

This fails the package() step because of line 45 in the PKGBUILD: install -Dm644 LICENSE "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"

There is no singular LICENSE file, instead there are two different license files: LICENSE-APACHE and LICENSE-MIT. Editing line 45 to copy one or both of them should fix the issue.

Yes, options=('!lto') also fixes it for me. Very odd, I wonder what that's about

Adding options=('!lto') does fix it consistently for me. It's a known thing that rust + lto + arch build system do have very weird interactions

delta-plugin-git builds without any issues for me, for some reason

Kovariszt, could you please do me a favor and see if delta-plugin-git builds for you? These two both have the same lz4 link error, and in my chroot, I was able to build delta-plugin after applying the relevant changes. I'll give it a try here though.

I'm still having the exact same issue as the previous people did, the fix doesn't seem to actually have fixed it

Hey, everyone. I apologize for the delay in fixing this package! I pushed a fix a few days ago that should work. In the check phase, tests also need to be built in release mode or that triggers the lz4 link error.

I tried to investigate it a bit and I'm honestly not entirely sure what the issue is. I think it may be a bug in lzzz, which vfstool_lib inherits from the ba2 crate. lzzz vendors the LZ4 library, so as far as I understand it should build and link properly either way, but, I didn't look at its build.rs especially closely once I got that far down.

I looked into it and has something to do with lto. Removing lto flags fixed it for me. It also seems that the llz4 linker flag isn't needed anymore

diff --git a/PKGBUILD b/PKGBUILD
index 5555780..bf6fbe3 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -9,6 +9,7 @@ provides=(vfstool)
 arch=('i686' 'x86_64' 'armv6h' 'armv7h')
 source=('git+https://github.com/magicaldave/vfstool')
 sha1sums=('SKIP')
+options=('!lto')

 pkgver() {
    cd "${srcdir}/vfstool"
@@ -28,7 +29,6 @@ build() {
    cd "${srcdir}/vfstool"
    export RUSTUP_TOOLCHAIN=stable
    export CARGO_TARGET_DIR=target
-   export RUSTFLAGS+=" -C link-arg=-llz4 "
    cargo build --frozen --release --all-features
 }