Arch Linux User Repository

download source directly from github

This is better for security, as it reduces the number of servers and people you rely on.

--- a/PKGBUILD
+++ b/PKGBUILD
@@ -8,17 +8,17 @@ url=https://github.com/justinmayer/virtualfish
 license=("MIT")
 depends=("fish" "python-packaging" "python-pkgconfig" "python-psutil" "python-virtualenv" "python-setuptools")
 makedepends=("python-build" "python-wheel" "python-installer" "python-poetry-core")
-source=("https://files.pythonhosted.org/packages/source/${pkgname::1}/$pkgname/$pkgname-$pkgver.tar.gz")
-sha256sums=('ea887a44399a4b2621b71f15c1d856d54a3ff3348a3292b0dfcb2d8238fe6932')
+source=("${pkgname}-${pkgver}.tar.gz::${url}/archive/refs/tags/${pkgver}.tar.gz")
+sha512sums=('97ac9da5308f3a27385aae7514f96b5a9c82f1591a4f804d3a74c7243456bff9a44021e923519f9170f61f58798b9209ace288ed951432eec225227b3dbc822f')

 build() {
-    cd "$srcdir/$pkgname-$pkgver"
+    cd "${pkgname}-${pkgver}"

     python -m build --wheel --no-isolation
 }

 package() {
-    cd "$srcdir/$pkgname-$pkgver"
+    cd "${pkgname}-${pkgver}"

     python -m installer --destdir="$pkgdir" dist/*.whl
     install -Dm644 LICENSE "$pkgdir/usr/share/licenses/$pkgname/LICENSE"

@XenGi I think this needs 'python-poetry-core' added to makedepends

==> Extracting sources...
...
ModuleNotFoundError: No module named 'poetry'

ERROR Backend 'poetry.core.masonry.api' is not available.
==> ERROR: A failure occurred in build().
    Aborting...

Setting up vf for the first time. Get the following message: Virtual environment activated but not shown in shell prompt. To fix, see: https://virtualfish.readthedocs.io/en/latest/install.html#customizing-your-fish-prompt Follow the instructions at that link, can cat out the fish prompt config, file is successfully modified. Run exec fish to reset things, then use vf again. Nothing has changed, prompt is no different and message still present. This happening for anyone else?

Setting up vf for the first time. Get the following message: Virtual environment activated but not shown in shell prompt. To fix, see: https://virtualfish.readthedocs.io/en/latest/install.html#customizing-your-fish-prompt Follow the instructions at that link, can cat out the fish prompt config, file is successfully modified. Run exec fish to reset things, then use vf again. Nothing has changed, prompt is no different and message still present. This happening for anyone else?

Thx for the hint. I fixed that.

Seems like the fix from this commit was accidentally removed:

https://aur.archlinux.org/cgit/aur.git/commit/?h=virtualfish&id=f4831688be183e0fb450e95e4745870e1d1bf65f

python-setuptools is still needed at runtime so it should be in depends (virtualfish will install but fail to run after installing in a new chroot)

Just realised this after trying to install this as one of the first packages on a fresh Arch install: "python-setuptools" is missing from depends. virtualfish uses it at runtime, e.g.: https://github.com/justinmayer/virtualfish/blob/7d63a1cfcf111de140d09b0ef0cf39e94ef80685/virtualfish/loader/__init__.py#L4 (pkg_resources is from setuptools)

Ah OK. I didn't connect these two issues. Sure the version requirement could just be removed. I'll probably do that anyway but it would be nicer to understand how epochs work and do this "properly".

It's the version check that is failing to handle the epoch so putting it in package() still ends up with the same problem. Since the program itself still runs and gracefully exits with a user friendly error message when not running in fish or with fish < 3.1 (https://github.com/justinmayer/virtualfish/blob/1764c07829ffe8bdf11396ff5009ca5f4198b24a/virtualfish/loader/cli.py#L37), I think it's OK to leave out the version requirement if there's no other way around the issue with the version check for fish-git. Also another thing to consider, isn't it more likely someone has fish-git installed rather than fish < 3.1 which is will soon be more one year old? Anyway I'm content with using the virtualfish-git package for now. I would rather like to find out the proper way to handle the epoch situation in the first place - we just need someone more knowledgeable to show us the way.