Arch Linux User Repository

loqs posted the solution in the forum Forum: Another build errors with gcc14:

diff --git a/src/menu/netplay.c b/src/menu/netplay.c
index 0b03ec7..f181ebb 100644
--- a/src/menu/netplay.c
+++ b/src/menu/netplay.c
@@ -17,7 +17,7 @@ static char name_str[18];

 static int cursor = -1;

-static init_field(char *str, const char *val, int maxlen)
+static void init_field(char *str, const char *val, int maxlen)
 {
    memset(str, ' ', maxlen+1);
    if (val) {
diff --git a/src/netw/tty_socket.c b/src/netw/tty_socket.c
index c6858a4..1593498 100644
--- a/src/netw/tty_socket.c
+++ b/src/netw/tty_socket.c
@@ -11,6 +11,7 @@
 #include <sys/un.h>
 #include <pwd.h>
 #include <errno.h>
+#include <time.h>
 #include "sock.h"
 #include "internal.h"

With these patches it is possible to build the package with gcc 14.

As of May 13, 2024, the build does not compile with gcc 14. make stops at netplay.c:20 (sorry German locale setting):

netplay.c:20:8: Fehler: Rückgabetyp ist auf »int« voreingestellt [-Wimplicit-int]
   20 | static init_field(char *str, const char *val, int maxlen)

But it does compile with gcc 13. So my workaround was:

CC=gcc-13 ./configure; make

Builds without errors then.

gameserver.c: In function ‘main’:
gameserver.c:618:25: error: format not a string literal and no format arguments [-Werror=format-security]
  618 |                         printf(ctime(&t));
      |                         ^~~~~~
cc1: some warnings being treated as errors
make[1]: *** [Makefile:35: gameserver] Error 1
make[1]: Leaving directory '/tmp/yay/vitetris/src/vitetris-0.59.1/src/netw'
make: *** [Makefile:24: gameserver] Error 2
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: vitetris-exit status 4
 -> Failed to install the following packages. Manual intervention is required:
vitetris - exit status 4

It seems like printf needs a string format, so I add this line to the end of prepare() in PKGBUILD. It successfully builds with this fix.

sed -i 's|ctime(&t)|"%s", &|' src/netw/gameserver.c

I haven't been able to build this since April (I have version 0.59.1-1 on my laptop, but now I'm unable to build it on my desktop as of June). Same error as kleintux, but I'm unable to troubleshoot in detail. From what I can gather, the addition in the compiler of Werror=format-security, which doesn't like fprint, causes the fatal error. If an upstream fix is necessary, is anyone who is able to troubleshoot better able to submit the issue? Otherwise is a patch possible?

The desktop file need to be updated because it calls an executable that doesn't exist

With the current makefile patch renaming the executable, I think the Exec key in the desktop file needs to be changed accordingly.